public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/104757] [12 Regression][OpenMP] ICE in GIMPLE pass: walloca - in gimple_range_global / segfault as SSA_NAME_DEF_STMT is NULL for 'if' clause arg
Date: Thu, 03 Mar 2022 08:22:29 +0000	[thread overview]
Message-ID: <bug-104757-4-a7KwcXDgP1@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-104757-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104757

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:431414b5d934866af3f6415a56c35bb57b928fef

commit r12-7459-g431414b5d934866af3f6415a56c35bb57b928fef
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Mar 3 09:13:32 2022 +0100

    openmp: Disable SSA form during gimplification on OMP_SIMD clauses and body
[PR104757]

    When offloading to nvptx is enabled, scan_omp_simd duplicates the simd
    region including its clauses and body using inliner's
    copy_gimple_seq_and_replace_locals.  That works nicely for decls, remaps
    only those that are seen in the nested bind expr vars (i.e. local
variables)
    and doesn't remap other vars.  But for SSA_NAMEs it remaps them always,
doesn't
    know if their def stmt is outside of the simd (then it better shouldn't be
remapped)
    or inside of it (then it should) and without cfg/dominators that is pretty
hard
    to figure out (well, we could walk the region twice, once note SSA_NAMEs
defined
    by each stmt seen there and once do the remapping of only those visited
SSA_NAMEs).

    This patch uses a simpler way, disables temporarily into_ssa for the
clauses and
    body of each simd region; we already disable into_ssa e.g. in
parallel/target/task
    etc. regions through push_gimplify_context () but for simd we don't push
    any gimplification context and appart from into_ssa I think we don't need
it.

    2022-03-03  Jakub Jelinek  <jakub@redhat.com>

            PR middle-end/104757
            * gimplify.cc (gimplify_omp_loop): Call gimplify_expr rather than
            gimplify_omp_for.
            (gimplify_expr) <case OMP_SIMD>: Temporarily disable
            gimplify_ctxp->into_ssa around call to gimplify_omp_for.

            * gfortran.dg/gomp/pr104757.f90: New test.
            * gcc.dg/gomp/pr104757.c: New test.

  parent reply	other threads:[~2022-03-03  8:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-02 11:06 [Bug middle-end/104757] New: [12 Regression] ICE (segfault) GIMPLE pass: walloca - in gimple_range_global burnus at gcc dot gnu.org
2022-03-02 11:14 ` [Bug middle-end/104757] " tschwinge at gcc dot gnu.org
2022-03-02 11:19 ` burnus at gcc dot gnu.org
2022-03-02 11:25 ` burnus at gcc dot gnu.org
2022-03-02 11:52 ` rguenth at gcc dot gnu.org
2022-03-02 11:52 ` rguenth at gcc dot gnu.org
2022-03-02 15:50 ` burnus at gcc dot gnu.org
2022-03-02 15:57 ` burnus at gcc dot gnu.org
2022-03-02 17:37 ` [Bug middle-end/104757] [12 Regression][OpenMP] ICE in GIMPLE pass: walloca - in gimple_range_global / segfault as SSA_NAME_DEF_STMT is NULL for 'if' clause arg jakub at gcc dot gnu.org
2022-03-02 18:37 ` jakub at gcc dot gnu.org
2022-03-02 18:50 ` jakub at gcc dot gnu.org
2022-03-03  8:22 ` cvs-commit at gcc dot gnu.org [this message]
2022-03-03  8:35 ` jakub at gcc dot gnu.org
2022-03-03 14:35 ` tschwinge at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-104757-4-a7KwcXDgP1@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).