public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug c++/104777] New: gcc crashes while compiling a custom coroutine library sample
@ 2022-03-04 7:45 janezz55 at gmail dot com
2022-03-04 12:54 ` [Bug c++/104777] " marxin at gcc dot gnu.org
` (19 more replies)
0 siblings, 20 replies; 21+ messages in thread
From: janezz55 at gmail dot com @ 2022-03-04 7:45 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104777
Bug ID: 104777
Summary: gcc crashes while compiling a custom coroutine library
sample
Product: gcc
Version: 11.2.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: c++
Assignee: unassigned at gcc dot gnu.org
Reporter: janezz55 at gmail dot com
Target Milestone: ---
The code sample is here https://github.com/user1095108/cr. gcc crashes only if
the optimization level is higher than 2.
g++ -I.. -Ofast -no-pie -std=c++20 loop.cpp -o l
clang compiles everything without issue.
./lduring RTL pass: sched2
In file included from /usr/include/c++/11.2.0/functional:59,
from /usr/include/c++/11.2.0/pstl/glue_algorithm_defs.h:13,
from /usr/include/c++/11.2.0/algorithm:74,
from loop.hpp:5,
from loop.cpp:3:
/usr/include/c++/11.2.0/bits/std_function.h: In static member function 'static
_Res std::_Function_handler<_Res(_ArgTypes ...), _Functor>::_M_invoke(const
std::_Any_data&, _ArgTypes&& ...) [with _Res = void; _Functor =
main()::<lambda()>; _ArgTypes = {}]':
/usr/include/c++/11.2.0/bits/std_function.h:293:7: internal compiler error: in
move_insn, at haifa-sched.c:5471
293 | }
| ^
0xe4c988 internal_error(char const*, ...)
???:0
0xe42d02 fancy_abort(char const*, int, char const*)
???:0
0x13ee792 schedule_block(basic_block_def**, void*)
???:0
0x13da4f2 schedule_insns()
???:0
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <https://bugs.archlinux.org/> for instructions.
^ permalink raw reply [flat|nested] 21+ messages in thread
* [Bug c++/104777] gcc crashes while compiling a custom coroutine library sample
2022-03-04 7:45 [Bug c++/104777] New: gcc crashes while compiling a custom coroutine library sample janezz55 at gmail dot com
@ 2022-03-04 12:54 ` marxin at gcc dot gnu.org
2022-03-04 15:44 ` [Bug c++/104777] gcc crashes while compiling a custom coroutine library sample since r10-5137-g43aae289866f5ea5 marxin at gcc dot gnu.org
` (18 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: marxin at gcc dot gnu.org @ 2022-03-04 12:54 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104777
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |needs-reduction
CC| |marxin at gcc dot gnu.org
Last reconfirmed| |2022-03-04
Status|UNCONFIRMED |NEW
Ever confirmed|0 |1
--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Confirmed, working on that.
^ permalink raw reply [flat|nested] 21+ messages in thread
* [Bug c++/104777] gcc crashes while compiling a custom coroutine library sample since r10-5137-g43aae289866f5ea5
2022-03-04 7:45 [Bug c++/104777] New: gcc crashes while compiling a custom coroutine library sample janezz55 at gmail dot com
2022-03-04 12:54 ` [Bug c++/104777] " marxin at gcc dot gnu.org
@ 2022-03-04 15:44 ` marxin at gcc dot gnu.org
2022-03-04 15:51 ` mpolacek at gcc dot gnu.org
` (17 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: marxin at gcc dot gnu.org @ 2022-03-04 15:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104777
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|gcc crashes while compiling |gcc crashes while compiling
|a custom coroutine library |a custom coroutine library
|sample |sample since
| |r10-5137-g43aae289866f5ea5
CC| |iains at gcc dot gnu.org,
| |mpolacek at gcc dot gnu.org
Keywords|needs-reduction |
--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
Reduced test-case:
$ cat ice.ii
namespace std {
class tuple;
template <typename> auto declval() -> decltype(0);
template <typename> using remove_reference_t = int;
} // namespace std
extern "C" void abort();
namespace std {
template <int, typename _Tp> using tuple_element_t = _Tp;
template <typename _Fn> void __invoke_impl(_Fn __f) { __f(); }
template <typename, typename _Callable> void __invoke_r(_Callable __fn) {
__invoke_impl(__fn);
}
template <typename> class function;
template <typename _Functor> struct _Base_manager {
static _Functor *_M_get_pointer(int) { return 0; }
};
template <typename, typename> class _Function_handler;
template <typename _Res, typename _Functor, typename... _ArgTypes>
struct _Function_handler<_Res(_ArgTypes...), _Functor> {
using _Base = _Base_manager<_Functor>;
static _Res _M_invoke(const int &__functor) {
auto __trans_tmp_1 = _Base::_M_get_pointer(__functor);
__invoke_r<_Res>(*__trans_tmp_1);
return _Res();
}
};
template <typename _Res, typename... _ArgTypes>
struct function<_Res(_ArgTypes...)> {
template <typename _Functor>
using _Handler = _Function_handler<_Res(), _Functor>;
function() {}
template <typename _Functor> function(_Functor) {
using _My_handler = _Handler<_Functor>;
_M_invoker = _My_handler::_M_invoke;
}
using _Invoker_type = _Res (*)(const int &);
_Invoker_type _M_invoker;
};
} // namespace std
bool savestate_r;
int savestate_ssb;
template <typename T> struct list {
using value_type = T;
struct node {
value_type v_;
} * last_;
void emplace_back(auto... a) { last_ = new node(a...); }
};
namespace cr {
namespace detail {
template <long I> using at_t = std::tuple_element_t<I, std::tuple>;
}
struct task {
std::function<void()> f_;
void *r_;
task(auto f) { f_ = f; }
template <typename> auto return_ref() {
return *static_cast<std::remove_reference_t<int> *>(r_);
}
};
struct {
task *pt_;
list<task> l_;
auto previous_task() { return pt_; }
auto run(auto... f) -> decltype(std::declval<detail::at_t<sizeof...(f)>>()) {
(l_.emplace_back(f), ...);
return 0;
}
} thread_local loop;
auto await(auto f) {
using R = decltype(f);
asm("" : "=m"(savestate_ssb), "=r"(savestate_r));
if (savestate_r) {
auto pt(loop.previous_task());
return pt->return_ref<R>();
}
asm("" : : ""(loop));
abort();
}
} // namespace cr
int
main() {
cr::loop.run([] { cr::await([] {}) << cr::await([] {}); });
return 0;
}
Started with -O2 -std=c++2a since r10-5137-g43aae289866f5ea5.
^ permalink raw reply [flat|nested] 21+ messages in thread
* [Bug c++/104777] gcc crashes while compiling a custom coroutine library sample since r10-5137-g43aae289866f5ea5
2022-03-04 7:45 [Bug c++/104777] New: gcc crashes while compiling a custom coroutine library sample janezz55 at gmail dot com
2022-03-04 12:54 ` [Bug c++/104777] " marxin at gcc dot gnu.org
2022-03-04 15:44 ` [Bug c++/104777] gcc crashes while compiling a custom coroutine library sample since r10-5137-g43aae289866f5ea5 marxin at gcc dot gnu.org
@ 2022-03-04 15:51 ` mpolacek at gcc dot gnu.org
2022-03-05 21:44 ` [Bug c++/104777] [10/11/12 Regression] " pinskia at gcc dot gnu.org
` (16 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2022-03-04 15:51 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104777
Marek Polacek <mpolacek at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |mpolacek at gcc dot gnu.org
--- Comment #3 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Weird. Mine then.
^ permalink raw reply [flat|nested] 21+ messages in thread
* [Bug c++/104777] [10/11/12 Regression] gcc crashes while compiling a custom coroutine library sample since r10-5137-g43aae289866f5ea5
2022-03-04 7:45 [Bug c++/104777] New: gcc crashes while compiling a custom coroutine library sample janezz55 at gmail dot com
` (2 preceding siblings ...)
2022-03-04 15:51 ` mpolacek at gcc dot gnu.org
@ 2022-03-05 21:44 ` pinskia at gcc dot gnu.org
2022-03-05 21:45 ` [Bug rtl-optimization/104777] " pinskia at gcc dot gnu.org
` (15 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-03-05 21:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104777
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|gcc crashes while compiling |[10/11/12 Regression] gcc
|a custom coroutine library |crashes while compiling a
|sample since |custom coroutine library
|r10-5137-g43aae289866f5ea5 |sample since
| |r10-5137-g43aae289866f5ea5
Target Milestone|--- |10.4
Target| |x86_64-linux-gnu
^ permalink raw reply [flat|nested] 21+ messages in thread
* [Bug rtl-optimization/104777] [10/11/12 Regression] gcc crashes while compiling a custom coroutine library sample since r10-5137-g43aae289866f5ea5
2022-03-04 7:45 [Bug c++/104777] New: gcc crashes while compiling a custom coroutine library sample janezz55 at gmail dot com
` (3 preceding siblings ...)
2022-03-05 21:44 ` [Bug c++/104777] [10/11/12 Regression] " pinskia at gcc dot gnu.org
@ 2022-03-05 21:45 ` pinskia at gcc dot gnu.org
2022-03-05 21:55 ` [Bug rtl-optimization/104777] [9/10/11/12 Regression] gcc crashes while compiling a custom coroutine library sample pinskia at gcc dot gnu.org
` (14 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-03-05 21:45 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104777
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|c++ |rtl-optimization
--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Does not crash for aarch64-linux-gnu. Maybe some latent bug the change
introduced.
^ permalink raw reply [flat|nested] 21+ messages in thread
* [Bug rtl-optimization/104777] [9/10/11/12 Regression] gcc crashes while compiling a custom coroutine library sample
2022-03-04 7:45 [Bug c++/104777] New: gcc crashes while compiling a custom coroutine library sample janezz55 at gmail dot com
` (4 preceding siblings ...)
2022-03-05 21:45 ` [Bug rtl-optimization/104777] " pinskia at gcc dot gnu.org
@ 2022-03-05 21:55 ` pinskia at gcc dot gnu.org
2022-03-05 21:55 ` pinskia at gcc dot gnu.org
` (13 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-03-05 21:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104777
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Known to fail| |9.1.0, 9.4.0
Assignee|mpolacek at gcc dot gnu.org |unassigned at gcc dot gnu.org
Summary|[10/11/12 Regression] gcc |[9/10/11/12 Regression] gcc
|crashes while compiling a |crashes while compiling a
|custom coroutine library |custom coroutine library
|sample since |sample
|r10-5137-g43aae289866f5ea5 |
Target Milestone|10.4 |9.5
Known to work| |8.5.0
--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Here is a C testcase which shows this is a latent bug (derived from the gimple
of the reduced testcase in comment #2):
_Bool savestate_r;
int savestate_ssb;
extern void abort();
__thread
struct {
int t;
int tt[1];
} loop;
void f (const int * __functor)
{
_Bool savestate_r0_5;
_Bool savestate_r1_6;
__asm__("" : "=m" (savestate_ssb), "=r" (savestate_r));
savestate_r0_5 = savestate_r;
if (savestate_r0_5 != 0)
goto bb3;
else
goto bb4;
bb3:
__asm__("" : "=m" (savestate_ssb), "=r" (savestate_r));
savestate_r1_6 = savestate_r;
if (savestate_r1_6 != 0)
goto bb6;
else
goto bb5;
bb4:
__asm__ __volatile__("" : : "m" (loop));
abort ();
bb5:
__asm__ __volatile__("" : : "m" (loop));
abort ();
bb6:
return;
}
^ permalink raw reply [flat|nested] 21+ messages in thread
* [Bug rtl-optimization/104777] [9/10/11/12 Regression] gcc crashes while compiling a custom coroutine library sample
2022-03-04 7:45 [Bug c++/104777] New: gcc crashes while compiling a custom coroutine library sample janezz55 at gmail dot com
` (5 preceding siblings ...)
2022-03-05 21:55 ` [Bug rtl-optimization/104777] [9/10/11/12 Regression] gcc crashes while compiling a custom coroutine library sample pinskia at gcc dot gnu.org
@ 2022-03-05 21:55 ` pinskia at gcc dot gnu.org
2022-03-05 22:07 ` pinskia at gcc dot gnu.org
` (12 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-03-05 21:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104777
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |NEW
^ permalink raw reply [flat|nested] 21+ messages in thread
* [Bug rtl-optimization/104777] [9/10/11/12 Regression] gcc crashes while compiling a custom coroutine library sample
2022-03-04 7:45 [Bug c++/104777] New: gcc crashes while compiling a custom coroutine library sample janezz55 at gmail dot com
` (6 preceding siblings ...)
2022-03-05 21:55 ` pinskia at gcc dot gnu.org
@ 2022-03-05 22:07 ` pinskia at gcc dot gnu.org
2022-03-08 0:07 ` mpolacek at gcc dot gnu.org
` (11 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-03-05 22:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104777
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Known to work|8.5.0 |8.1.0, 8.3.0
Known to fail| |8.4.0, 8.5.0
--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Note loop being a thread_local (__thread) is important here to get the crash.
Further reduced testcase:
int savestate_r;
int savestate_ssb;
extern void abort();
__thread int loop;
void f (void)
{
int savestate_r0_5;
int savestate_r1_6;
__asm__("" : "=m" (savestate_ssb), "=r" (savestate_r));
savestate_r0_5 = savestate_r;
if (savestate_r0_5 == 0)
{
__asm__ __volatile__("" : : "m" (loop));
abort ();
}
__asm__("" : "=m" (savestate_ssb), "=r" (savestate_r));
savestate_r1_6 = savestate_r;
if (savestate_r1_6 != 0)
return;
__asm__ __volatile__("" : : "m" (loop));
abort ();
}
^ permalink raw reply [flat|nested] 21+ messages in thread
* [Bug rtl-optimization/104777] [9/10/11/12 Regression] gcc crashes while compiling a custom coroutine library sample
2022-03-04 7:45 [Bug c++/104777] New: gcc crashes while compiling a custom coroutine library sample janezz55 at gmail dot com
` (7 preceding siblings ...)
2022-03-05 22:07 ` pinskia at gcc dot gnu.org
@ 2022-03-08 0:07 ` mpolacek at gcc dot gnu.org
2022-03-08 19:00 ` cvs-commit at gcc dot gnu.org
` (10 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2022-03-08 0:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104777
Marek Polacek <mpolacek at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |mpolacek at gcc dot gnu.org
Priority|P3 |P2
Status|NEW |ASSIGNED
--- Comment #7 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Comment 6 testcase started with r270550.
I've posted a patch.
^ permalink raw reply [flat|nested] 21+ messages in thread
* [Bug rtl-optimization/104777] [9/10/11/12 Regression] gcc crashes while compiling a custom coroutine library sample
2022-03-04 7:45 [Bug c++/104777] New: gcc crashes while compiling a custom coroutine library sample janezz55 at gmail dot com
` (8 preceding siblings ...)
2022-03-08 0:07 ` mpolacek at gcc dot gnu.org
@ 2022-03-08 19:00 ` cvs-commit at gcc dot gnu.org
2022-03-08 19:01 ` [Bug rtl-optimization/104777] [9/10/11 " mpolacek at gcc dot gnu.org
` (9 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-03-08 19:00 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104777
--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Marek Polacek <mpolacek@gcc.gnu.org>:
https://gcc.gnu.org/g:e1133c0205a7e2a65834a1af780b8da15eead2a9
commit r12-7540-ge1133c0205a7e2a65834a1af780b8da15eead2a9
Author: Marek Polacek <polacek@redhat.com>
Date: Mon Mar 7 16:15:46 2022 -0500
rtl: ICE with thread_local and inline asm [PR104777]
In r270550, Jakub fixed classify_insn to handle asm goto: if the asm can
jump to a label, the insn should be a JUMP_INSN.
However, as the following testcase shows, non-null ASM_OPERANDS_LABEL_VEC
doesn't guarantee that the rtx has any actual labels it can branch to.
Here, the rtvec has 0 elements because expand_asm_stmt created it:
rtvec labelvec = rtvec_alloc (nlabels); // nlabels == 0
This causes an ICE in update_br_prob_note: BRANCH_EDGE (bb) crashes
because there's no branch edge. I think we can fix this by checking
that there is at least one label the asm can jump to before wrapping
the ASM_OPERANDS in a JUMP_INSN.
PR rtl-optimization/104777
gcc/ChangeLog:
* rtl.cc (classify_insn): For ASM_OPERANDS, return JUMP_INSN only
if
ASM_OPERANDS_LABEL_VEC has at least one element.
gcc/testsuite/ChangeLog:
* gcc.dg/torture/tls/pr104777.c: New test.
^ permalink raw reply [flat|nested] 21+ messages in thread
* [Bug rtl-optimization/104777] [9/10/11 Regression] gcc crashes while compiling a custom coroutine library sample
2022-03-04 7:45 [Bug c++/104777] New: gcc crashes while compiling a custom coroutine library sample janezz55 at gmail dot com
` (9 preceding siblings ...)
2022-03-08 19:00 ` cvs-commit at gcc dot gnu.org
@ 2022-03-08 19:01 ` mpolacek at gcc dot gnu.org
2022-03-10 18:33 ` cvs-commit at gcc dot gnu.org
` (8 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2022-03-08 19:01 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104777
Marek Polacek <mpolacek at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[9/10/11/12 Regression] gcc |[9/10/11 Regression] gcc
|crashes while compiling a |crashes while compiling a
|custom coroutine library |custom coroutine library
|sample |sample
--- Comment #9 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Fixed on trunk so far.
^ permalink raw reply [flat|nested] 21+ messages in thread
* [Bug rtl-optimization/104777] [9/10/11 Regression] gcc crashes while compiling a custom coroutine library sample
2022-03-04 7:45 [Bug c++/104777] New: gcc crashes while compiling a custom coroutine library sample janezz55 at gmail dot com
` (10 preceding siblings ...)
2022-03-08 19:01 ` [Bug rtl-optimization/104777] [9/10/11 " mpolacek at gcc dot gnu.org
@ 2022-03-10 18:33 ` cvs-commit at gcc dot gnu.org
2022-03-10 18:34 ` [Bug rtl-optimization/104777] [9/10 " mpolacek at gcc dot gnu.org
` (7 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-03-10 18:33 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104777
--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Marek Polacek
<mpolacek@gcc.gnu.org>:
https://gcc.gnu.org/g:d66c45fdc14bf88f7390a75129462640c59ce48e
commit r11-9647-gd66c45fdc14bf88f7390a75129462640c59ce48e
Author: Marek Polacek <polacek@redhat.com>
Date: Mon Mar 7 16:15:46 2022 -0500
rtl: ICE with thread_local and inline asm [PR104777]
In r270550, Jakub fixed classify_insn to handle asm goto: if the asm can
jump to a label, the insn should be a JUMP_INSN.
However, as the following testcase shows, non-null ASM_OPERANDS_LABEL_VEC
doesn't guarantee that the rtx has any actual labels it can branch to.
Here, the rtvec has 0 elements because expand_asm_stmt created it:
rtvec labelvec = rtvec_alloc (nlabels); // nlabels == 0
This causes an ICE in update_br_prob_note: BRANCH_EDGE (bb) crashes
because there's no branch edge. I think we can fix this by checking
that there is at least one label the asm can jump to before wrapping
the ASM_OPERANDS in a JUMP_INSN.
PR rtl-optimization/104777
gcc/ChangeLog:
* rtl.c (classify_insn): For ASM_OPERANDS, return JUMP_INSN only if
ASM_OPERANDS_LABEL_VEC has at least one element.
gcc/testsuite/ChangeLog:
* gcc.dg/torture/tls/pr104777.c: New test.
(cherry picked from commit e1133c0205a7e2a65834a1af780b8da15eead2a9)
^ permalink raw reply [flat|nested] 21+ messages in thread
* [Bug rtl-optimization/104777] [9/10 Regression] gcc crashes while compiling a custom coroutine library sample
2022-03-04 7:45 [Bug c++/104777] New: gcc crashes while compiling a custom coroutine library sample janezz55 at gmail dot com
` (11 preceding siblings ...)
2022-03-10 18:33 ` cvs-commit at gcc dot gnu.org
@ 2022-03-10 18:34 ` mpolacek at gcc dot gnu.org
2022-06-13 10:04 ` ubizjak at gmail dot com
` (6 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2022-03-10 18:34 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104777
Marek Polacek <mpolacek at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Summary|[9/10/11 Regression] gcc |[9/10 Regression] gcc
|crashes while compiling a |crashes while compiling a
|custom coroutine library |custom coroutine library
|sample |sample
Status|ASSIGNED |RESOLVED
--- Comment #11 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 21+ messages in thread
* [Bug rtl-optimization/104777] [9/10 Regression] gcc crashes while compiling a custom coroutine library sample
2022-03-04 7:45 [Bug c++/104777] New: gcc crashes while compiling a custom coroutine library sample janezz55 at gmail dot com
` (12 preceding siblings ...)
2022-03-10 18:34 ` [Bug rtl-optimization/104777] [9/10 " mpolacek at gcc dot gnu.org
@ 2022-06-13 10:04 ` ubizjak at gmail dot com
2022-06-13 12:00 ` ubizjak at gmail dot com
` (5 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: ubizjak at gmail dot com @ 2022-06-13 10:04 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104777
Uroš Bizjak <ubizjak at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |stsp at users dot sourceforge.net
--- Comment #12 from Uroš Bizjak <ubizjak at gmail dot com> ---
*** Bug 105936 has been marked as a duplicate of this bug. ***
^ permalink raw reply [flat|nested] 21+ messages in thread
* [Bug rtl-optimization/104777] [9/10 Regression] gcc crashes while compiling a custom coroutine library sample
2022-03-04 7:45 [Bug c++/104777] New: gcc crashes while compiling a custom coroutine library sample janezz55 at gmail dot com
` (13 preceding siblings ...)
2022-06-13 10:04 ` ubizjak at gmail dot com
@ 2022-06-13 12:00 ` ubizjak at gmail dot com
2022-06-13 12:19 ` stsp at users dot sourceforge.net
` (4 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: ubizjak at gmail dot com @ 2022-06-13 12:00 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104777
Uroš Bizjak <ubizjak at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |---
Status|RESOLVED |REOPENED
--- Comment #13 from Uroš Bizjak <ubizjak at gmail dot com> ---
Please backport the patch also to gcc-10 branch.
^ permalink raw reply [flat|nested] 21+ messages in thread
* [Bug rtl-optimization/104777] [9/10 Regression] gcc crashes while compiling a custom coroutine library sample
2022-03-04 7:45 [Bug c++/104777] New: gcc crashes while compiling a custom coroutine library sample janezz55 at gmail dot com
` (14 preceding siblings ...)
2022-06-13 12:00 ` ubizjak at gmail dot com
@ 2022-06-13 12:19 ` stsp at users dot sourceforge.net
2022-06-13 13:26 ` jakub at gcc dot gnu.org
` (3 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: stsp at users dot sourceforge.net @ 2022-06-13 12:19 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104777
--- Comment #14 from Stas Sergeev <stsp at users dot sourceforge.net> ---
(In reply to Uroš Bizjak from comment #13)
> Please backport the patch also to gcc-10 branch.
9.4.0 fails for me on ubuntu-20.
8.5.0 also fails.
Please back-port to all possible
branches.
^ permalink raw reply [flat|nested] 21+ messages in thread
* [Bug rtl-optimization/104777] [9/10 Regression] gcc crashes while compiling a custom coroutine library sample
2022-03-04 7:45 [Bug c++/104777] New: gcc crashes while compiling a custom coroutine library sample janezz55 at gmail dot com
` (15 preceding siblings ...)
2022-06-13 12:19 ` stsp at users dot sourceforge.net
@ 2022-06-13 13:26 ` jakub at gcc dot gnu.org
2022-06-13 14:39 ` mpolacek at gcc dot gnu.org
` (2 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: jakub at gcc dot gnu.org @ 2022-06-13 13:26 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104777
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jakub at gcc dot gnu.org
--- Comment #15 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
9.x and 8.x are not supported anymore, nothing can be backported to those
(upstream, some vendors do support those on their own).
^ permalink raw reply [flat|nested] 21+ messages in thread
* [Bug rtl-optimization/104777] [9/10 Regression] gcc crashes while compiling a custom coroutine library sample
2022-03-04 7:45 [Bug c++/104777] New: gcc crashes while compiling a custom coroutine library sample janezz55 at gmail dot com
` (16 preceding siblings ...)
2022-06-13 13:26 ` jakub at gcc dot gnu.org
@ 2022-06-13 14:39 ` mpolacek at gcc dot gnu.org
2022-06-13 16:29 ` cvs-commit at gcc dot gnu.org
2022-06-13 16:30 ` mpolacek at gcc dot gnu.org
19 siblings, 0 replies; 21+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2022-06-13 14:39 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104777
--- Comment #16 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
I'll backport to 10.
^ permalink raw reply [flat|nested] 21+ messages in thread
* [Bug rtl-optimization/104777] [9/10 Regression] gcc crashes while compiling a custom coroutine library sample
2022-03-04 7:45 [Bug c++/104777] New: gcc crashes while compiling a custom coroutine library sample janezz55 at gmail dot com
` (17 preceding siblings ...)
2022-06-13 14:39 ` mpolacek at gcc dot gnu.org
@ 2022-06-13 16:29 ` cvs-commit at gcc dot gnu.org
2022-06-13 16:30 ` mpolacek at gcc dot gnu.org
19 siblings, 0 replies; 21+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-06-13 16:29 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104777
--- Comment #17 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Marek Polacek
<mpolacek@gcc.gnu.org>:
https://gcc.gnu.org/g:f2851a7cff4d74edca26d39c7bfa1264355a22ed
commit r10-10828-gf2851a7cff4d74edca26d39c7bfa1264355a22ed
Author: Marek Polacek <polacek@redhat.com>
Date: Mon Mar 7 16:15:46 2022 -0500
rtl: ICE with thread_local and inline asm [PR104777]
In r270550, Jakub fixed classify_insn to handle asm goto: if the asm can
jump to a label, the insn should be a JUMP_INSN.
However, as the following testcase shows, non-null ASM_OPERANDS_LABEL_VEC
doesn't guarantee that the rtx has any actual labels it can branch to.
Here, the rtvec has 0 elements because expand_asm_stmt created it:
rtvec labelvec = rtvec_alloc (nlabels); // nlabels == 0
This causes an ICE in update_br_prob_note: BRANCH_EDGE (bb) crashes
because there's no branch edge. I think we can fix this by checking
that there is at least one label the asm can jump to before wrapping
the ASM_OPERANDS in a JUMP_INSN.
PR rtl-optimization/104777
gcc/ChangeLog:
* rtl.c (classify_insn): For ASM_OPERANDS, return JUMP_INSN only if
ASM_OPERANDS_LABEL_VEC has at least one element.
gcc/testsuite/ChangeLog:
* gcc.dg/torture/tls/pr104777.c: New test.
(cherry picked from commit e1133c0205a7e2a65834a1af780b8da15eead2a9)
^ permalink raw reply [flat|nested] 21+ messages in thread
* [Bug rtl-optimization/104777] [9/10 Regression] gcc crashes while compiling a custom coroutine library sample
2022-03-04 7:45 [Bug c++/104777] New: gcc crashes while compiling a custom coroutine library sample janezz55 at gmail dot com
` (18 preceding siblings ...)
2022-06-13 16:29 ` cvs-commit at gcc dot gnu.org
@ 2022-06-13 16:30 ` mpolacek at gcc dot gnu.org
19 siblings, 0 replies; 21+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2022-06-13 16:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104777
Marek Polacek <mpolacek at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|REOPENED |RESOLVED
--- Comment #18 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Done.
^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2022-06-13 16:30 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-04 7:45 [Bug c++/104777] New: gcc crashes while compiling a custom coroutine library sample janezz55 at gmail dot com
2022-03-04 12:54 ` [Bug c++/104777] " marxin at gcc dot gnu.org
2022-03-04 15:44 ` [Bug c++/104777] gcc crashes while compiling a custom coroutine library sample since r10-5137-g43aae289866f5ea5 marxin at gcc dot gnu.org
2022-03-04 15:51 ` mpolacek at gcc dot gnu.org
2022-03-05 21:44 ` [Bug c++/104777] [10/11/12 Regression] " pinskia at gcc dot gnu.org
2022-03-05 21:45 ` [Bug rtl-optimization/104777] " pinskia at gcc dot gnu.org
2022-03-05 21:55 ` [Bug rtl-optimization/104777] [9/10/11/12 Regression] gcc crashes while compiling a custom coroutine library sample pinskia at gcc dot gnu.org
2022-03-05 21:55 ` pinskia at gcc dot gnu.org
2022-03-05 22:07 ` pinskia at gcc dot gnu.org
2022-03-08 0:07 ` mpolacek at gcc dot gnu.org
2022-03-08 19:00 ` cvs-commit at gcc dot gnu.org
2022-03-08 19:01 ` [Bug rtl-optimization/104777] [9/10/11 " mpolacek at gcc dot gnu.org
2022-03-10 18:33 ` cvs-commit at gcc dot gnu.org
2022-03-10 18:34 ` [Bug rtl-optimization/104777] [9/10 " mpolacek at gcc dot gnu.org
2022-06-13 10:04 ` ubizjak at gmail dot com
2022-06-13 12:00 ` ubizjak at gmail dot com
2022-06-13 12:19 ` stsp at users dot sourceforge.net
2022-06-13 13:26 ` jakub at gcc dot gnu.org
2022-06-13 14:39 ` mpolacek at gcc dot gnu.org
2022-06-13 16:29 ` cvs-commit at gcc dot gnu.org
2022-06-13 16:30 ` mpolacek at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).