From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 497A43858D39; Fri,  4 Mar 2022 15:29:37 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 497A43858D39
From: "delleyves at gmx dot ch" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/104785] New: Generated defaulted constexpr operator==
 produces wrong code
Date: Fri, 04 Mar 2022 15:29:37 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 11.2.1
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: delleyves at gmx dot ch
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-104785-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Mar 2022 15:29:37 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D104785

            Bug ID: 104785
           Summary: Generated defaulted constexpr operator=3D=3D produces
                    wrong code
           Product: gcc
           Version: 11.2.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: delleyves at gmx dot ch
  Target Milestone: ---

It seems that the code generated for a defaulted constexpr `operator=3D=3D`=
 for a
struct that inherits a field whose type contains another such `operator=3D=
=3D` does
not take that field into account. Removing constexpr on the top-most
`operator=3D=3D` restores correct behaviour. Therefore, this is likely rela=
ted to
#102490, although that one deals with bitfields. The behaviour seems to be
present on all versions of GCC supporting C++20's defaulted equality operat=
ors,
I did test 10.1 through 11.2 on godbolt.=20

In the following example (godbolt link: https://gcc.godbolt.org/z/7nE67fKxc=
),
the result is wrong only for the `D` type:

#include <iostream>
struct A
{
    int a;

    [[nodiscard]] constexpr bool operator=3D=3D(const A&) const =3D default;
};

struct B
{
    A a;
    int b;

    [[nodiscard]] constexpr bool operator=3D=3D(const B&) const =3D default;
};

struct C : B
{
    int c;

    [[nodiscard]] bool operator=3D=3D(const C&) const =3D default;
};

struct D : B
{
    int d;

    [[nodiscard]] constexpr bool operator=3D=3D(const D&) const =3D default;
};


std::ostream &operator<<(std::ostream &os, const A &a) {
    os << "A("<<a.a<<")";
    return os;
}
std::ostream &operator<<(std::ostream &os, const B &b) {
    os << "B("<<b.a<<", "<<b.b<<")";
    return os;
}
std::ostream &operator<<(std::ostream &os, const C &c) {
    os << "C("<<c.a<<", "<<c.b<<", "<<c.c<<")";
    return os;
}
std::ostream &operator<<(std::ostream &os, const D &d) {
    os << "D("<<d.a<<", "<<d.b<<", "<<d.d<<")";
    return os;
}


int main()
{
    A a1{1}, a2{2};
    B b1{a1,2}, b2{a2,2};
    C c1{b1,3}, c2{b2,3};
    D d1{b1,3}, d2{b2,3};

#define CHECK(x,y) std::cout << x << " =3D=3D " << y << "? " << ((x=3D=3Dy)=
 ? "true" :
"false") << std::endl;
    CHECK(a1,a2);
    CHECK(b1,b2);
    CHECK(c1,c2);
    CHECK(d1,d2);
}=