public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug target/104797] New: too many parentheses in diagnostic for __delay_cycles
@ 2022-03-04 22:23 roland.illig at gmx dot de
2022-03-06 17:33 ` [Bug target/104797] " egallager at gcc dot gnu.org
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: roland.illig at gmx dot de @ 2022-03-04 22:23 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104797
Bug ID: 104797
Summary: too many parentheses in diagnostic for __delay_cycles
Product: gcc
Version: 12.0
Status: UNCONFIRMED
Keywords: diagnostic
Severity: normal
Priority: P3
Component: target
Assignee: unassigned at gcc dot gnu.org
Reporter: roland.illig at gmx dot de
Target Milestone: ---
Target: msp430
>From msp430.cc:
> error ("%<__delay_cycles()%> only takes constant arguments");
> error ("%<__delay_cycles%> only takes non-negative cycle counts");
The parentheses in the first message above have recently been added. They are
wrong. It's the function that takes arguments, not the function call. For
consistency the parentheses should be removed again from the diagnostic.
^ permalink raw reply [flat|nested] 4+ messages in thread* [Bug target/104797] too many parentheses in diagnostic for __delay_cycles 2022-03-04 22:23 [Bug target/104797] New: too many parentheses in diagnostic for __delay_cycles roland.illig at gmx dot de @ 2022-03-06 17:33 ` egallager at gcc dot gnu.org 2022-03-07 10:45 ` cvs-commit at gcc dot gnu.org 2022-03-07 10:45 ` marxin at gcc dot gnu.org 2 siblings, 0 replies; 4+ messages in thread From: egallager at gcc dot gnu.org @ 2022-03-06 17:33 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104797 Eric Gallager <egallager at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |trivial CC| |egallager at gcc dot gnu.org, | |marxin at gcc dot gnu.org Keywords| |easyhack Blocks| |40883 --- Comment #1 from Eric Gallager <egallager at gcc dot gnu.org> --- git blame says the last person to touch these strings was Martin Liška in 58385f6a (which, ironically, was a -Wformat-diag fix) Referenced Bugs: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=40883 [Bug 40883] [meta-bug] Translation breakage with trivial fixes ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug target/104797] too many parentheses in diagnostic for __delay_cycles 2022-03-04 22:23 [Bug target/104797] New: too many parentheses in diagnostic for __delay_cycles roland.illig at gmx dot de 2022-03-06 17:33 ` [Bug target/104797] " egallager at gcc dot gnu.org @ 2022-03-07 10:45 ` cvs-commit at gcc dot gnu.org 2022-03-07 10:45 ` marxin at gcc dot gnu.org 2 siblings, 0 replies; 4+ messages in thread From: cvs-commit at gcc dot gnu.org @ 2022-03-07 10:45 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104797 --- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>: https://gcc.gnu.org/g:40c1d4a07e5798c01e4364336c9617550744861d commit r12-7516-g40c1d4a07e5798c01e4364336c9617550744861d Author: Martin Liska <mliska@suse.cz> Date: Mon Mar 7 11:41:52 2022 +0100 MSP430: fix error message. PR target/104797 gcc/ChangeLog: * config/msp430/msp430.cc (msp430_expand_delay_cycles): Remove parenthesis from built-in name. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug target/104797] too many parentheses in diagnostic for __delay_cycles 2022-03-04 22:23 [Bug target/104797] New: too many parentheses in diagnostic for __delay_cycles roland.illig at gmx dot de 2022-03-06 17:33 ` [Bug target/104797] " egallager at gcc dot gnu.org 2022-03-07 10:45 ` cvs-commit at gcc dot gnu.org @ 2022-03-07 10:45 ` marxin at gcc dot gnu.org 2 siblings, 0 replies; 4+ messages in thread From: marxin at gcc dot gnu.org @ 2022-03-07 10:45 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104797 Martin Liška <marxin at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> --- Fixed. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-07 10:45 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-03-04 22:23 [Bug target/104797] New: too many parentheses in diagnostic for __delay_cycles roland.illig at gmx dot de 2022-03-06 17:33 ` [Bug target/104797] " egallager at gcc dot gnu.org 2022-03-07 10:45 ` cvs-commit at gcc dot gnu.org 2022-03-07 10:45 ` marxin at gcc dot gnu.org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).