[Bug target/104797] New: too many parentheses in diagnostic for __delay_cycles

[Bug target/104797] New: too many parentheses in diagnostic for __delay_cycles

[roland.illig at gmx dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104797

            Bug ID: 104797
           Summary: too many parentheses in diagnostic for __delay_cycles
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Keywords: diagnostic
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: roland.illig at gmx dot de
  Target Milestone: ---
            Target: msp430

>From msp430.cc:
> error ("%<__delay_cycles()%> only takes constant arguments");
> error ("%<__delay_cycles%> only takes non-negative cycle counts");

The parentheses in the first message above have recently been added. They are
wrong. It's the function that takes arguments, not the function call. For
consistency the parentheses should be removed again from the diagnostic.

[Bug target/104797] too many parentheses in diagnostic for __delay_cycles

[egallager at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104797

Eric Gallager <egallager at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |trivial
                 CC|                            |egallager at gcc dot gnu.org,
                   |                            |marxin at gcc dot gnu.org
           Keywords|                            |easyhack
             Blocks|                            |40883

--- Comment #1 from Eric Gallager <egallager at gcc dot gnu.org> ---
git blame says the last person to touch these strings was Martin Liška in
58385f6a (which, ironically, was a -Wformat-diag fix)


Referenced Bugs:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=40883
[Bug 40883] [meta-bug] Translation breakage with trivial fixes

[Bug target/104797] too many parentheses in diagnostic for __delay_cycles

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104797

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:40c1d4a07e5798c01e4364336c9617550744861d

commit r12-7516-g40c1d4a07e5798c01e4364336c9617550744861d
Author: Martin Liska <mliska@suse.cz>
Date:   Mon Mar 7 11:41:52 2022 +0100

    MSP430: fix error message.

            PR target/104797

    gcc/ChangeLog:

            * config/msp430/msp430.cc (msp430_expand_delay_cycles): Remove
            parenthesis from built-in name.

[Bug target/104797] too many parentheses in diagnostic for __delay_cycles

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104797

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
Fixed.