[Bug c++/104806] New: Weird error message: did you mean "__dt "

[Bug c++/104806] New: Weird error message: did you mean "__dt "

[jengelh at inai dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104806

            Bug ID: 104806
           Summary: Weird error message: did you mean "__dt "
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jengelh at inai dot de
  Target Milestone: ---

Input
=====
struct S{};
int main() { S s; s.__d; }

Observed
========
g++ -c x.cpp
gcc version 11.2.1 20220103 [revision d4a1d3c4b377f1d4acb34fe1b55b5088a3f293f6]
(SUSE Linux) 

x.cpp: In function ‘int main()’:
x.cpp:2:21: error: ‘struct S’ has no member named ‘__d’; did you mean ‘__dt ’?
    2 | int main() { S s; s.__d; }
      |                     ^~~
      |                     __dt 

Expected
========
x.cpp: did you mean "__dt"?

That is, without the extra space. In addition, where does __dt come from? I
have not even included anything. This in the source code git repo looks like
the culprit.

gcc/cp/decl.cc:    {"__dt ", &dtor_identifier, cik_dtor},

[Bug c++/104806] Weird error message: did you mean "__dt "

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104806

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Actually "__dt " should not be recommended at all.

[Bug c++/104806] Weird error message: did you mean "__dt "

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104806

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-03-07
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
            Version|unknown                     |12.0

[Bug c++/104806] Weird error message: did you mean "__dt "

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104806

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 52572
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52572&action=edit
gcc12-pr104806.patch

Untested fix.

[Bug c++/104806] Weird error message: did you mean "__dt "

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104806

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:e480c3c06d20874fd7504bfdcca0b829f8000389

commit r12-7544-ge480c3c06d20874fd7504bfdcca0b829f8000389
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Mar 8 21:41:21 2022 +0100

    c++: Don't suggest cdtor or conversion op identifiers in spelling hints
[PR104806]

    On the following testcase, we emit "did you mean '__dt '?" in the error
    message.  "__dt " shows there because it is dtor_identifier, but we
    shouldn't suggest those to the user, they are purely internal and can't
    be really typed by the user because of the final space in it.

    2022-03-08  Jakub Jelinek  <jakub@redhat.com>

            PR c++/104806
            * search.cc (lookup_field_fuzzy_info::fuzzy_lookup_field): Ignore
            identifiers with space at the end.

            * g++.dg/spellcheck-pr104806.C: New test.

[Bug c++/104806] Weird error message: did you mean "__dt "

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104806

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.

[Bug c++/104806] Weird error message: did you mean "__dt "

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104806

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:b7c0962d0c7882b8c019363257c8b632d6c11d5e

commit r11-9725-gb7c0962d0c7882b8c019363257c8b632d6c11d5e
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Mar 8 21:41:21 2022 +0100

    c++: Don't suggest cdtor or conversion op identifiers in spelling hints
[PR104806]

    On the following testcase, we emit "did you mean '__dt '?" in the error
    message.  "__dt " shows there because it is dtor_identifier, but we
    shouldn't suggest those to the user, they are purely internal and can't
    be really typed by the user because of the final space in it.

    2022-03-08  Jakub Jelinek  <jakub@redhat.com>

            PR c++/104806
            * search.c (lookup_field_fuzzy_info::fuzzy_lookup_field): Ignore
            identifiers with space at the end.

            * g++.dg/spellcheck-pr104806.C: New test.

    (cherry picked from commit e480c3c06d20874fd7504bfdcca0b829f8000389)

[Bug c++/104806] Weird error message: did you mean "__dt "

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104806

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:da83eb387b2e0e4dfab73b735beac87ed269c866

commit r10-10692-gda83eb387b2e0e4dfab73b735beac87ed269c866
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Mar 8 21:41:21 2022 +0100

    c++: Don't suggest cdtor or conversion op identifiers in spelling hints
[PR104806]

    On the following testcase, we emit "did you mean '__dt '?" in the error
    message.  "__dt " shows there because it is dtor_identifier, but we
    shouldn't suggest those to the user, they are purely internal and can't
    be really typed by the user because of the final space in it.

    2022-03-08  Jakub Jelinek  <jakub@redhat.com>

            PR c++/104806
            * search.c (lookup_field_fuzzy_info::fuzzy_lookup_field): Ignore
            identifiers with space at the end.

            * g++.dg/spellcheck-pr104806.C: New test.

    (cherry picked from commit e480c3c06d20874fd7504bfdcca0b829f8000389)

[Bug c++/104806] Weird error message: did you mean "__dt "

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104806

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:2a829a4e85ead3e6dff64fe5a8d465cfdf88f3d2

commit r9-10138-g2a829a4e85ead3e6dff64fe5a8d465cfdf88f3d2
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Mar 8 21:41:21 2022 +0100

    c++: Don't suggest cdtor or conversion op identifiers in spelling hints
[PR104806]

    On the following testcase, we emit "did you mean '__dt '?" in the error
    message.  "__dt " shows there because it is dtor_identifier, but we
    shouldn't suggest those to the user, they are purely internal and can't
    be really typed by the user because of the final space in it.

    2022-03-08  Jakub Jelinek  <jakub@redhat.com>

            PR c++/104806
            * search.c (lookup_field_fuzzy_info::fuzzy_lookup_field): Ignore
            identifiers with space at the end.

            * g++.dg/spellcheck-pr104806.C: New test.

    (cherry picked from commit e480c3c06d20874fd7504bfdcca0b829f8000389)