From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id B72B43858021; Tue, 15 Mar 2022 08:14:36 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B72B43858021
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/104814] [10/11/12 Regression] ifcvt: Deleting
 live variable in IF-CASE-2
Date: Tue, 15 Mar 2022 08:14:36 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: rtl-optimization
X-Bugzilla-Version: 12.0
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 10.4
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-104814-4-WNrsd9dZfK@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-104814-4@http.gcc.gnu.org/bugzilla/>
References: <bug-104814-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Mar 2022 08:14:36 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D104814

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:a2645cd8fb33b36d737b310e26f4c47401305c7b

commit r12-7651-ga2645cd8fb33b36d737b310e26f4c47401305c7b
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Mar 15 09:12:03 2022 +0100

    ifcvt: Punt if not onlyjump_p for find_if_case_{1,2} [PR104814]

    find_if_case_{1,2} implicitly assumes conditional jumps and rewrites th=
em,
    so if they have extra side-effects or are say asm goto, things don't wo=
rk
    well, either the side-effects are lost or we could ICE.
    In particular, the testcase below on s390x has there a doloop instructi=
on
    that decrements a register in addition to testing it for non-zero and
    conditionally jumping based on that.

    The following patch fixes that by punting for !onlyjump_p case, i.e.
    if there are side-effects in the jump instruction or it isn't a plain PC
    setter.

    Also, it assumes BB_END (test_bb) will be always non-NULL, because basic
    blocks with 2 non-abnormal successor edges should always have some
instruction
    at the end that determines which edge to take.

    2022-03-15  Jakub Jelinek  <jakub@redhat.com>

            PR rtl-optimization/104814
            * ifcvt.cc (find_if_case_1, find_if_case_2): Punt if test_bb
doesn't
            end with onlyjump_p.  Assume BB_END (test_bb) is always non-NUL=
L.

            * gcc.c-torture/execute/pr104814.c: New test.=