From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 9A5703857810; Fri, 11 Mar 2022 20:43:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9A5703857810 From: "hjl.tools at gmail dot com" To: gcc-bugs@gcc.gnu.org Subject: [Bug target/104816] -fcf-protection=branch should generate endbr instead of notrack jumps Date: Fri, 11 Mar 2022 20:43:26 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: target X-Bugzilla-Version: 12.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: hjl.tools at gmail dot com X-Bugzilla-Status: WAITING X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2022 20:43:26 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D104816 H.J. Lu changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |WAITING --- Comment #8 from H.J. Lu --- (In reply to Joao Moreira from comment #0) > When -fcf-protection=3Dbranch is used, the compiler will generate jump ta= bles > where the indirect jump is prefixed with the NOTRACK prefix, so it can ju= mp > to non-ENDBR targets. Yet, for NOTRACK prefixes to work, the NOTRACK > specific enable bit must be set, what renders the binary broken on any > environment where this is not the case. In fact, having NOTRACK disabled = was > a design choice for the Linux kernel CET support > [https://lkml.org/lkml/2022/3/7/1068]. >=20 > With the above, the compiler should generate jump tables with ENDBRs, for > proper correctness. And, if security regarding the additional ENDBRs is a > concern, the code can be explicitly compiled with -fno-jump-tables. There is an undocumented option: -mcet-switch. It does exactly what you are looking for. Currently it is off by default. We can document it and turn it on by default.=