[Bug target/104818] New: Duplicate word "version" in option -mptx description

[Bug target/104818] New: Duplicate word "version" in option -mptx description

[goeran at uddeborg dot se]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104818

            Bug ID: 104818
           Summary: Duplicate word "version" in option -mptx description
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: goeran at uddeborg dot se
  Target Milestone: ---

In `config/nvptx/nvptx.opt` there is an error message

    Specify the version of the ptx version to use.

https://github.com/gcc-mirror/gcc/blob/2472dcaa8cb9e02e902f83d419c3ee7e0f3d9041/gcc/config/nvptx/nvptx.opt#L80

I guess "version of version" is not what was intended.

[Bug target/104818] Duplicate word "version" in option -mptx description

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104818

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org,
                   |                            |vries at gcc dot gnu.org
   Last reconfirmed|                            |2022-03-07
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

[Bug target/104818] Duplicate word "version" in option -mptx description

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104818

--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@gcc.gnu.org>:

https://gcc.gnu.org/g:0127fb1b78a36a7b228d4b3fe32eedfc8d273363

commit r12-7858-g0127fb1b78a36a7b228d4b3fe32eedfc8d273363
Author: Tom de Vries <tdevries@suse.de>
Date:   Mon Mar 28 17:55:49 2022 +0200

    [nvptx] Improve help description of misa and mptx

    Currently we have:
    ...
    $ gcc --target-help 2>&1 | egrep "misa|mptx"
      -misa=                      Specify the version of the ptx ISA to use.
      -mptx=                      Specify the version of the ptx version to
use.
      Known PTX ISA versions (for use with the -misa= option):
      Known PTX versions (for use with the -mptx= option):
    ...

    As reported in PR104818, the "version of the ptx version" doesn't make much
    sense.

    Furthermore, the description of misa (and 'Known ISA versions') is
misleading
    because it does not specify the version of the PTX ISA, but rather the PTX
ISA
    target architecture.

    Fix this by printing instead:
    ...
    $ gcc --target-help 2>&1 | egrep "misa|mptx"
      -misa=                      Specify the PTX ISA target architecture to
use.
      -mptx=                      Specify the PTX ISA version to use.
      Known PTX ISA target architectures (for use with the -misa= option):
      Known PTX ISA versions (for use with the -mptx= option):
    ...

    Tested on nvptx.

    gcc/ChangeLog:

    2022-03-28  Tom de Vries  <tdevries@suse.de>

            PR target/104818
            * config/nvptx/gen-opt.sh (ptx_isa): Improve help text.
            * config/nvptx/nvptx-gen.opt: Regenerate.
            * config/nvptx/nvptx.opt (misa, mptx, ptx_version): Improve help
text.
            * config/nvptx/t-nvptx (s-nvptx-gen-opt): Add missing dependency on
            gen-opt.sh.

[Bug target/104818] Duplicate word "version" in option -mptx description

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104818

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
   Target Milestone|---                         |12.0

--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
Fixed in aforementioned commit.