public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/104912] [12 Regression] 416.gamess regression after r12-7612-g69619acd8d9b58 Date: Thu, 17 Mar 2022 12:31:32 +0000 [thread overview] Message-ID: <bug-104912-4-YtwErmBNHe@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-104912-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104912 --- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> --- Created attachment 52640 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52640&action=edit patch Like this - this counts the number of vector stmts and the number of strided loads/stores and then when finishing up: +void +ix86_vector_costs::finish_cost (const vector_costs *scalar_costs) +{ + m_finished = true; + if (m_costing_for_scalar) + return; + + /* When we have more than one strided load or store and the + number of strided stores is high compared to all vector + stmts in the body we require at least an estimated + improvement due to the vectorization of a factor of two. */ + if (m_n_body_strided_load_store > 1 + && m_n_body_stmts / m_n_body_strided_load_store < 4) + { + unsigned vf = 1; + if (is_a <loop_vec_info> (m_vinfo)) + vf = vect_vf_for_cost (as_a <loop_vec_info> (m_vinfo)); + if (scalar_costs->prologue_cost () * vf < 2 * body_cost ()) + m_costs[vect_body] *= 2; + } +} the scaling of m_costs[vect_body] will make the vectorization unprofitable. Instead of a hard limit like this we could also scale the strided load cost based on the overall number of them, like if adding m_n_body_strided_load_store squared to the cost. Note that the "true" cost would only be visible when doing a scheduling model with dependences in mind. Note that for this particular case this is all hand-waving since the true cost is the versioning/branching overhead, not the vectorized loop body and the low number of iterations makes this particularly visible. So for 416.gamess it will be all a hack...
next prev parent reply other threads:[~2022-03-17 12:31 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-14 11:06 [Bug target/104912] New: [12 Regression] 416.gamess regression after r12-7612 rguenth at gcc dot gnu.org 2022-03-14 11:06 ` [Bug target/104912] " rguenth at gcc dot gnu.org 2022-03-14 11:55 ` [Bug target/104912] [12 Regression] 416.gamess regression after r12-7612-g69619acd8d9b58 rguenth at gcc dot gnu.org 2022-03-14 11:58 ` rguenth at gcc dot gnu.org 2022-03-14 12:17 ` rguenth at gcc dot gnu.org 2022-03-14 13:49 ` rguenth at gcc dot gnu.org 2022-03-14 14:25 ` rguenth at gcc dot gnu.org 2022-03-17 12:31 ` rguenth at gcc dot gnu.org [this message] 2022-03-21 13:08 ` rguenth at gcc dot gnu.org 2022-04-13 7:54 ` cvs-commit at gcc dot gnu.org 2022-04-13 8:02 ` rguenth at gcc dot gnu.org 2022-04-20 11:28 ` cvs-commit at gcc dot gnu.org 2022-05-06 8:33 ` [Bug target/104912] [12/13 " jakub at gcc dot gnu.org 2022-07-26 12:42 ` rguenth at gcc dot gnu.org 2023-01-31 11:22 ` jamborm at gcc dot gnu.org 2023-01-31 12:02 ` rguenth at gcc dot gnu.org 2023-05-08 12:24 ` [Bug target/104912] [12/13/14 " rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-104912-4-YtwErmBNHe@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).