From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 4184F385C40A; Mon, 14 Mar 2022 11:55:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4184F385C40A From: "rguenth at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug target/104912] [12 Regression] 416.gamess regression after r12-7612-g69619acd8d9b58 Date: Mon, 14 Mar 2022 11:55:25 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: target X-Bugzilla-Version: 12.0 X-Bugzilla-Keywords: missed-optimization X-Bugzilla-Severity: normal X-Bugzilla-Who: rguenth at gcc dot gnu.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 12.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Mar 2022 11:55:25 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D104912 --- Comment #1 from Richard Biener --- +mccas.fppized.f:3160:21: optimized: loop vectorized using 16 byte vectors +mccas.fppized.f:3160:21: optimized: loop versioned for vectorization beca= use of possible aliasing +mccas.fppized.f:3195:21: optimized: loop vectorized using 16 byte vectors +mccas.fppized.f:3195:21: optimized: loop versioned for vectorization beca= use of possible aliasing +mccas.fppized.f:3259:21: optimized: loop vectorized using 16 byte vectors +mccas.fppized.f:3259:21: optimized: loop versioned for vectorization beca= use of possible aliasing +mccas.fppized.f:3304:21: optimized: loop vectorized using 16 byte vectors +mccas.fppized.f:3304:21: optimized: loop versioned for vectorization beca= use of possible aliasing mccas.fppized.f:2576:18: optimized: loop vectorized using 16 byte vectors mccas.fppized.f:2524:17: optimized: loop vectorized using 16 byte vectors mccas.fppized.f:3055:22: optimized: loop vectorized using 16 byte vectors @@ -147,9 +155,11 @@ mccas.fppized.f:1890:25: optimized: loop vectorized using 16 byte vectors mccas.fppized.f:1859:20: optimized: loop vectorized using 16 byte vectors mccas.fppized.f:1843:19: optimized: loop vectorized using 16 byte vectors +mccas.fppized.f:1843:19: optimized: loop vectorized using 16 byte vectors mccas.fppized.f:1737:17: optimized: loop vectorized using 16 byte vectors mccas.fppized.f:1727:20: optimized: loop vectorized using 16 byte vectors mccas.fppized.f:1714:19: optimized: loop vectorized using 16 byte vectors +mccas.fppized.f:1714:19: optimized: loop vectorized using 16 byte vectors mccas.fppized.f:884:24: optimized: loop vectorized using 16 byte vectors mccas.fppized.f:904:33: optimized: basic block part vectorized using 16 by= te vectors mccas.fppized.f:653:17: optimized: loop vectorized using 16 byte vectors @@ -159,8 +169,11 @@ mccas.fppized.f:1188:14: optimized: loop vectorized using 16 byte vectors mccas.fppized.f:1188:14: optimized: loop versioned for vectorization beca= use of possible aliasing mccas.fppized.f:522:72: optimized: basic block part vectorized using 16 by= te vectors +mccas.fppized.f:522:72: optimized: basic block part vectorized using 16 by= te vectors mccas.fppized.f:2399:14: optimized: loop vectorized using 16 byte vectors mccas.fppized.f:2399:14: optimized: loop versioned for vectorization beca= use of possible aliasing mccas.fppized.f:2130:14: optimized: loop vectorized using 16 byte vectors mccas.fppized.f:2261:72: optimized: basic block part vectorized using 16 b= yte vectors +mccas.fppized.f:2261:72: optimized: basic block part vectorized using 16 b= yte vectors +mccas.fppized.f:2261:72: optimized: basic block part vectorized using 16 b= yte vectors are the vectorization differences, the performance difference happens entir= ely in TWOTFF (lines 3209 and following). +mccas.fppized.f:3304:21: optimized: loop vectorized using 16 byte vectors +mccas.fppized.f:3304:21: optimized: loop versioned for vectorization beca= use of possible aliasing are the inner loops of DO 30 MK=3D1,NOC DO 30 ML=3D1,MK MKL =3D MKL+1 XPQKL(MPQ,MKL) =3D XPQKL(MPQ,MKL) + * VAL1*(CO(MS,MK)*CO(MR,ML)+CO(MS,ML)*CO(MR,MK)) XPQKL(MRS,MKL) =3D XPQKL(MRS,MKL) + * VAL3*(CO(MQ,MK)*CO(MP,ML)+CO(MQ,ML)*CO(MP,MK)) 30 CONTINUE and the other similar copy. We are doing all strided loads and stores here but the vectorized code never executes, instead we just pay the overhead of the runtime alias test for each inner iteration (we'd ideally formulate it in a way including the outer iteration so we could version the outer loop instead). The runtime alias check is XPOKL(MPQ,MKL) vs. XPOKL(MRS,MKL) - an index check on MPQ should be invariant but I guess the situation is more complicated than that. The cost model differences for this are mccas.fppized.f:3304:21: note: Cost model analysis: Vector inside of loop cost: 552 Vector prologue cost: 48 Vector epilogue cost: 280 Scalar iteration cost: 264 Scalar outside cost: 8 Vector outside cost: 328 prologue iterations: 0 epilogue iterations: 1 mccas.fppized.f:3304:21: missed: cost model: the vector iteration cost =3D= 552 divided by the scalar iteration cost =3D 264 is greater or equal to the vectorization factor =3D 2. mccas.fppized.f:3304:21: missed: not vectorized: vectorization not profita= ble. mccas.fppized.f:3304:21: missed: not vectorized: vector version will never= be profitable. mccas.fppized.f:3304:21: missed: Loop costings may not be worthwhile. vs. mccas.fppized.f:3304:21: note: Cost model analysis: Vector inside of loop cost: 480 Vector prologue cost: 48 Vector epilogue cost: 280 Scalar iteration cost: 264 Scalar outside cost: 8 Vector outside cost: 328 prologue iterations: 0 epilogue iterations: 1 Calculated minimum iters for profitability: 4 where the V2DF vec_construct costs are reduced from 24 to 12 which I think is reasonable since we're replacing two scalar loads with one scalar load and one movhpd from memory.=