public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "syq at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug rtl-optimization/104914] [MIPS] wrong comparison with scrabbled int value Date: Fri, 14 Jul 2023 10:15:30 +0000 [thread overview] Message-ID: <bug-104914-4-485l4NuPH7@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-104914-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104914 --- Comment #14 from YunQiang Su <syq at gcc dot gnu.org> --- New patch: diff --git a/gcc/expmed.cc b/gcc/expmed.cc index fbd4ce2d42f..66d45da67df 100644 --- a/gcc/expmed.cc +++ b/gcc/expmed.cc @@ -850,6 +850,7 @@ store_bit_field_1 (rtx str_rtx, poly_uint64 bitsize, poly_uint64 bitnum, since that case is valid for any mode. The following cases are only valid for integral modes. */ opt_scalar_int_mode op0_mode = int_mode_for_mode (GET_MODE (op0)); + opt_scalar_int_mode str_mode = int_mode_for_mode (GET_MODE (str_rtx)); scalar_int_mode imode; if (!op0_mode.exists (&imode) || imode != GET_MODE (op0)) { @@ -881,8 +882,15 @@ store_bit_field_1 (rtx str_rtx, poly_uint64 bitsize, poly_uint64 bitnum, op0 = gen_lowpart (op0_mode.require (), op0); } - return store_integral_bit_field (op0, op0_mode, ibitsize, ibitnum, - bitregion_start, bitregion_end, + bool use_str_mode = false; + if (GET_MODE_CLASS(GET_MODE (str_rtx)) == MODE_INT + && GET_MODE_CLASS(GET_MODE (op0)) == MODE_INT + && known_gt (GET_MODE_SIZE(GET_MODE(op0)), GET_MODE_SIZE(GET_MODE(str_rtx)))) + use_str_mode = true; + + return store_integral_bit_field (use_str_mode ? str_rtx : op0, + use_str_mode ? str_mode : op0_mode, + ibitsize, ibitnum, bitregion_start, bitregion_end, fieldmode, value, reverse, fallback_p); }
next prev parent reply other threads:[~2023-07-14 10:15 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-14 11:49 [Bug target/104914] New: " mmyangfl at gmail dot com 2022-03-14 12:13 ` [Bug target/104914] " mmyangfl at gmail dot com 2023-07-04 6:42 ` syq at gcc dot gnu.org 2023-07-04 8:33 ` syq at gcc dot gnu.org 2023-07-04 9:05 ` pinskia at gcc dot gnu.org 2023-07-04 10:14 ` syq at gcc dot gnu.org 2023-07-05 9:50 ` syq at gcc dot gnu.org 2023-07-06 19:05 ` [Bug rtl-optimization/104914] " pinskia at gcc dot gnu.org 2023-07-07 4:21 ` syq at gcc dot gnu.org 2023-07-07 4:31 ` pinskia at gcc dot gnu.org 2023-07-07 4:52 ` pinskia at gcc dot gnu.org 2023-07-07 5:05 ` pinskia at gcc dot gnu.org 2023-07-07 5:12 ` pinskia at gcc dot gnu.org 2023-07-12 2:23 ` syq at gcc dot gnu.org 2023-07-14 10:15 ` syq at gcc dot gnu.org [this message] 2023-08-03 9:09 ` roger at nextmovesoftware dot com 2023-08-03 9:34 ` syq at gcc dot gnu.org 2023-12-24 13:53 ` roger at nextmovesoftware dot com 2023-12-24 14:06 ` roger at nextmovesoftware dot com 2023-12-24 16:15 ` roger at nextmovesoftware dot com 2023-12-24 23:04 ` syq at gcc dot gnu.org 2023-12-25 1:44 ` syq at gcc dot gnu.org 2023-12-25 1:47 ` syq at gcc dot gnu.org 2023-12-27 14:02 ` syq at gcc dot gnu.org 2024-01-04 1:56 ` cvs-commit at gcc dot gnu.org 2024-01-04 10:50 ` cvs-commit at gcc dot gnu.org 2024-01-04 11:10 ` syq at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-104914-4-485l4NuPH7@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).