public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/104952] [nvptx][OpenMP] wrong code with OR / AND reduction ('reduction(||:' and '&&') with SIMT Date: Thu, 17 Mar 2022 13:29:05 +0000 [thread overview] Message-ID: <bug-104952-4-03p5TBNSRC@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-104952-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104952 --- Comment #7 from Tom de Vries <vries at gcc dot gnu.org> --- Alternative fix that doesn't require fiddling with the 'code' var: ... diff --git a/gcc/omp-low.cc b/gcc/omp-low.cc index d932d74cb03..d0ddd4a6142 100644 --- a/gcc/omp-low.cc +++ b/gcc/omp-low.cc @@ -6734,7 +6734,10 @@ lower_rec_input_clauses (tree clauses, gimple_seq *ilist, gimpl e_seq *dlist, x = build_call_expr_internal_loc (UNKNOWN_LOCATION, IFN_GOMP_SIMT_XCHG_BFLY, TREE_TYPE (ivar), 2, ivar, simt_lane); - x = build2 (code, TREE_TYPE (ivar), ivar, x); + /* Make sure x is evaluated unconditionally. */ + tree bfly_var = create_tmp_var (TREE_TYPE (ivar)); + gimplify_assign (bfly_var, x, &llist[2]); + x = build2 (code, TREE_TYPE (ivar), ivar, bfly_var); gimplify_assign (ivar, x, &llist[2]); } tree ivar2 = ivar; ...
next prev parent reply other threads:[~2022-03-17 13:29 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-16 11:42 [Bug target/104952] New: " burnus at gcc dot gnu.org 2022-03-17 10:30 ` [Bug target/104952] " vries at gcc dot gnu.org 2022-03-17 12:07 ` vries at gcc dot gnu.org 2022-03-17 12:46 ` vries at gcc dot gnu.org 2022-03-17 12:56 ` vries at gcc dot gnu.org 2022-03-17 13:04 ` jakub at gcc dot gnu.org 2022-03-17 13:14 ` jakub at gcc dot gnu.org 2022-03-17 13:29 ` vries at gcc dot gnu.org [this message] 2022-03-17 13:31 ` vries at gcc dot gnu.org 2022-03-17 14:12 ` vries at gcc dot gnu.org 2022-03-17 14:17 ` jakub at gcc dot gnu.org 2022-03-18 14:46 ` cvs-commit at gcc dot gnu.org 2022-03-18 14:48 ` vries at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-104952-4-03p5TBNSRC@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).