[Bug target/104974] New: [avx512fp16] Error: operand type mismatch for `vmovw'

[Bug target/104974] New: [avx512fp16] Error: operand type mismatch for `vmovw'

[crazylht at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104974

            Bug ID: 104974
           Summary: [avx512fp16]  Error: operand type mismatch for `vmovw'
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: crazylht at gmail dot com
  Target Milestone: ---

cat test.c

short
foo (short a)
{
  register short b __asm ("%xmm1") = a;
  asm volatile ("": "+v" (b));
  register short c __asm ("%xmm2") = b;
  asm volatile ("": "+v" (c));
  return a;
}

foo(short):
        mov     eax, edi
        vmovw   xmm1, edi
        vmovw   xmm2, xmm1 
        ret

To move HImode from sse reg to sse reg under avx512fp16, vmovsh should be used
instead of vmovw.

[Bug target/104974] [avx512fp16] Error: operand type mismatch for `vmovw'

[crazylht at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104974

Hongtao.liu <crazylht at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |x86_64-*-* i?86-*-*
           Keywords|                            |wrong-code

--- Comment #1 from Hongtao.liu <crazylht at gmail dot com> ---
I'm testing

--- a/gcc/config/i386/i386.md
+++ b/gcc/config/i386/i386.md
@@ -2658,7 +2658,7 @@ (define_insn "*movhi_internal"
                    (const_string "TI"))
            (eq_attr "alternative" "12")
              (cond [(match_test "TARGET_AVX512FP16")
-                      (const_string "HI")
+                      (const_string "HF")
                     (match_test "TARGET_AVX")
                       (const_string "TI")
                     (ior (not (match_test "TARGET_SSE2"))

[Bug target/104974] [avx512fp16] Error: operand type mismatch for `vmovw'

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104974

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by hongtao Liu <liuhongt@gcc.gnu.org>:

https://gcc.gnu.org/g:1f5c0e67393e8f67d66150eba8c64edfeb14e11b

commit r12-7700-g1f5c0e67393e8f67d66150eba8c64edfeb14e11b
Author: liuhongt <hongtao.liu@intel.com>
Date:   Fri Mar 18 16:11:04 2022 +0800

    Refine HImode movement for "v" to "v".

    Set attr from HImode to HFmode which uses vmovsh instead of vmovw for
    movment between sse registers.

    gcc/ChangeLog:

            PR target/104974
            * config/i386/i386.md (*movhi_internal): Set attr type from HI
            to HF for alternative 12 under TARGET_AVX512FP16.

    gcc/testsuite/ChangeLog:

            * gcc.target/i386/pr104974.c: New test.

[Bug target/104974] [avx512fp16] Error: operand type mismatch for `vmovw'

[crazylht at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104974

Hongtao.liu <crazylht at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #3 from Hongtao.liu <crazylht at gmail dot com> ---
Fixed in GCC12.