public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "mikael at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug fortran/105012] [12/13 Regression] wrf from SPECCPU2017 ICEs during LTO linking since r12-7692-g8db155ddf8cec9 Date: Thu, 25 Aug 2022 21:19:41 +0000 [thread overview] Message-ID: <bug-105012-4-fD5EQavK2x@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-105012-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105012 --- Comment #28 from Mikael Morin <mikael at gcc dot gnu.org> --- (In reply to anlauf from comment #23) > > No, they're not, when the procedures are in the same file. > At least that's what gdb tells me... gdb tells me the same. :-) It is a side effect of calling gfc_check_externals it seems. (In reply to anlauf from comment #27) > (In reply to Mikael Morin from comment #26) > > > > Upon return from gfc_conv_expr, se->expr holds the value of the expression. > > So basically var = se->expr; > > As we manage to pass __result_derfc as argument, then I expect se->expr to > > have value __result_derfc at that point. > > I tried that - just rechecked - and get an ICE: gimplification failed. > So there's some magic missing I don't see... With se->expr, what is generated is: &__result_derfc = {CLOBBER}; Not too bad, but not exactly there yet. With the following, I get the expected result. Indeed, with se->want_pointer set, gfc_conv_expr generates an address expression, so it has to be dereferenced to get back the variable. diff --git a/gcc/fortran/trans-expr.cc b/gcc/fortran/trans-expr.cc index 6c8fa16e723..367ecc2eb65 100644 --- a/gcc/fortran/trans-expr.cc +++ b/gcc/fortran/trans-expr.cc @@ -9602,7 +9602,7 @@ gfc_conv_expr_reference (gfc_se * se, gfc_expr * expr, bool add_clobber) tree var; /* FIXME: This fails if var is passed by reference, see PR 41453. */ - var = expr->symtree->n.sym->backend_decl; + var = build_fold_indirect_ref_loc (input_location, se->expr); clobber = build_clobber (TREE_TYPE (var)); gfc_add_modify (&se->pre, var, clobber); }
next prev parent reply other threads:[~2022-08-25 21:19 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-22 8:54 [Bug lto/105012] New: [12 Regression] wrf from SPECCPU2017 ICEs during LTO linking tnfchris at gcc dot gnu.org 2022-03-22 9:36 ` [Bug lto/105012] " marxin at gcc dot gnu.org 2022-03-22 10:21 ` rguenth at gcc dot gnu.org 2022-03-22 10:23 ` rguenth at gcc dot gnu.org 2022-03-22 10:37 ` marxin at gcc dot gnu.org 2022-03-22 10:52 ` rguenth at gcc dot gnu.org 2022-03-22 10:53 ` [Bug lto/105012] [12 Regression] wrf from SPECCPU2017 ICEs during LTO linking since r12-7692-g8db155ddf8cec9 marxin at gcc dot gnu.org 2022-03-22 10:58 ` marxin at gcc dot gnu.org 2022-03-22 11:06 ` [Bug fortran/105012] " rguenth at gcc dot gnu.org 2022-03-22 11:09 ` marxin at gcc dot gnu.org 2022-03-22 11:11 ` rguenth at gcc dot gnu.org 2022-03-22 11:18 ` rguenth at gcc dot gnu.org 2022-03-22 11:20 ` rguenth at gcc dot gnu.org 2022-03-22 11:31 ` rguenth at gcc dot gnu.org 2022-03-22 13:05 ` cvs-commit at gcc dot gnu.org 2022-03-22 13:07 ` rguenth at gcc dot gnu.org 2022-05-06 8:33 ` [Bug fortran/105012] [12/13 " jakub at gcc dot gnu.org 2022-08-24 19:36 ` anlauf at gcc dot gnu.org 2022-08-24 20:34 ` anlauf at gcc dot gnu.org 2022-08-25 6:13 ` rguenth at gcc dot gnu.org 2022-08-25 6:18 ` rguenth at gcc dot gnu.org 2022-08-25 19:50 ` mikael at gcc dot gnu.org 2022-08-25 19:55 ` anlauf at gcc dot gnu.org 2022-08-25 19:57 ` anlauf at gcc dot gnu.org 2022-08-25 20:06 ` mikael at gcc dot gnu.org 2022-08-25 20:30 ` anlauf at gcc dot gnu.org 2022-08-25 20:40 ` mikael at gcc dot gnu.org 2022-08-25 20:47 ` anlauf at gcc dot gnu.org 2022-08-25 21:19 ` mikael at gcc dot gnu.org [this message] 2022-08-25 21:31 ` anlauf at gcc dot gnu.org 2022-08-28 10:27 ` mikael at gcc dot gnu.org 2022-09-02 19:04 ` mikael at gcc dot gnu.org 2022-09-25 12:48 ` cvs-commit at gcc dot gnu.org 2022-09-25 12:48 ` cvs-commit at gcc dot gnu.org 2022-10-10 20:04 ` cvs-commit at gcc dot gnu.org 2022-10-10 20:53 ` cvs-commit at gcc dot gnu.org 2022-10-12 12:34 ` cvs-commit at gcc dot gnu.org 2022-10-12 12:42 ` mikael at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-105012-4-fD5EQavK2x@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).