[Bug analyzer/105017] New: gcc/analyzer/sm-taint.cc:631:21: warning: private field 'm_mem_space' is not used [-Wunused-private-field]

[Bug analyzer/105017] New: gcc/analyzer/sm-taint.cc:631:21: warning: private field 'm_mem_space' is not used [-Wunused-private-field]

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105017

            Bug ID: 105017
           Summary: gcc/analyzer/sm-taint.cc:631:21: warning: private
                    field 'm_mem_space' is not used
                    [-Wunused-private-field]
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: analyzer
          Assignee: dmalcolm at gcc dot gnu.org
          Reporter: marxin at gcc dot gnu.org
  Target Milestone: ---

[Bug analyzer/105017] [12 Regression] gcc/analyzer/sm-taint.cc:631:21: warning: private field 'm_mem_space' is not used [-Wunused-private-field]

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105017

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|gcc/analyzer/sm-taint.cc:63 |[12 Regression]
                   |1:21: warning: private      |gcc/analyzer/sm-taint.cc:63
                   |field 'm_mem_space' is not  |1:21: warning: private
                   |used                        |field 'm_mem_space' is not
                   |[-Wunused-private-field]    |used
                   |                            |[-Wunused-private-field]
   Target Milestone|---                         |12.0

[Bug analyzer/105017] [12 Regression] gcc/analyzer/sm-taint.cc:631:21: warning: private field 'm_mem_space' is not used [-Wunused-private-field]

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105017

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-03-22
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED

[Bug analyzer/105017] [12 Regression] gcc/analyzer/sm-taint.cc:631:21: warning: private field 'm_mem_space' is not used [-Wunused-private-field]

[egallager at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105017

Eric Gallager <egallager at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=72789
                 CC|                            |egallager at gcc dot gnu.org

--- Comment #1 from Eric Gallager <egallager at gcc dot gnu.org> ---
would be nice if GCC could detect this itself (see bug 72789)

[Bug analyzer/105017] [12 Regression] gcc/analyzer/sm-taint.cc:631:21: warning: private field 'm_mem_space' is not used [-Wunused-private-field]

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105017

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by David Malcolm <dmalcolm@gcc.gnu.org>:

https://gcc.gnu.org/g:e6a3991ea15c0b14117b5693d77e15fd0477ce51

commit r12-7783-ge6a3991ea15c0b14117b5693d77e15fd0477ce51
Author: David Malcolm <dmalcolm@redhat.com>
Date:   Wed Mar 23 08:37:06 2022 -0400

    analyzer: use tainted_allocation_size::m_mem_space [PR105017]

    gcc/analyzer/ChangeLog:
            PR analyzer/105017
            * sm-taint.cc (taint_diagnostic::subclass_equal_p): Check
            m_has_bounds as well as m_arg.
            (tainted_allocation_size::subclass_equal_p): Chain up to base
            class implementation.  Also check m_mem_space.
            (tainted_allocation_size::emit): Add note showing stack-based vs
            heap-based allocations.

    gcc/testsuite/ChangeLog:
            PR analyzer/105017
            * gcc.dg/analyzer/taint-alloc-1.c: Add expected messages relating
            to heap vs stack.

    Signed-off-by: David Malcolm <dmalcolm@redhat.com>

[Bug analyzer/105017] [12 Regression] gcc/analyzer/sm-taint.cc:631:21: warning: private field 'm_mem_space' is not used [-Wunused-private-field]

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105017

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
I'm assuming that this was a clang warning, and that this is fixed by the above
commit; please reopen if it's still affected.

[Bug analyzer/105017] [12 Regression] gcc/analyzer/sm-taint.cc:631:21: warning: private field 'm_mem_space' is not used [-Wunused-private-field]

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105017

--- Comment #4 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to David Malcolm from comment #3)
> I'm assuming that this was a clang warning, and that this is fixed by the
> above commit; please reopen if it's still affected.

Thanks, it fixed the clang warning!