[Bug target/105058] New: Incorrect register constraint in KL patterns

[Bug target/105058] New: Incorrect register constraint in KL patterns

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105058

            Bug ID: 105058
           Summary: Incorrect register constraint in KL patterns
           Product: gcc
           Version: 11.2.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: hjl.tools at gmail dot com
                CC: crazylht at gmail dot com
  Target Milestone: ---
            Target: i386,x86-64

KL patterns shouldn't use the "v" register constraints since they don't support
AVX512.

[Bug target/105058] Incorrect register constraint in KL patterns

[crazylht at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105058

--- Comment #1 from Hongtao.liu <crazylht at gmail dot com> ---
cat test.c

 #include <immintrin.h>

 unsigned int ctrl;
 __m128i k1, k2, k3;

 void
 test_keylocker_11 (void)
 {
   register __m128i k4 __asm ("xmm16") = k2;
  asm volatile ("" : "+v" (k4));
  _mm_loadiwkey (ctrl, k1, k4, k3);
 }

gcc -O2 -march=skylake-avx512 -mkl -c


/tmp/ccy9VHP9.s: Assembler messages:
/tmp/ccy9VHP9.s:13: Error: unsupported instruction `loadiwkey'

[Bug target/105058] Incorrect register constraint in KL patterns

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105058

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by H.J. Lu <hjl@gcc.gnu.org>:

https://gcc.gnu.org/g:ede5f5224d55b84b9f186b288164df9c06fd85e7

commit r12-7829-gede5f5224d55b84b9f186b288164df9c06fd85e7
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Mar 25 10:48:16 2022 -0700

    x86: Use x constraint on KL patterns

    Since KL instructions have no AVX512 version, replace the "v" register
    constraint with the "x" register constraint.

            PR target/105058
            * config/i386/sse.md (loadiwkey): Replace "v" with "x".
            (aes<aesklvariant>u8): Likewise.

[Bug target/105058] Incorrect register constraint in KL patterns

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105058

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by H.J. Lu <hjl@gcc.gnu.org>:

https://gcc.gnu.org/g:f0ed5f0763933de8287b3e01aa7fd3efdd77d485

commit r11-9695-gf0ed5f0763933de8287b3e01aa7fd3efdd77d485
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Mar 25 10:48:16 2022 -0700

    x86: Use x constraint on KL patterns

    Since KL instructions have no AVX512 version, replace the "v" register
    constraint with the "x" register constraint.

            PR target/105058
            * config/i386/sse.md (loadiwkey): Replace "v" with "x".
            (aes<aesklvariant>u8): Likewise.

    (cherry picked from commit ede5f5224d55b84b9f186b288164df9c06fd85e7)

[Bug target/105058] Incorrect register constraint in KL patterns

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105058

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
   Target Milestone|---                         |11.3

--- Comment #4 from H.J. Lu <hjl.tools at gmail dot com> ---
Fixed for GCC 12 and GCC 11.3.