public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "marxin at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/105069] [12 regression] sh-elf internal compiler errors and test failures with -Os
Date: Thu, 31 Mar 2022 08:09:17 +0000 [thread overview]
Message-ID: <bug-105069-4-eirNKlUqx3@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105069-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105069
--- Comment #7 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #6)
> While changing mdiv= from accepting a string to Enum(something) might be
> worth it, wouldn't that be GCC 13 material? I think right now -mdiv=
> accepts random garbage like -mdiv=foobar . There is also an enum already
> but there is no 1:1
> mapping between what is assigned to sh_div_strategy from what is in
> sh_div_str,
> and sh_div_strategy probably should be a TargetVariable.
>
> Anyway, wouldn't the following be enough for now to just do:
>
> 2022-03-31 Jakub Jelinek <jakub@redhat.com>
>
> PR target/105069
> * config/sh/sh.opt (mdiv=): Add Save.
>
> --- gcc/config/sh/sh.opt.jj 2022-01-11 23:11:21.990295775 +0100
> +++ gcc/config/sh/sh.opt 2022-03-31 09:43:45.916244944 +0200
> @@ -207,7 +207,7 @@ Target RejectNegative Mask(ALIGN_DOUBLE)
> Align doubles at 64-bit boundaries.
>
> mdiv=
> -Target RejectNegative Joined Var(sh_div_str) Init("")
> +Target Save RejectNegative Joined Var(sh_div_str) Init("")
> Division strategy, one of: call-div1, call-fp, call-table.
>
> mdivsi3_libfunc=
>
> The testcase doesn't ICE with it anymore, and e.g. i386.opt has various Save
> strings too.
Yes, that's going to work as with the patch the target value is properly saved
and restored in cl_target_option_{save,restore}.
next prev parent reply other threads:[~2022-03-31 8:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-27 14:12 [Bug c/105069] New: " jscott at posteo dot net
2022-03-27 14:14 ` [Bug target/105069] " pinskia at gcc dot gnu.org
2022-03-27 15:02 ` jscott at posteo dot net
2022-03-28 9:34 ` jakub at gcc dot gnu.org
2022-03-28 9:34 ` jakub at gcc dot gnu.org
2022-03-28 10:36 ` marxin at gcc dot gnu.org
2022-03-31 7:32 ` marxin at gcc dot gnu.org
2022-03-31 8:01 ` jakub at gcc dot gnu.org
2022-03-31 8:09 ` marxin at gcc dot gnu.org [this message]
2022-04-06 15:42 ` cvs-commit at gcc dot gnu.org
2022-04-06 15:45 ` jakub at gcc dot gnu.org
2022-05-06 8:33 ` [Bug target/105069] [12/13 " jakub at gcc dot gnu.org
2023-05-08 12:24 ` [Bug target/105069] [12/13/14 " rguenth at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-105069-4-eirNKlUqx3@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).