[Bug c/105151] New: [12 Regression] ICE in gimple_range_global, at value-query.cc:424

[Bug c/105151] New: [12 Regression] ICE in gimple_range_global, at value-query.cc:424

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105151

            Bug ID: 105151
           Summary: [12 Regression] ICE in gimple_range_global, at
                    value-query.cc:424
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Started between 20211121 and 20211128 :


$ cat z1.c
int __GIMPLE () foo ()
{
  int _1;
  return a_1(D);
}


$ gcc-12-20220403 -c z1.c -fgimple
z1.c: In function 'foo':
z1.c:4:10: error: anonymous SSA name cannot have default definition
    4 |   return a_1(D);
      |          ^~~
during GIMPLE pass: walloca
z1.c:1:17: internal compiler error: Segmentation fault
    1 | int __GIMPLE () foo ()
      |                 ^~~
0xe0a17f crash_signal
        ../../gcc/toplev.cc:322
0x1171d57 gimple_range_global(tree_node*)
        ../../gcc/value-query.cc:424
0x1bc9f4a ranger_cache::get_global_range(irange&, tree_node*) const
        ../../gcc/gimple-range-cache.cc:925
0x1bc5118 gimple_ranger::export_global_ranges()
        ../../gcc/gimple-range.cc:474
0x1c11061 pass_walloca::execute(function*)
        ../../gcc/gimple-ssa-warn-alloca.cc:381

[Bug c/105151] [12 Regression] ICE in gimple_range_global with invalid "gimple" language

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105151

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
                 CC|                            |aldyh at gcc dot gnu.org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2022-04-05
             Blocks|                            |101057
   Target Milestone|---                         |12.0
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
going down passes after errors is always tricky - we do stop but it seems the
diagnostic passes are still run because they are part of "lowering"
(why is pass_walloca not in pass_build_ssa_passes like
pass_warn_{printf,nonnull_compare,access}?).  In particular it seems to look
at ranger but we are not even in SSA form!?

ranger "support" was added with r12-1078-gfe9a499cb8775c which should have
moved the pass to a place where we are in SSA form or the ranger use
restricted to the late pass.

I'm testing moving of the pass.


Referenced Bugs:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101057
[Bug 101057] [gimplefe] GIMPLE frontend issues

[Bug c/105151] [12 Regression] ICE in gimple_range_global with invalid "gimple" language

[aldyh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105151

--- Comment #2 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #1)
> going down passes after errors is always tricky - we do stop but it seems
> the diagnostic passes are still run because they are part of "lowering"
> (why is pass_walloca not in pass_build_ssa_passes like
> pass_warn_{printf,nonnull_compare,access}?).  In particular it seems to look
> at ranger but we are not even in SSA form!?

Yeah, that looks like an oversight.

> 
> ranger "support" was added with r12-1078-gfe9a499cb8775c which should have
> moved the pass to a place where we are in SSA form or the ranger use
> restricted to the late pass.
> 
> I'm testing moving of the pass.

Thanks.

[Bug c/105151] [12 Regression] ICE in gimple_range_global with invalid "gimple" language

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105151

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:e68f5c90bae44e886bd1b13a135dbfd00bceea0a

commit r12-7994-ge68f5c90bae44e886bd1b13a135dbfd00bceea0a
Author: Richard Biener <rguenther@suse.de>
Date:   Tue Apr 5 09:51:32 2022 +0200

    c/105151 - move early walloca pass

    When the walloca pass gained support for ranger the early pass
    was not moved to a place where SSA form is available but remained
    in the lowering pipeline.  For the testcase in this bug this is
    a problem because for errorneous input we still run the lowering
    pipeline but here have broken SSA form which ranger does not like.
    The solution is to rectify the mistake with using ranger without
    SSA form and move the pass which solves both issues.

    2022-04-05  Richard Biener  <rguenther@suse.de>

            PR c/105151
            * passes.def (pass_walloca): Move early instance into
            pass_build_ssa_passes to make SSA form available.

            * gcc.dg/gimplefe-error-14.c: New testcase.

[Bug c/105151] [12 Regression] ICE in gimple_range_global with invalid "gimple" language

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105151

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.