public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "wilco at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/105162] [AArch64] outline-atomics drops dmb ish barrier on __sync builtins
Date: Thu, 14 Apr 2022 11:22:34 +0000 [thread overview]
Message-ID: <bug-105162-4-5bPztXZI0k@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105162-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105162
Wilco <wilco at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |wilco at gcc dot gnu.org
--- Comment #7 from Wilco <wilco at gcc dot gnu.org> ---
(In reply to Sebastian Pop from comment #5)
> Created attachment 52762 [details]
> patch
>
> The attached patch fixes the issue for __sync builtins by adding the missing
> barrier to -march=armv8-a+nolse path in the outline-atomics functions.
>
> The patch also changes the behavior of __atomic builtins for
> -moutline-atomics -march=armv8-a+nolse to be the same as for
> -march=armv8-a+lse.
So what is your reasoning for adding the barrier to __atomic as well? Only
__sync needs the extra full barrier, but __atomic does not.
next prev parent reply other threads:[~2022-04-14 11:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 15:29 [Bug target/105162] New: " spop at gcc dot gnu.org
2022-04-05 16:55 ` [Bug target/105162] " spop at gcc dot gnu.org
2022-04-05 16:56 ` spop at gcc dot gnu.org
2022-04-05 21:18 ` spop at gcc dot gnu.org
2022-04-06 15:03 ` spop at gcc dot gnu.org
2022-04-06 21:55 ` spop at gcc dot gnu.org
2022-04-07 8:47 ` ktkachov at gcc dot gnu.org
2022-04-14 11:22 ` wilco at gcc dot gnu.org [this message]
2022-04-18 15:20 ` spop at gcc dot gnu.org
2022-05-13 17:11 ` cvs-commit at gcc dot gnu.org
2022-05-16 13:18 ` cvs-commit at gcc dot gnu.org
2022-05-16 14:40 ` cvs-commit at gcc dot gnu.org
2022-05-16 14:42 ` cvs-commit at gcc dot gnu.org
2022-05-16 14:44 ` cvs-commit at gcc dot gnu.org
2022-05-16 14:59 ` spop at gcc dot gnu.org
2022-10-27 2:28 ` pinskia at gcc dot gnu.org
2022-10-27 2:30 ` [Bug target/105162] [9/10/11/12/13 Regression] " pinskia at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-105162-4-5bPztXZI0k@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).