public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/105165] ICE in gimple_redirect_edge_and_branch, at tree-cfg.cc:6136
Date: Wed, 06 Apr 2022 10:43:12 +0000	[thread overview]
Message-ID: <bug-105165-4-c2Ih7qgDUm@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105165-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105165

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW
           Assignee|rguenth at gcc dot gnu.org         |unassigned at gcc dot gnu.org
                 CC|                            |rguenth at gcc dot gnu.org,
                   |                            |vmakarov at gcc dot gnu.org

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
It's complex lowering not being able to deal with the _Complex definition in
the
asm goto.  Why do we allow asm gotos to have outputs?

__complex__ unsigned int foo (__complex__ unsigned int a1, __complex__ unsigned
int a2)
{
  __complex__ unsigned int x;
  __complex__ unsigned int _1;
  __complex__ unsigned int _2;
  __complex__ unsigned int _9;

  <bb 2> [local count: 1073741824]:
  __asm__ goto("" : "=r" x_4 :  :  : "lab" lab);

  <bb 3> [local count: 536870913]:
  a0 = x_4;

  <bb 4> [local count: 1073741824]:
lab:
  _1 = x_4 + a1_7(D);
  _2 = _1 + a2_8(D);
  _9 = _2 + __complex__ (1, 0);
  return _9;

complex lowering isn't prepared for this.  The only thing it could do is
emit a copy on each edge and adjust SSA form accordingly but in the end
that would be expensive.  That said, the "proper" lowering would possibly
rewrite the asm in-place to sth like

  asm goto ("" : "=rR" (x$real), "=rR" (x$imag) : : : lab);


Again - why are outputs allowed for asm goto?  Can we at least disallow
complex typed outputs?

  parent reply	other threads:[~2022-04-06 10:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-05 16:18 [Bug c/105165] New: [11/12 Regression] " gscfq@t-online.de
2022-04-05 16:30 ` [Bug c/105165] " jakub at gcc dot gnu.org
2022-04-06  7:53 ` [Bug tree-optimization/105165] " rguenth at gcc dot gnu.org
2022-04-06 10:43 ` rguenth at gcc dot gnu.org [this message]
2022-04-06 11:10 ` jakub at gcc dot gnu.org
2022-04-06 11:22 ` rguenther at suse dot de
2022-04-06 11:31 ` jakub at gcc dot gnu.org
2022-04-06 11:36 ` rguenth at gcc dot gnu.org
2022-04-07  6:17 ` [Bug tree-optimization/105165] Complex lowering does not handle asm goto with complex output; " cvs-commit at gcc dot gnu.org
2022-04-07  7:00 ` cvs-commit at gcc dot gnu.org
2022-04-07  7:01 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-105165-4-c2Ih7qgDUm@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).