public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/105169] Compiling C++ code with -fpatchable-function-entry=16,14 results in references to discarded sections Date: Fri, 08 Apr 2022 12:29:25 +0000 [thread overview] Message-ID: <bug-105169-4-Dl823h1muQ@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-105169-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105169 --- Comment #11 from Richard Biener <rguenth at gcc dot gnu.org> --- (In reply to Richard Biener from comment #10) > Btw, a good example might be how we handle .vtable_map_vars for VTV which > uses handle_vtv_comdat_section instead of switch_to_section. It might have > more specialities but then it should serve as a recipie how to handle > non-ELF. So sth like the following would do the trick for ELF. But maybe better abstract a switch_to_comdat_section and re-use that from the vtv handler and this place to avoid touching in_section directly. diff --git a/gcc/targhooks.cc b/gcc/targhooks.cc index e22bc66a6c8..632c9486ccb 100644 --- a/gcc/targhooks.cc +++ b/gcc/targhooks.cc @@ -1995,8 +1995,13 @@ default_print_patchable_function_entry_1 (FILE *file, patch_area_number++; ASM_GENERATE_INTERNAL_LABEL (buf, "LPFE", patch_area_number); - switch_to_section (get_section ("__patchable_function_entries", - flags, current_function_decl)); + section *sect = get_section ("__patchable_function_entries", + flags, current_function_decl); + targetm.asm_out.named_section (sect->named.name, + sect->named.common.flags + | SECTION_LINKONCE, + current_function_decl); + in_section = sect; assemble_align (POINTER_SIZE); fputs (asm_op, file); assemble_name_raw (file, buf);
next prev parent reply other threads:[~2022-04-08 12:29 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-05 17:07 [Bug c++/105169] New: " giuliano.belinassi at gmail dot com 2022-04-06 8:08 ` [Bug c++/105169] " rguenth at gcc dot gnu.org 2022-04-06 9:29 ` marxin at gcc dot gnu.org 2022-04-06 9:40 ` marxin at gcc dot gnu.org 2022-04-06 9:53 ` rguenth at gcc dot gnu.org 2022-04-06 11:31 ` marxin at gcc dot gnu.org 2022-04-06 11:35 ` rguenther at suse dot de 2022-04-06 11:46 ` marxin at gcc dot gnu.org 2022-04-07 16:05 ` matz at gcc dot gnu.org 2022-04-08 12:11 ` marxin at gcc dot gnu.org 2022-04-08 12:23 ` rguenth at gcc dot gnu.org 2022-04-08 12:29 ` rguenth at gcc dot gnu.org [this message] 2022-04-08 12:33 ` rguenth at gcc dot gnu.org 2022-05-17 17:34 ` cvs-commit at gcc dot gnu.org 2023-07-19 6:26 ` [Bug middle-end/105169] " pinskia at gcc dot gnu.org 2023-07-19 6:26 ` pinskia at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-105169-4-Dl823h1muQ@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).