From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id ABDB53858016; Fri,  8 Apr 2022 12:33:50 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ABDB53858016
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/105169] Compiling C++ code with
 -fpatchable-function-entry=16,14 results in references to discarded sections
Date: Fri, 08 Apr 2022 12:33:50 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 11.2.1
X-Bugzilla-Keywords: link-failure
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rguenth at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-105169-4-vi0uvCJ6C8@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-105169-4@http.gcc.gnu.org/bugzilla/>
References: <bug-105169-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Apr 2022 12:33:50 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D105169

--- Comment #12 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #11)
> (In reply to Richard Biener from comment #10)
> > Btw, a good example might be how we handle .vtable_map_vars for VTV whi=
ch
> > uses handle_vtv_comdat_section instead of switch_to_section.  It might =
have
> > more specialities but then it should serve as a recipie how to handle
> > non-ELF.
>=20
> So sth like the following would do the trick for ELF.  But maybe better
> abstract a switch_to_comdat_section and re-use that from the vtv handler
> and this place to avoid touching in_section directly.

switch_to_section already takes a 'decl' as argument but that's only used
for some diagnostics.

OTOH it's a bit odd to switch to the "same" __patchable_function_entries
section but each time associate it with another decl.  A nice API will
ask for quite some bikeshedding I suppose.

So maybe just handle_pfe_comdat_section ...=