public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug plugins/105171] gcc/toplev.c: `local_tick` can overflow and become -1
Date: Tue, 05 Apr 2022 23:02:20 +0000 [thread overview]
Message-ID: <bug-105171-4-CrVepWHHV3@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105171-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105171
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Status|UNCONFIRMED |WAITING
Component|driver |plugins
Last reconfirmed| |2022-04-05
--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
> local_tick = (unsigned) tv.tv_sec * 1000 + tv.tv_usec / 1000;
The only place where local_tick is used is inside coverage.cc:
if (!flag_branch_probabilities && flag_test_coverage
&& (!local_tick || local_tick == (unsigned)-1))
/* Only remove the da file, if we're emitting coverage code and
cannot uniquely stamp it. If we can stamp it, libgcov will DTRT. */
unlink (da_file_name);
This does not make a difference really here.
Plus inside a plugin, I don't see why you care about if -frandom-seed was
supplied or not.
next prev parent reply other threads:[~2022-04-05 23:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 22:37 [Bug driver/105171] New: " jason at zx2c4 dot com
2022-04-05 22:52 ` [Bug driver/105171] gcc/toplev.c: " jason at zx2c4 dot com
2022-04-05 23:02 ` pinskia at gcc dot gnu.org [this message]
2022-04-05 23:02 ` [Bug plugins/105171] " pinskia at gcc dot gnu.org
2022-04-05 23:06 ` jason at zx2c4 dot com
2022-04-06 5:44 ` pinskia at gcc dot gnu.org
2022-04-06 7:10 ` pageexec at gmail dot com
2022-04-06 7:26 ` pinskia at gcc dot gnu.org
2022-04-06 7:50 ` jakub at gcc dot gnu.org
2022-04-06 8:01 ` pageexec at gmail dot com
2022-04-06 8:16 ` pinskia at gcc dot gnu.org
2022-04-06 8:22 ` jakub at gcc dot gnu.org
2022-04-06 8:34 ` pageexec at gmail dot com
2022-04-06 8:37 ` jakub at gcc dot gnu.org
2022-04-06 8:59 ` pageexec at gmail dot com
2022-04-06 22:46 ` jason at zx2c4 dot com
2022-04-06 22:52 ` pinskia at gcc dot gnu.org
2022-04-06 23:02 ` pinskia at gcc dot gnu.org
2022-04-06 23:11 ` jason at zx2c4 dot com
2022-04-06 23:13 ` pinskia at gcc dot gnu.org
2022-04-07 13:01 ` rguenth at gcc dot gnu.org
2022-04-14 12:18 ` jason at zx2c4 dot com
2022-04-14 13:22 ` jakub at gcc dot gnu.org
2022-04-19 19:15 ` jason at zx2c4 dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-105171-4-CrVepWHHV3@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).