From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id CBAE03858C52; Wed, 6 Apr 2022 08:59:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CBAE03858C52 From: "pageexec at gmail dot com" To: gcc-bugs@gcc.gnu.org Subject: [Bug plugins/105171] gcc/toplev.c: `local_tick` can overflow and become -1 Date: Wed, 06 Apr 2022 08:59:28 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: plugins X-Bugzilla-Version: 12.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: pageexec at gmail dot com X-Bugzilla-Status: RESOLVED X-Bugzilla-Resolution: WONTFIX X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2022 08:59:28 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D105171 --- Comment #14 from PaX Team --- (In reply to Jakub Jelinek from comment #13) > As has been said, we can't retroactively change released compilers from t= he > last 2 decades. And going forward, I think walking the save_decoded_opti= ons > is just fine and reliable, other plugins use that too. nobody talked about fixing old compilers, it's about fixing this bug on tru= nk. seriously, this is a one-liner u32->u64 change (or the simplification in coverage_finish), is the bikeshed on irrelevant tangents in over a dozen comments worth it vs. just fixing it?=