From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id B4D2338346B2; Tue, 10 May 2022 08:26:13 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B4D2338346B2
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/105186] [9/10 Regression] ICE in canonicalize_attr_name, at
 attribs.h:146
Date: Tue, 10 May 2022 08:26:13 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 12.0
X-Bugzilla-Keywords: ice-on-invalid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 9.5
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-105186-4-LIlUKFP4zI@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-105186-4@http.gcc.gnu.org/bugzilla/>
References: <bug-105186-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 10 May 2022 08:26:13 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D105186

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:73f5db083a73c6125e0203ea50c4d1f0a1c6421a

commit r10-10706-g73f5db083a73c6125e0203ea50c4d1f0a1c6421a
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Mon Apr 11 10:41:07 2022 +0200

    c-family: Initialize ridpointers for __int128 etc. [PR105186]

    The following testcase ICEs with C++ and is incorrectly rejected with C.
    The reason is that both FEs use ridpointers identifiers for CPP_KEYWORD
    and value or u.value for CPP_NAME e.g. when parsing attributes or OpenMP
    directives etc., like:
             /* Save away the identifier that indicates which attribute
                this is.  */
             identifier =3D (token->type =3D=3D CPP_KEYWORD)
               /* For keywords, use the canonical spelling, not the
                  parsed identifier.  */
               ? ridpointers[(int) token->keyword]
               : id_token->u.value;

             identifier =3D canonicalize_attr_name (identifier);
    I've tried to change those to use ridpointers only if non-NULL and
otherwise
    use the value/u.value even for CPP_KEYWORDS, but that was a large 10 hu=
nks
    patch.

    The following patch instead just initializes ridpointers for the __intNN
    keywords.  It can't be done earlier before we record_builtin_type as th=
ere
    are 2 different spellings and if we initialize those ridpointers early,=
 the
    second record_builtin_type fails miserably.

    2022-04-11  Jakub Jelinek  <jakub@redhat.com>

            PR c++/105186
            * c-common.c (c_common_nodes_and_builtins): After registering
__int%d
            and __int%d__ builtin types, initialize corresponding ridpointe=
rs
            entry.

            * c-c++-common/pr105186.c: New test.

    (cherry picked from commit 083e8e66d2e90992fa83a53bfc3553dfa91abda1)=