[Bug debug/105214] New: [12 Regression] ICE: in connect_traces, at dwarf2cfi.cc:3074 with custom flags

[Bug debug/105214] New: [12 Regression] ICE: in connect_traces, at dwarf2cfi.cc:3074 with custom flags

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105214

            Bug ID: 105214
           Summary: [12 Regression] ICE: in connect_traces, at
                    dwarf2cfi.cc:3074 with custom flags
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: debug
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz
  Target Milestone: ---
              Host: x86_64-pc-linux-gnu
            Target: x86_64-pc-linux-gnu

Created attachment 52777
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52777&action=edit
reduced testcase

$ x86_64-pc-linux-gnu-gcc -Ofast -fnon-call-exceptions -fstack-check=generic
-fsanitize=address -fno-finite-math-only -fsignaling-nans -m32 testcase.c 
cc1: warning: '-fassociative-math' disabled; other options take precedence
during RTL pass: dwarf2
testcase.c: In function 'foo':
testcase.c:13:1: internal compiler error: in connect_traces, at
dwarf2cfi.cc:3074
   13 | }
      | ^
0x6b16a9 connect_traces
        /repo/gcc-trunk/gcc/dwarf2cfi.cc:3074
0x6b16a9 execute_dwarf2_frame
        /repo/gcc-trunk/gcc/dwarf2cfi.cc:3305
0x6b16a9 execute
        /repo/gcc-trunk/gcc/dwarf2cfi.cc:3792
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

$ x86_64-pc-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=/repo/gcc-trunk/binary-latest-amd64/bin/x86_64-pc-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/repo/gcc-trunk/binary-trunk-r12-8072-20220410001634-g71cac7de8f1-checking-yes-rtl-df-extra-amd64/bin/../libexec/gcc/x86_64-pc-linux-gnu/12.0.1/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /repo/gcc-trunk//configure --enable-languages=c,c++
--enable-valgrind-annotations --disable-nls --enable-checking=yes,rtl,df,extra
--with-cloog --with-ppl --with-isl --build=x86_64-pc-linux-gnu
--host=x86_64-pc-linux-gnu --target=x86_64-pc-linux-gnu
--with-ld=/usr/bin/x86_64-pc-linux-gnu-ld
--with-as=/usr/bin/x86_64-pc-linux-gnu-as --disable-libstdcxx-pch
--prefix=/repo/gcc-trunk//binary-trunk-r12-8072-20220410001634-g71cac7de8f1-checking-yes-rtl-df-extra-amd64
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 12.0.1 20220410 (experimental) (GCC)

[Bug target/105214] [12 Regression] ICE: in connect_traces, at dwarf2cfi.cc:3074 with custom flags

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105214

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.0

[Bug target/105214] [12 Regression] ICE: in connect_traces, at dwarf2cfi.cc:3074 with custom flags

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105214

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
           Priority|P3                          |P1
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2022-04-11
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
With r12-3221-g1313111fdec0d0de4228b5e839ca728b3e4b106e this started to ICE:
pr105214.c: In function ‘foo’:
pr105214.c:5:1: error: dead statement in EH table
    5 | foo (void)
      | ^~~
# _7 = VDEF <.MEM_5>
_8 = __builtin_alloca_with_align (6400, 32);
during GIMPLE pass: asan
pr105214.c:5:1: internal compiler error: verify_gimple failed
0x13781be verify_gimple_in_cfg(function*, bool)
        ../../gcc/tree-cfg.c:5531
0x11bebdf execute_function_todo
        ../../gcc/passes.c:2042
0x11bdb7b do_per_function
        ../../gcc/passes.c:1687
0x11bedcf execute_todo
        ../../gcc/passes.c:2096
and with r12-7214-gf0c7367b8802c47efaad87b1f2126fe6350d8b47
that turned into the connect_traces ICE.

[Bug sanitizer/105214] [12 Regression] ICE: in connect_traces, at dwarf2cfi.cc:3074 with custom flags

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105214

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dodji at gcc dot gnu.org,
                   |                            |dvyukov at gcc dot gnu.org,
                   |                            |kcc at gcc dot gnu.org,
                   |                            |marxin at gcc dot gnu.org,
                   |                            |rguenth at gcc dot gnu.org
          Component|target                      |sanitizer

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
I can take a look if you are not working on it.

[Bug sanitizer/105214] [12 Regression] ICE: in connect_traces, at dwarf2cfi.cc:3074 with custom flags

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105214

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
possibly started earlier if you also add -fexceptions

[Bug target/105214] [12 Regression] ICE: in connect_traces, at dwarf2cfi.cc:3074 with custom flags

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105214

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|sanitizer                   |target

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
oh, no - misread the bisect

[Bug target/105214] [12 Regression] ICE: in connect_traces, at dwarf2cfi.cc:3074 with custom flags

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105214

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 52782
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52782&action=edit
gcc12-pr105214.patch

Untested fix.
Another option would be not to call emit_jump (label2); but instead
  emit_jump_insn (targetm.gen_jump (label2));
  emit_barrier ();
Either we need to do pending stack adjustment before the conditional jump,
or can't do it on the unconditional jump (in the function it basically emits if
(cond) { ... } else { ... }).

[Bug target/105214] [12 Regression] ICE: in connect_traces, at dwarf2cfi.cc:3074 with custom flags

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105214

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:d481d13786cb84f6294833538133dbd6f39d2e55

commit r12-8102-gd481d13786cb84f6294833538133dbd6f39d2e55
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Apr 12 09:19:11 2022 +0200

    i386: Fix ICE caused by ix86_emit_i387_log1p [PR105214]

    The following testcase ICEs, because ix86_emit_i387_log1p attempts to
    emit something like
      if (cond)
        some_code1;
      else
        some_code2;
    and emits a conditional jump using emit_jump_insn (standard way in
    the file) and an unconditional jump using emit_jump.
    The problem with that is that if there is pending stack adjustment,
    it isn't emitted before the conditional jump, but is before the
    unconditional jump and therefore stack is adjusted only conditionally
    (at the end of some_code1 above), which makes dwarf2 pass unhappy about it
    but is a serious wrong-code even if it doesn't ICE.

    This can be fixed either by emitting pending stack adjust before the
    conditional jump as the following patch does, or by not using
      emit_jump (label2);
    and instead hand inlining what that function does except for the
    pending stack adjustment, like:
      emit_jump_insn (targetm.gen_jump (label2));
      emit_barrier ();
    In that case there will be no stack adjustment in the sequence and
    it will be done later on somewhere else.

    2022-04-12  Jakub Jelinek  <jakub@redhat.com>

            PR target/105214
            * config/i386/i386-expand.cc (ix86_emit_i387_log1p): Call
            do_pending_stack_adjust.

            * gcc.dg/asan/pr105214.c: New test.

[Bug target/105214] [12 Regression] ICE: in connect_traces, at dwarf2cfi.cc:3074 with custom flags

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105214

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.

[Bug target/105214] [12 Regression] ICE: in connect_traces, at dwarf2cfi.cc:3074 with custom flags

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105214

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:5b87d9f50b421e18be2a4ef95548182c8af2891e

commit r11-9849-g5b87d9f50b421e18be2a4ef95548182c8af2891e
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Apr 12 09:19:11 2022 +0200

    i386: Fix ICE caused by ix86_emit_i387_log1p [PR105214]

    The following testcase ICEs, because ix86_emit_i387_log1p attempts to
    emit something like
      if (cond)
        some_code1;
      else
        some_code2;
    and emits a conditional jump using emit_jump_insn (standard way in
    the file) and an unconditional jump using emit_jump.
    The problem with that is that if there is pending stack adjustment,
    it isn't emitted before the conditional jump, but is before the
    unconditional jump and therefore stack is adjusted only conditionally
    (at the end of some_code1 above), which makes dwarf2 pass unhappy about it
    but is a serious wrong-code even if it doesn't ICE.

    This can be fixed either by emitting pending stack adjust before the
    conditional jump as the following patch does, or by not using
      emit_jump (label2);
    and instead hand inlining what that function does except for the
    pending stack adjustment, like:
      emit_jump_insn (targetm.gen_jump (label2));
      emit_barrier ();
    In that case there will be no stack adjustment in the sequence and
    it will be done later on somewhere else.

    2022-04-12  Jakub Jelinek  <jakub@redhat.com>

            PR target/105214
            * config/i386/i386-expand.c (ix86_emit_i387_log1p): Call
            do_pending_stack_adjust.

            * gcc.dg/asan/pr105214.c: New test.

    (cherry picked from commit d481d13786cb84f6294833538133dbd6f39d2e55)

[Bug target/105214] [12 Regression] ICE: in connect_traces, at dwarf2cfi.cc:3074 with custom flags

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105214

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:39a2a85e96bc8c9f82807d143dbf8421d8a93091

commit r10-10708-g39a2a85e96bc8c9f82807d143dbf8421d8a93091
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Apr 12 09:19:11 2022 +0200

    i386: Fix ICE caused by ix86_emit_i387_log1p [PR105214]

    The following testcase ICEs, because ix86_emit_i387_log1p attempts to
    emit something like
      if (cond)
        some_code1;
      else
        some_code2;
    and emits a conditional jump using emit_jump_insn (standard way in
    the file) and an unconditional jump using emit_jump.
    The problem with that is that if there is pending stack adjustment,
    it isn't emitted before the conditional jump, but is before the
    unconditional jump and therefore stack is adjusted only conditionally
    (at the end of some_code1 above), which makes dwarf2 pass unhappy about it
    but is a serious wrong-code even if it doesn't ICE.

    This can be fixed either by emitting pending stack adjust before the
    conditional jump as the following patch does, or by not using
      emit_jump (label2);
    and instead hand inlining what that function does except for the
    pending stack adjustment, like:
      emit_jump_insn (targetm.gen_jump (label2));
      emit_barrier ();
    In that case there will be no stack adjustment in the sequence and
    it will be done later on somewhere else.

    2022-04-12  Jakub Jelinek  <jakub@redhat.com>

            PR target/105214
            * config/i386/i386-expand.c (ix86_emit_i387_log1p): Call
            do_pending_stack_adjust.

            * gcc.dg/asan/pr105214.c: New test.

    (cherry picked from commit d481d13786cb84f6294833538133dbd6f39d2e55)

[Bug target/105214] [12 Regression] ICE: in connect_traces, at dwarf2cfi.cc:3074 with custom flags

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105214

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:14407aba9fc03b3b29d3ffdf713369cc6a572431

commit r9-10149-g14407aba9fc03b3b29d3ffdf713369cc6a572431
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Apr 12 09:19:11 2022 +0200

    i386: Fix ICE caused by ix86_emit_i387_log1p [PR105214]

    The following testcase ICEs, because ix86_emit_i387_log1p attempts to
    emit something like
      if (cond)
        some_code1;
      else
        some_code2;
    and emits a conditional jump using emit_jump_insn (standard way in
    the file) and an unconditional jump using emit_jump.
    The problem with that is that if there is pending stack adjustment,
    it isn't emitted before the conditional jump, but is before the
    unconditional jump and therefore stack is adjusted only conditionally
    (at the end of some_code1 above), which makes dwarf2 pass unhappy about it
    but is a serious wrong-code even if it doesn't ICE.

    This can be fixed either by emitting pending stack adjust before the
    conditional jump as the following patch does, or by not using
      emit_jump (label2);
    and instead hand inlining what that function does except for the
    pending stack adjustment, like:
      emit_jump_insn (targetm.gen_jump (label2));
      emit_barrier ();
    In that case there will be no stack adjustment in the sequence and
    it will be done later on somewhere else.

    2022-04-12  Jakub Jelinek  <jakub@redhat.com>

            PR target/105214
            * config/i386/i386.c (ix86_emit_i387_log1p): Call
            do_pending_stack_adjust.

            * gcc.dg/asan/pr105214.c: New test.

    (cherry picked from commit d481d13786cb84f6294833538133dbd6f39d2e55)