public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/105219] [12 Regression] SVE: Wrong code with -O3 -msve-vector-bits=128 -mtune=thunderx Date: Wed, 27 Apr 2022 12:02:04 +0000 [thread overview] Message-ID: <bug-105219-4-QTbZwyireh@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-105219-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105219 --- Comment #14 from Richard Biener <rguenth at gcc dot gnu.org> --- (In reply to Martin Liška from comment #13) > (In reply to Richard Biener from comment #11) > > int data[128]; > > > > void __attribute((noipa)) > > foo (int *data, int n) > > { > > for (int i = 0; i < n; ++i) > > data[i] = i; > > } > > > > int main() > > { > > for (int start = 0; start < 16; ++start) > > for (int n = 1; n < 3*16; ++n) > > { > > __builtin_memset (data, 0, sizeof (data)); > > foo (&data[start], n); > > for (int j = 0; j < n; ++j) > > if (data[start + j] != j) > > __builtin_abort (); > > } > > return 0; > > } > > > > for example aborts with -O3 -mtune=intel -fno-vect-cost-model on x86_64, > > the cost model disabling is necessary to have the epilogue vectorized. > > Without a cost model we peel for the maximum number of aligned refs > > but still use the target cost to decide whether peeling is worth at all. > > This one started with r12-1181-g7ed1cd9665d8ca0f. So the following fixes the x86 failure for me. Can somebody check if that also fixes the aarch64 issue observed? diff --git a/gcc/tree-vect-loop.cc b/gcc/tree-vect-loop.cc index d7bc34636bd..3b63ab7b669 100644 --- a/gcc/tree-vect-loop.cc +++ b/gcc/tree-vect-loop.cc @@ -9977,7 +9981,7 @@ vect_transform_loop (loop_vec_info loop_vinfo, gimple *loop_vectorized_call) lowest_vf) - 1 : wi::udiv_floor (loop->nb_iterations_upper_bound + bias_for_lowest, lowest_vf) - 1); - if (main_vinfo) + if (main_vinfo && !main_vinfo->peeling_for_alignment) { unsigned int bound; poly_uint64 main_iters
next prev parent reply other threads:[~2022-04-27 12:02 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-11 13:29 [Bug target/105219] New: " acoplan at gcc dot gnu.org 2022-04-11 15:56 ` [Bug target/105219] " tnfchris at gcc dot gnu.org 2022-04-11 16:02 ` ktkachov at gcc dot gnu.org 2022-04-11 16:05 ` acoplan at gcc dot gnu.org 2022-04-11 16:12 ` tnfchris at gcc dot gnu.org 2022-04-12 11:08 ` tnfchris at gcc dot gnu.org 2022-04-12 11:30 ` rguenth at gcc dot gnu.org 2022-04-12 11:36 ` tnfchris at gcc dot gnu.org 2022-04-12 12:20 ` tnfchris at gcc dot gnu.org 2022-04-13 11:34 ` tnfchris at gcc dot gnu.org 2022-04-13 13:48 ` tnfchris at gcc dot gnu.org 2022-04-20 7:07 ` rguenth at gcc dot gnu.org 2022-04-25 7:07 ` tnfchris at gcc dot gnu.org 2022-04-27 11:56 ` [Bug tree-optimization/105219] " marxin at gcc dot gnu.org 2022-04-27 12:02 ` rguenth at gcc dot gnu.org [this message] 2022-04-27 12:06 ` rsandifo at gcc dot gnu.org 2022-04-27 12:27 ` rguenth at gcc dot gnu.org 2022-04-27 12:30 ` rguenth at gcc dot gnu.org 2022-04-27 13:44 ` avieira at gcc dot gnu.org 2022-04-28 8:10 ` cvs-commit at gcc dot gnu.org 2022-04-28 8:10 ` rguenth at gcc dot gnu.org 2022-04-28 12:17 ` rguenth at gcc dot gnu.org 2022-04-29 15:32 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-105219-4-QTbZwyireh@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).