public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug rtl-optimization/105231] [12 Regression] ICE: in rtl_verify_bb_insns, at cfgrtl.cc:2797 (flow control insn inside a basic block) with custom flags since r12-4767-g81342e95827f77c0 Date: Mon, 25 Apr 2022 07:26:06 +0000 [thread overview] Message-ID: <bug-105231-4-44Sp5dnEWC@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-105231-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105231 --- Comment #30 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>: https://gcc.gnu.org/g:4f77738c3b44cb6b7bfe2a7ef823a5d9d75c0e79 commit r12-8239-g4f77738c3b44cb6b7bfe2a7ef823a5d9d75c0e79 Author: Richard Biener <rguenther@suse.de> Date: Thu Apr 14 14:06:22 2022 +0200 rtl-optimization/105231 - distribute_notes and REG_EH_REGION The following mitigates a problem in combine distribute_notes which places an original REG_EH_REGION based on only may_trap_p which is good to test whether a non-call insn can possibly throw but not if actually it does or we care. That's something we decided at RTL expansion time where we possibly still know the insn evaluates to a constant. In fact, the REG_EH_REGION note with lp > 0 can only come from the original i3 and an assert is added to that effect. That means we only need to retain the note on i3 or, if that cannot trap, drop it but we should never move it to i2. The following places constraints on the insns to combine with non-call exceptions since we cannot handle the case where we have more than one EH side-effect in the IL. The patch also makes sure we can accumulate that on i3 and do not split a possible exception raising part of it to i2. As a special case we do not place any restriction on all externally throwing insns when there is no REG_EH_REGION present. 2022-04-22 Richard Biener <rguenther@suse.de> PR rtl-optimization/105231 * combine.cc (distribute_notes): Assert that a REG_EH_REGION with landing pad > 0 is from i3. Put any REG_EH_REGION note on i3 or drop it if the insn can not trap. (try_combine): Ensure that we can merge REG_EH_REGION notes with non-call exceptions. Ensure we are not splitting a trapping part of an insn with non-call exceptions when there is any REG_EH_REGION note to preserve. * gcc.dg/torture/pr105231.c: New testcase.
next prev parent reply other threads:[~2022-04-25 7:26 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-11 19:20 [Bug rtl-optimization/105231] New: [12 Regression] ICE: in rtl_verify_bb_insns, at cfgrtl.cc:2797 (flow control insn inside a basic block) with custom flags zsojka at seznam dot cz 2022-04-11 19:25 ` [Bug target/105231] " pinskia at gcc dot gnu.org 2022-04-12 7:46 ` [Bug rtl-optimization/105231] " rguenth at gcc dot gnu.org 2022-04-12 7:49 ` [Bug rtl-optimization/105231] [12 Regression] ICE: in rtl_verify_bb_insns, at cfgrtl.cc:2797 (flow control insn inside a basic block) with custom flags since r12-4767-g81342e95827f77c0 marxin at gcc dot gnu.org 2022-04-12 8:25 ` rguenth at gcc dot gnu.org 2022-04-12 8:42 ` rguenth at gcc dot gnu.org 2022-04-12 8:47 ` rguenth at gcc dot gnu.org 2022-04-12 9:01 ` ebotcazou at gcc dot gnu.org 2022-04-12 9:15 ` rguenther at suse dot de 2022-04-12 9:29 ` ebotcazou at gcc dot gnu.org 2022-04-12 9:34 ` rguenth at gcc dot gnu.org 2022-04-12 9:36 ` rguenth at gcc dot gnu.org 2022-04-12 9:44 ` rguenth at gcc dot gnu.org 2022-04-12 9:47 ` rguenth at gcc dot gnu.org 2022-04-12 9:57 ` ebotcazou at gcc dot gnu.org 2022-04-12 10:12 ` rguenther at suse dot de 2022-04-12 11:15 ` rguenth at gcc dot gnu.org 2022-04-12 11:23 ` jakub at gcc dot gnu.org 2022-04-12 11:27 ` jakub at gcc dot gnu.org 2022-04-12 11:37 ` rguenther at suse dot de 2022-04-12 11:39 ` jakub at gcc dot gnu.org 2022-04-12 11:47 ` rguenther at suse dot de 2022-04-13 7:37 ` ebotcazou at gcc dot gnu.org 2022-04-13 7:42 ` rguenther at suse dot de 2022-04-13 12:38 ` segher at gcc dot gnu.org 2022-04-13 12:58 ` segher at gcc dot gnu.org 2022-04-14 8:22 ` rguenth at gcc dot gnu.org 2022-04-14 10:43 ` segher at gcc dot gnu.org 2022-04-14 10:55 ` rguenther at suse dot de 2022-04-14 12:16 ` rguenth at gcc dot gnu.org 2022-04-19 15:31 ` rguenth at gcc dot gnu.org 2022-04-25 7:26 ` cvs-commit at gcc dot gnu.org [this message] 2022-04-25 7:27 ` rguenth at gcc dot gnu.org 2022-06-29 12:00 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-105231-4-44Sp5dnEWC@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).