public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenther at suse dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/105231] [12 Regression] ICE: in rtl_verify_bb_insns, at cfgrtl.cc:2797 (flow control insn inside a basic block) with custom flags since r12-4767-g81342e95827f77c0
Date: Tue, 12 Apr 2022 10:12:48 +0000	[thread overview]
Message-ID: <bug-105231-4-BBsBcEaLtO@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105231-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105231

--- Comment #14 from rguenther at suse dot de <rguenther at suse dot de> ---
On Tue, 12 Apr 2022, ebotcazou at gcc dot gnu.org wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105231
> 
> --- Comment #13 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
> > Oh, and checking for REG_EQUAL notes on i2/i3 doesn't work since they do not
> > exist there.  Likewise REG_EQUAL notes can be simply dropped which would
> > make the IL "invalid" so I think what purge_dead_edges does is premature?
> 
> Everything is consistent until combine messes things up, so I'd rather find a
> fix/kludge in combine if possible.  Penalizing everyone because of an
> artificial testcase exercising a nonsensical set of options is IMO not the way
> to go.

So my original patch still works - since combine doesn't split the block,
transfering EH edges, when it moves the note to i2 it should simply
never do that but instead drop it on the floor.

Which of course is a kludge and possibly wrong-code.

Alternatively we could mark as non-trapping

(insn 36 35 37 (set (reg:XF 95)
        (float_extend:XF (reg:SF 96))) "t.c":6:3 -1
     (expr_list:REG_EH_REGION (const_int 1 [0x1])
        (expr_list:REG_EQUAL (const_double:XF 1.8446744073709551616e+19 
[0x0.8p+65])
            (nil))))

at the point we remove the REG_EH_REGION note because of the
REG_EQUAL note?  Because we know it won't trap.

  parent reply	other threads:[~2022-04-12 10:12 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11 19:20 [Bug rtl-optimization/105231] New: [12 Regression] ICE: in rtl_verify_bb_insns, at cfgrtl.cc:2797 (flow control insn inside a basic block) with custom flags zsojka at seznam dot cz
2022-04-11 19:25 ` [Bug target/105231] " pinskia at gcc dot gnu.org
2022-04-12  7:46 ` [Bug rtl-optimization/105231] " rguenth at gcc dot gnu.org
2022-04-12  7:49 ` [Bug rtl-optimization/105231] [12 Regression] ICE: in rtl_verify_bb_insns, at cfgrtl.cc:2797 (flow control insn inside a basic block) with custom flags since r12-4767-g81342e95827f77c0 marxin at gcc dot gnu.org
2022-04-12  8:25 ` rguenth at gcc dot gnu.org
2022-04-12  8:42 ` rguenth at gcc dot gnu.org
2022-04-12  8:47 ` rguenth at gcc dot gnu.org
2022-04-12  9:01 ` ebotcazou at gcc dot gnu.org
2022-04-12  9:15 ` rguenther at suse dot de
2022-04-12  9:29 ` ebotcazou at gcc dot gnu.org
2022-04-12  9:34 ` rguenth at gcc dot gnu.org
2022-04-12  9:36 ` rguenth at gcc dot gnu.org
2022-04-12  9:44 ` rguenth at gcc dot gnu.org
2022-04-12  9:47 ` rguenth at gcc dot gnu.org
2022-04-12  9:57 ` ebotcazou at gcc dot gnu.org
2022-04-12 10:12 ` rguenther at suse dot de [this message]
2022-04-12 11:15 ` rguenth at gcc dot gnu.org
2022-04-12 11:23 ` jakub at gcc dot gnu.org
2022-04-12 11:27 ` jakub at gcc dot gnu.org
2022-04-12 11:37 ` rguenther at suse dot de
2022-04-12 11:39 ` jakub at gcc dot gnu.org
2022-04-12 11:47 ` rguenther at suse dot de
2022-04-13  7:37 ` ebotcazou at gcc dot gnu.org
2022-04-13  7:42 ` rguenther at suse dot de
2022-04-13 12:38 ` segher at gcc dot gnu.org
2022-04-13 12:58 ` segher at gcc dot gnu.org
2022-04-14  8:22 ` rguenth at gcc dot gnu.org
2022-04-14 10:43 ` segher at gcc dot gnu.org
2022-04-14 10:55 ` rguenther at suse dot de
2022-04-14 12:16 ` rguenth at gcc dot gnu.org
2022-04-19 15:31 ` rguenth at gcc dot gnu.org
2022-04-25  7:26 ` cvs-commit at gcc dot gnu.org
2022-04-25  7:27 ` rguenth at gcc dot gnu.org
2022-06-29 12:00 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-105231-4-BBsBcEaLtO@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).