From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 05FBE3858D37; Tue, 12 Apr 2022 10:45:29 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 05FBE3858D37
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/105234] [12 Regression] inlining failed in call to
 'always_inline' 'memset': target specific option mismatch since
 r12-5920-g01ad8c54fdca1d
Date: Tue, 12 Apr 2022 10:45:29 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 12.0
X-Bugzilla-Keywords: rejects-valid
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jakub at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 12.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-105234-4-P6iDY0iXPK@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-105234-4@http.gcc.gnu.org/bugzilla/>
References: <bug-105234-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Apr 2022 10:45:30 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D105234

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
On the other side, most of the targets actually don't initialize
target_option_default_node.  List of targets that do so:
aarch64/aarch64.cc:  target_option_default_node =3D target_option_current_n=
ode
arm/arm.cc:  target_option_default_node =3D target_option_current_node
csky/csky.cc:  target_option_default_node =3D target_option_current_node
i386/i386-options.cc:      target_option_default_node =3D
target_option_current_node
nios2/nios2.cc:  target_option_default_node =3D target_option_current_node
pru/pru.cc:  target_option_default_node =3D target_option_current_node
rs6000/rs6000.cc:    target_option_default_node =3D target_option_current_n=
ode
s390/s390.cc:  target_option_default_node =3D build_target_option_node
(&global_options, &global_options_set);
v850/v850.cc:  target_option_default_node =3D target_option_current_node
and list of targets that actually support target attribute:
aarch64/aarch64.cc:#define TARGET_OPTION_VALID_ATTRIBUTE_P
aarch64_option_valid_attribute_p
arm/arm.cc:#define TARGET_OPTION_VALID_ATTRIBUTE_P arm_valid_target_attribu=
te_p
i386/i386.cc:#define TARGET_OPTION_VALID_ATTRIBUTE_P
ix86_valid_target_attribute_p
nios2/nios2.cc:#define TARGET_OPTION_VALID_ATTRIBUTE_P
nios2_valid_target_attribute_p
rs6000/rs6000.cc:#define TARGET_OPTION_VALID_ATTRIBUTE_P
rs6000_valid_attribute_p
s390/s390.cc:#define TARGET_OPTION_VALID_ATTRIBUTE_P
s390_valid_target_attribute_p

So perhaps the generic r12-5920 change should be guarded on
target_option_default_node being non-NULL, so that targets that don't care =
can
stay as is?
The question is what to do with csky, pru and v850 that initialize it but d=
on't
support target attributes?=