[Bug sanitizer/105235] New: [12 Regression] ICE: in redirect_eh_edge_1, at tree-eh.cc:2323 with custom flags

[Bug sanitizer/105235] New: [12 Regression] ICE: in redirect_eh_edge_1, at tree-eh.cc:2323 with custom flags

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105235

            Bug ID: 105235
           Summary: [12 Regression] ICE: in redirect_eh_edge_1, at
                    tree-eh.cc:2323 with custom flags
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: sanitizer
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz
                CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
                    jakub at gcc dot gnu.org, kcc at gcc dot gnu.org, marxin at gcc dot gnu.org
  Target Milestone: ---
              Host: x86_64-pc-linux-gnu

Created attachment 52788
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52788&action=edit
reduced testcase

Compiler output:
$ x86_64-pc-linux-gnu-gcc -O -fno-tree-dominator-opts -fnon-call-exceptions
-fsanitize=thread -fno-tree-fre testcase.c 
during GIMPLE pass: sink
testcase.c: In function 'foo':
testcase.c:2:1: internal compiler error: in redirect_eh_edge_1, at
tree-eh.cc:2323
    2 | foo (double d)
      | ^~~
0x79d4e2 redirect_eh_edge_1
        /repo/gcc-trunk/gcc/tree-eh.cc:2323
0x13f6822 redirect_eh_edge(edge_def*, basic_block_def*)
        /repo/gcc-trunk/gcc/tree-eh.cc:2388
0xe7c329 redirect_edge_and_branch(edge_def*, basic_block_def*)
        /repo/gcc-trunk/gcc/cfghooks.cc:388
0x13c8105 gimple_split_edge
        /repo/gcc-trunk/gcc/tree-cfg.cc:2983
0xe7c9a3 split_edge(edge_def*)
        /repo/gcc-trunk/gcc/cfghooks.cc:668
0x13db657 split_critical_edges(bool)
        /repo/gcc-trunk/gcc/tree-cfg.cc:9172
0x158a5af split_edges_for_insertion()
        /repo/gcc-trunk/gcc/tree-cfg.h:130
0x158a5af execute
        /repo/gcc-trunk/gcc/tree-ssa-sink.cc:846
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.


$ x86_64-pc-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=/repo/gcc-trunk/binary-latest-amd64/bin/x86_64-pc-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/repo/gcc-trunk/binary-trunk-r12-8090-20220411190659-g1774ab84863-checking-yes-rtl-df-extra-pr105211-pr105214-amd64/bin/../libexec/gcc/x86_64-pc-linux-gnu/12.0.1/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /repo/gcc-trunk//configure --enable-languages=c,c++
--enable-valgrind-annotations --disable-nls --enable-checking=yes,rtl,df,extra
--with-cloog --with-ppl --with-isl --build=x86_64-pc-linux-gnu
--host=x86_64-pc-linux-gnu --target=x86_64-pc-linux-gnu
--with-ld=/usr/bin/x86_64-pc-linux-gnu-ld
--with-as=/usr/bin/x86_64-pc-linux-gnu-as --disable-libstdcxx-pch
--prefix=/repo/gcc-trunk//binary-trunk-r12-8090-20220411190659-g1774ab84863-checking-yes-rtl-df-extra-pr105211-pr105214-amd64
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 12.0.1 20220411 (experimental) (GCC)

[Bug sanitizer/105235] [12 Regression] ICE: in redirect_eh_edge_1, at tree-eh.cc:2323 with custom flags

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105235

--- Comment #1 from Zdenek Sojka <zsojka at seznam dot cz> ---
A slightly different testcase fails elsewhere:

$ cat testcase.c
int i, j;

void
foo (double d)
{
  i = __builtin_ilogbl (d);
  j = __builtin_sinl (d);
}

$ x86_64-pc-linux-gnu-gcc -O -fno-tree-dominator-opts -fnon-call-exceptions
-fsanitize=thread -fno-tree-fre testcase.c 
testcase.c: In function 'foo':
testcase.c:4:1: error: BB 3 cannot throw but has an EH edge
    4 | foo (double d)
      | ^~~
during GIMPLE pass: sincos
testcase.c:4:1: internal compiler error: verify_flow_info failed
0xe7c00e verify_flow_info()
        /repo/gcc-trunk/gcc/cfghooks.cc:284
0x128704a execute_function_todo
        /repo/gcc-trunk/gcc/passes.cc:2097
0x128755e execute_todo
        /repo/gcc-trunk/gcc/passes.cc:2139
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

[Bug sanitizer/105235] [11/12 Regression] ICE: in redirect_eh_edge_1, at tree-eh.cc:2323 with custom flags since r11-4519-g53dede0f04bd95c3

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105235

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aoliva at gcc dot gnu.org
            Summary|[12 Regression] ICE: in     |[11/12 Regression] ICE: in
                   |redirect_eh_edge_1, at      |redirect_eh_edge_1, at
                   |tree-eh.cc:2323 with custom |tree-eh.cc:2323 with custom
                   |flags                       |flags since
                   |                            |r11-4519-g53dede0f04bd95c3
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2022-04-12
             Status|UNCONFIRMED                 |NEW

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
With -c -O -fno-tree-dominator-opts -fnon-call-exceptions -fexceptions
-fsanitize=thread -fno-tree-fre
it started with r11-4519-g53dede0f04bd95c3.

[Bug sanitizer/105235] [11/12 Regression] ICE: in redirect_eh_edge_1, at tree-eh.cc:2323 with custom flags since r11-4519-g53dede0f04bd95c3

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105235

--- Comment #3 from Zdenek Sojka <zsojka at seznam dot cz> ---
(In reply to Martin Liška from comment #2)
> With -c -O -fno-tree-dominator-opts -fnon-call-exceptions -fexceptions
> -fsanitize=thread -fno-tree-fre
> it started with r11-4519-g53dede0f04bd95c3.

Sorry I forgot to check with -fexception -fnon-call-exceptions for the older
releases

[Bug sanitizer/105235] [11/12 Regression] ICE: in redirect_eh_edge_1, at tree-eh.cc:2323 with custom flags since r11-4519-g53dede0f04bd95c3

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105235

--- Comment #4 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to Zdenek Sojka from comment #3)
> (In reply to Martin Liška from comment #2)
> > With -c -O -fno-tree-dominator-opts -fnon-call-exceptions -fexceptions
> > -fsanitize=thread -fno-tree-fre
> > it started with r11-4519-g53dede0f04bd95c3.
> 
> Sorry I forgot to check with -fexception -fnon-call-exceptions for the older
> releases

That's fine, I actually noticed that once I bisected that first time.

[Bug sanitizer/105235] [11/12 Regression] ICE: in redirect_eh_edge_1, at tree-eh.cc:2323 with custom flags since r11-4519-g53dede0f04bd95c3

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105235

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Zdenek Sojka from comment #1)
> A slightly different testcase fails elsewhere:
> 
> $ cat testcase.c
> int i, j;
> 
> void
> foo (double d)
> {
>   i = __builtin_ilogbl (d);
>   j = __builtin_sinl (d);
> }
> 
> $ x86_64-pc-linux-gnu-gcc -O -fno-tree-dominator-opts -fnon-call-exceptions
> -fsanitize=thread -fno-tree-fre testcase.c 
> testcase.c: In function 'foo':
> testcase.c:4:1: error: BB 3 cannot throw but has an EH edge
>     4 | foo (double d)
>       | ^~~
> during GIMPLE pass: sincos
> testcase.c:4:1: internal compiler error: verify_flow_info failed
> 0xe7c00e verify_flow_info()
>         /repo/gcc-trunk/gcc/cfghooks.cc:284
> 0x128704a execute_function_todo
>         /repo/gcc-trunk/gcc/passes.cc:2097
> 0x128755e execute_todo
>         /repo/gcc-trunk/gcc/passes.cc:2139
> Please submit a full bug report, with preprocessed source (by using
> -freport-bug).
> Please include the complete backtrace with any bug report.
> See <https://gcc.gnu.org/bugs/> for instructions.

Testing a patch for this

[Bug sanitizer/105235] [11/12 Regression] ICE: in redirect_eh_edge_1, at tree-eh.cc:2323 with custom flags since r11-4519-g53dede0f04bd95c3

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105235

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2
   Target Milestone|---                         |11.3

[Bug sanitizer/105235] [11/12 Regression] ICE: in redirect_eh_edge_1, at tree-eh.cc:2323 with custom flags since r11-4519-g53dede0f04bd95c3

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105235

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
This has nothing to do with the sanitizers.

// PR tree-optimization/105235
// { dg-do compile }
// { dg-options "-O -fno-tree-dominator-opts -fexceptions -fnon-call-exceptions
-fno-tree-fre" }

struct S { ~S (); };

double
foo (double d)
{
  S s;
  return __builtin_ilogbl (d) + __builtin_sinl (d);
}

or

// PR tree-optimization/105235
// { dg-do compile }
// { dg-options "-O -fno-tree-dominator-opts -fexceptions -fnon-call-exceptions
-fno-tree-fre" }

struct T { ~T (); };
int i, j;

void
bar (double d)
{
  T t;
  i = __builtin_ilogbl (d);
  j = __builtin_sinl (d);
}

ICE the same way.

[Bug tree-optimization/105235] [11/12 Regression] ICE: in redirect_eh_edge_1, at tree-eh.cc:2323 with custom flags since r11-4519-g53dede0f04bd95c3

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105235

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
Also seems to fix the first testcase.

[Bug tree-optimization/105235] [11/12 Regression] ICE: in redirect_eh_edge_1, at tree-eh.cc:2323 with custom flags since r11-4519-g53dede0f04bd95c3

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105235

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org

[Bug tree-optimization/105235] [11/12 Regression] ICE: in redirect_eh_edge_1, at tree-eh.cc:2323 with custom flags since r11-4519-g53dede0f04bd95c3

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105235

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:31cccadcf2d3cc8acb7a5f36ed57ca847f7ea0ea

commit r12-8107-g31cccadcf2d3cc8acb7a5f36ed57ca847f7ea0ea
Author: Richard Biener <rguenther@suse.de>
Date:   Tue Apr 12 10:07:10 2022 +0200

    tree-optimization/105235 - clean EH in execute_cse_conv_1

    When a FP conversion is removed we have to eventually clean EH.

    2022-04-12  Richard Biener  <rguenther@suse.de>

            PR tree-optimization/105235
            * tree-ssa-math-opts.cc (execute_cse_conv_1): Clean EH and
            return whether the CFG changed.
            (execute_cse_sincos_1): Adjust.

            * g++.dg/opt/pr105235-1.C: New testcase.

[Bug tree-optimization/105235] [11 Regression] ICE: in redirect_eh_edge_1, at tree-eh.cc:2323 with custom flags since r11-4519-g53dede0f04bd95c3

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105235

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:28ef9276654856b53ba45f0082e6579c365e2962

commit r11-9814-g28ef9276654856b53ba45f0082e6579c365e2962
Author: Richard Biener <rguenther@suse.de>
Date:   Tue Apr 12 10:07:10 2022 +0200

    tree-optimization/105235 - clean EH in execute_cse_conv_1

    When a FP conversion is removed we have to eventually clean EH.

    2022-04-12  Richard Biener  <rguenther@suse.de>

            PR tree-optimization/105235
            * tree-ssa-math-opts.c (execute_cse_conv_1): Clean EH and
            return whether the CFG changed.
            (execute_cse_sincos_1): Adjust.

            * g++.dg/opt/pr105235-1.C: New testcase.

    (cherry picked from commit 31cccadcf2d3cc8acb7a5f36ed57ca847f7ea0ea)

[Bug tree-optimization/105235] [11 Regression] ICE: in redirect_eh_edge_1, at tree-eh.cc:2323 with custom flags since r11-4519-g53dede0f04bd95c3

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105235

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |11.2.1
      Known to fail|                            |11.2.0
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.