public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/105256] [9/10 Regression] ICE compiling firefox-99
Date: Wed, 11 May 2022 06:26:42 +0000	[thread overview]
Message-ID: <bug-105256-4-lMowjmpjuq@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105256-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105256

--- Comment #36 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:30895a25ea94e0ba47f97803137f2a0a42af848c

commit r9-10150-g30895a25ea94e0ba47f97803137f2a0a42af848c
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Apr 19 18:27:41 2022 +0200

    c++: Fix up CONSTRUCTOR_PLACEHOLDER_BOUNDARY handling [PR105256]

    The CONSTRUCTOR_PLACEHOLDER_BOUNDARY bit is supposed to separate
    PLACEHOLDER_EXPRs that should be replaced by one object or subobjects of it
    (variable, TARGET_EXPR slot, ...) from other PLACEHOLDER_EXPRs that should
    be replaced by different objects or subobjects.
    The bit is set when finding PLACEHOLDER_EXPRs inside of a CONSTRUCTOR, not
    looking into nested CONSTRUCTOR_PLACEHOLDER_BOUNDARY ctors, and we prevent
    elision of TARGET_EXPRs (through TARGET_EXPR_NO_ELIDE) whose initializer
    is a CONSTRUCTOR_PLACEHOLDER_BOUNDARY ctor.  The following testcase ICEs
    though, we don't replace the placeholders in there at all, because
    CONSTRUCTOR_PLACEHOLDER_BOUNDARY isn't set on the TARGET_EXPR_INITIAL
    ctor, but on a ctor nested in such a ctor.  replace_placeholders should be
    run on the whole TARGET_EXPR slot.

    So, the following patch fixes it by moving the
CONSTRUCTOR_PLACEHOLDER_BOUNDARY
    bit from nested CONSTRUCTORs to the CONSTRUCTOR containing those (but only
    if it is closely nested, if there is some other tree sandwiched in between,
    it doesn't do it).

    2022-04-19  Jakub Jelinek  <jakub@redhat.com>

            PR c++/105256
            * typeck2.c (process_init_constructor_array,
            process_init_constructor_record, process_init_constructor_union):
Move
            CONSTRUCTOR_PLACEHOLDER_BOUNDARY flag from CONSTRUCTOR elements to
the
            containing CONSTRUCTOR.

            * g++.dg/cpp0x/pr105256.C: New test.

    (cherry picked from commit eb03e424598d30fed68801af6d6ef6236d32e32e)

  parent reply	other threads:[~2022-05-11  6:26 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-13  8:01 [Bug c++/105256] New: " chris2553 at googlemail dot com
2022-04-13  8:07 ` [Bug c++/105256] " rguenth at gcc dot gnu.org
2022-04-13 15:22 ` chris2553 at googlemail dot com
2022-04-13 15:57 ` chris2553 at googlemail dot com
2022-04-13 15:58 ` chris2553 at googlemail dot com
2022-04-13 15:59 ` chris2553 at googlemail dot com
2022-04-13 18:05 ` chris2553 at googlemail dot com
2022-04-13 18:17 ` mpolacek at gcc dot gnu.org
2022-04-13 18:41 ` mpolacek at gcc dot gnu.org
2022-04-13 18:47 ` pinskia at gcc dot gnu.org
2022-04-13 18:55 ` mpolacek at gcc dot gnu.org
2022-04-13 19:13 ` marxin at gcc dot gnu.org
2022-04-13 19:16 ` mpolacek at gcc dot gnu.org
2022-04-13 19:17 ` mpolacek at gcc dot gnu.org
2022-04-13 19:21 ` [Bug c++/105256] [9/10/11/12 Regression] " mpolacek at gcc dot gnu.org
2022-04-13 19:25 ` mpolacek at gcc dot gnu.org
2022-04-14 10:14 ` jakub at gcc dot gnu.org
2022-04-14 12:14 ` chris2553 at googlemail dot com
2022-04-14 13:10 ` jakub at gcc dot gnu.org
2022-04-14 13:24 ` jakub at gcc dot gnu.org
2022-04-14 13:27 ` mpolacek at gcc dot gnu.org
2022-04-14 13:33 ` jakub at gcc dot gnu.org
2022-04-14 13:52 ` jakub at gcc dot gnu.org
2022-04-14 14:14 ` jakub at gcc dot gnu.org
2022-04-14 15:47 ` chris2553 at googlemail dot com
2022-04-14 20:04 ` chris2553 at googlemail dot com
2022-04-19  7:16 ` rguenth at gcc dot gnu.org
2022-04-19  8:29 ` marxin at gcc dot gnu.org
2022-04-19  8:38 ` rguenth at gcc dot gnu.org
2022-04-19 16:28 ` cvs-commit at gcc dot gnu.org
2022-04-19 16:37 ` [Bug c++/105256] [9/10/11 " jakub at gcc dot gnu.org
2022-04-20  6:46 ` cvs-commit at gcc dot gnu.org
2022-04-20  6:46 ` [Bug c++/105256] [9/10 " jakub at gcc dot gnu.org
2022-04-20 12:02 ` chris2553 at googlemail dot com
2022-05-09 16:22 ` cvs-commit at gcc dot gnu.org
2022-05-10  8:26 ` cvs-commit at gcc dot gnu.org
2022-05-11  6:26 ` cvs-commit at gcc dot gnu.org [this message]
2022-05-11  6:36 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-105256-4-lMowjmpjuq@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).