public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dmalcolm at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug analyzer/105273] -Wanalyzer-use-of-uninitialized-value warns on "missing" default for switch when callers can be statically determined
Date: Thu, 12 Jan 2023 21:05:16 +0000	[thread overview]
Message-ID: <bug-105273-4-uQ8m6bIwOz@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105273-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105273

--- Comment #6 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Another instance from Doom, this time where the enum is in a field lookup,
rather than an input parameter:

p_maputl.c: In function ‘P_BoxOnLineSide’:
p_maputl.c:151:8: warning: use of uninitialized value ‘p1’ [CWE-457]
[-Wanalyzer-use-of-uninitialized-value]
  151 |     if (p1 == p2)
      |        ^
  ‘P_BoxOnLineSide’: events 1-5
    |
    |  115 |     int         p1;
    |      |                 ^~
    |      |                 |
    |      |                 (1) region created on stack here
    |      |                 (2) capacity: 4 bytes
    |......
    |  118 |     switch (ld->slopetype)
    |      |     ~~~~~~       
    |      |     |
    |      |     (3) following ‘default:’ branch...
    |......
    |  151 |     if (p1 == p2)
    |      |        ~         
    |      |        |
    |      |        (4) ...to here
    |      |        (5) use of uninitialized value ‘p1’ here
    |

where r_defs.h has:

//
// Move clipping aid for LineDefs.
//
typedef enum
{
    ST_HORIZONTAL,
    ST_VERTICAL,
    ST_POSITIVE,
    ST_NEGATIVE

} slopetype_t;

typedef struct line_s
{
    [...snip...]

    // To aid move clipping.
    slopetype_t slopetype;

    [...snip...]
} line_t;

and all four enum values are covered by the switch statement.

  parent reply	other threads:[~2023-01-12 21:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-14 11:23 [Bug analyzer/105273] New: " avarab at gmail dot com
2022-04-14 11:25 ` [Bug analyzer/105273] " avarab at gmail dot com
2022-04-14 11:37 ` avarab at gmail dot com
2022-04-14 17:28 ` egallager at gcc dot gnu.org
2022-04-14 21:04 ` dmalcolm at gcc dot gnu.org
2023-01-12 20:06 ` dmalcolm at gcc dot gnu.org
2023-01-12 21:05 ` dmalcolm at gcc dot gnu.org [this message]
2023-01-13 22:52 ` cvs-commit at gcc dot gnu.org
2023-01-13 22:56 ` dmalcolm at gcc dot gnu.org
2023-03-29 23:36 ` dmalcolm at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-105273-4-uQ8m6bIwOz@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).