public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/105324] std::from_chars() assertion at floating_from_chars.cc:78 when parsing 1.11111111....
Date: Thu, 21 Apr 2022 10:34:40 +0000 [thread overview]
Message-ID: <bug-105324-4-bpVRuTY9aX@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105324-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105324
--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:
https://gcc.gnu.org/g:cf37107522f465d9e12af01ba68d2d1df0f18d46
commit r12-8213-gcf37107522f465d9e12af01ba68d2d1df0f18d46
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Thu Apr 21 11:26:49 2022 +0100
libstdc++: Remove bogus assertion in std::from_chars [PR105324]
I'm not sure what I was thinking when I added this assertion, maybe it
was supposed to be alignment == 1 (which is what the pmr::string actually
uses). The simplest fix is to just remove the assertion.
The assertion is no longer enabled by default on trunk, but it's still
there for the --enablke-libstdcxx-debug build, and is still wrong. The
fix is needed on the gcc-11 branch.
libstdc++-v3/ChangeLog:
PR libstdc++/105324
* src/c++17/floating_from_chars.cc (buffer_resource::do_allocate):
Remove assertion.
* testsuite/20_util/from_chars/pr105324.cc: New test.
next prev parent reply other threads:[~2022-04-21 10:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 1:40 [Bug c++/105324] New: " nishida_kenji at nintendo dot co.jp
2022-04-21 9:24 ` [Bug c++/105324] " redi at gcc dot gnu.org
2022-04-21 10:34 ` cvs-commit at gcc dot gnu.org [this message]
2022-04-21 12:34 ` cvs-commit at gcc dot gnu.org
2022-04-21 12:38 ` redi at gcc dot gnu.org
2022-05-02 21:43 ` aoliva at gcc dot gnu.org
2022-05-02 21:53 ` redi at gcc dot gnu.org
2022-05-03 17:58 ` [Bug libstdc++/105324] " cvs-commit at gcc dot gnu.org
2022-05-06 10:27 ` cvs-commit at gcc dot gnu.org
2022-05-06 10:34 ` cvs-commit at gcc dot gnu.org
2022-05-06 10:37 ` [Bug c++/105324] " aoliva at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-105324-4-bpVRuTY9aX@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).