From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 896C63856DC1; Fri, 22 Apr 2022 05:59:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 896C63856DC1 From: "570070308 at qq dot com" To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/105342] New: [Extended Asm]Memory barrier geater than a function call Date: Fri, 22 Apr 2022 05:59:01 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: middle-end X-Bugzilla-Version: 12.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: 570070308 at qq dot com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Apr 2022 05:59:01 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D105342 Bug ID: 105342 Summary: [Extended Asm]Memory barrier geater than a function call Product: gcc Version: 12.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: middle-end Assignee: unassigned at gcc dot gnu.org Reporter: 570070308 at qq dot com Target Milestone: --- This is an enhancement request, not a bug. According to doc, using the "memory" clobber effectively forms a read/write memory barrier for the compiler. Through my tests, the memory barrier's ran= ge in Extended-Asm is even greater than a function call, it will barrier the memory in the function's own stack. I think it is useless and it may even generate more complex code with inline funtion. For example in the test case: ```test.c extern unsigned long int x[512]; void test(long int,long int,long int,long int,long int); void test1(long int); void test2(); int kkk() { unsigned long int k[512]; for (size_t i=3D0; i<512; ++i ) { k[i]=3Dx[i]; } test1(k[0]); k[1]=3D3; k[2]=3D3; k[3]=3D3; k[4]=3D3; k[5]=3D3; test2(); test(k[1], k[2], k[3], k[4], k[5]); return 0; } ``` and ```test2.c void test2() { __asm__ volatile ("" : : :"memory" ); } ``` compile with=20 ``` gcc-12 -fno-stack-protector -fcf-protection=3Dnone -fno-asynchronous-unwind-tables -mgeneral-regs-only -O3 -S test.c test2.c ``` than generate ```test.s: kkk: subq $4096, %rsp orq $0, (%rsp) subq $8, %rsp leaq x(%rip), %rsi movl $512, %ecx movq %rsp, %rdi rep movsq movq (%rsp), %rdi call test1@PLT xorl %eax, %eax call test2@PLT movl $3, %r8d movl $3, %ecx movl $3, %edx movl $3, %esi movl $3, %edi call test@PLT xorl %eax, %eax addq $4104, %rsp ret ``` ```test2.s test2: ret ``` The kkk's assembly code looks neat. However, if I put the contents of test2.c in test.c, then it will generate: ```test.s kkk: subq $4096, %rsp orq $0, (%rsp) subq $8, %rsp leaq x(%rip), %rsi movl $512, %ecx movq %rsp, %rdi rep movsq movq (%rsp), %rdi call test1@PLT movq $3, 8(%rsp) movq $3, 16(%rsp) movq $3, 24(%rsp) movq $3, 32(%rsp) movq $3, 40(%rsp) movq 40(%rsp), %r8 movq 32(%rsp), %rcx movq 24(%rsp), %rdx movq 16(%rsp), %rsi movq 8(%rsp), %rdi call test@PLT xorl %eax, %eax addq $4104, %rsp ret test2: ret ``` The compiler automatically inline the function test2() and think k[1], k[2], k[3], k[4], k[5] is barrier with the extended-asm, so the inlining test2() = is even slower than not inlining it. The gcc-12 is installed by apt on ubuntu 22.04. Full compile log: ``` $ gcc-12 -fno-stack-protector -fcf-protection=3Dnone -fno-asynchronous-unwind-tables -mgeneral-regs-only -O3 -S test.c test2.c -v Using built-in specs. COLLECT_GCC=3Dgcc-12 OFFLOAD_TARGET_NAMES=3Dnvptx-none:amdgcn-amdhsa OFFLOAD_TARGET_DEFAULT=3D1 Target: x86_64-linux-gnu Configured with: ../src/configure -v --with-pkgversion=3D'Ubuntu 12-20220319-1ubuntu1' --with-bugurl=3Dfile:///usr/share/doc/gcc-12/README.B= ugs --enable-languages=3Dc,ada,c++,go,d,fortran,objc,obj-c++,m2 --prefix=3D/usr --with-gcc-major-version-only --program-suffix=3D-12 --program-prefix=3Dx86_64-linux-gnu- --enable-shared --enable-linker-build-= id --libexecdir=3D/usr/lib --without-included-gettext --enable-threads=3Dposix --libdir=3D/usr/lib --enable-nls --enable-clocale=3Dgnu --enable-libstdcxx-= debug --enable-libstdcxx-time=3Dyes --with-default-libstdcxx-abi=3Dnew --enable-gnu-unique-object --disable-vtable-verify --enable-plugin --enable-default-pie --with-system-zlib --enable-libphobos-checking=3Drelea= se --with-target-system-zlib=3Dauto --enable-objc-gc=3Dauto --enable-multiarch --disable-werror --enable-cet --with-arch-32=3Di686 --with-abi=3Dm64 --with-multilib-list=3Dm32,m64,mx32 --enable-multilib --with-tune=3Dgeneric --enable-offload-targets=3Dnvptx-none=3D/build/gcc-12-OcsLtf/gcc-12-12-2022= 0319/debian/tmp-nvptx/usr,amdgcn-amdhsa=3D/build/gcc-12-OcsLtf/gcc-12-12-20= 220319/debian/tmp-gcn/usr --enable-offload-defaulted --without-cuda-driver --enable-checking=3Drelease --build=3Dx86_64-linux-gnu --host=3Dx86_64-linux-gnu --target=3Dx86_64-linu= x-gnu Thread model: posix Supported LTO compression algorithms: zlib zstd gcc version 12.0.1 20220319 (experimental) [master r12-7719-g8ca61ad148f] (Ubuntu 12-20220319-1ubuntu1)=20 COLLECT_GCC_OPTIONS=3D'-fno-stack-protector' '-fcf-protection=3Dnone' '-fno-asynchronous-unwind-tables' '-mgeneral-regs-only' '-O3' '-S' '-v' '-mtune=3Dgeneric' '-march=3Dx86-64' /usr/lib/gcc/x86_64-linux-gnu/12/cc1 -quiet -v -imultiarch x86_64-linux-gnu test.c -quiet -dumpbase test.c -dumpbase-ext .c -mgeneral-regs-only -mtune=3Dgeneric -march=3Dx86-64 -O3 -version -fno-stack-protector -fcf-protection=3Dnone -fno-asynchronous-unwind-tables -o test.s -Wformat -Wformat-security -fstack-clash-protection GNU C17 (Ubuntu 12-20220319-1ubuntu1) version 12.0.1 20220319 (experimental) [master r12-7719-g8ca61ad148f] (x86_64-linux-gnu) compiled by GNU C version 12.0.1 20220319 (experimental) [master r12-7719-g8ca61ad148f], GMP version 6.2.1, MPFR version 4.1.0, MPC version 1.2.1, isl version isl-0.24-GMP GGC heuristics: --param ggc-min-expand=3D100 --param ggc-min-heapsize=3D131= 072 ignoring nonexistent directory "/usr/local/include/x86_64-linux-gnu" ignoring nonexistent directory "/usr/lib/gcc/x86_64-linux-gnu/12/include-fi= xed" ignoring nonexistent directory "/usr/lib/gcc/x86_64-linux-gnu/12/../../../../x86_64-linux-gnu/include" #include "..." search starts here: #include <...> search starts here: /usr/lib/gcc/x86_64-linux-gnu/12/include /usr/local/include /usr/include/x86_64-linux-gnu /usr/include End of search list. GNU C17 (Ubuntu 12-20220319-1ubuntu1) version 12.0.1 20220319 (experimental) [master r12-7719-g8ca61ad148f] (x86_64-linux-gnu) compiled by GNU C version 12.0.1 20220319 (experimental) [master r12-7719-g8ca61ad148f], GMP version 6.2.1, MPFR version 4.1.0, MPC version 1.2.1, isl version isl-0.24-GMP GGC heuristics: --param ggc-min-expand=3D100 --param ggc-min-heapsize=3D131= 072 Compiler executable checksum: 200a3dd46f0674d1a8fcf2b133bc6014 COLLECT_GCC_OPTIONS=3D'-fno-stack-protector' '-fcf-protection=3Dnone' '-fno-asynchronous-unwind-tables' '-mgeneral-regs-only' '-O3' '-S' '-v' '-mtune=3Dgeneric' '-march=3Dx86-64' /usr/lib/gcc/x86_64-linux-gnu/12/cc1 -quiet -v -imultiarch x86_64-linux-gnu test2.c -quiet -dumpbase test2.c -dumpbase-ext .c -mgeneral-regs-only -mtune=3Dgeneric -march=3Dx86-64 -O3 -version -fno-stack-protector -fcf-protection=3Dnone -fno-asynchronous-unwind-tables -o test2.s -Wformat -Wformat-security -fstack-clash-protection GNU C17 (Ubuntu 12-20220319-1ubuntu1) version 12.0.1 20220319 (experimental) [master r12-7719-g8ca61ad148f] (x86_64-linux-gnu) compiled by GNU C version 12.0.1 20220319 (experimental) [master r12-7719-g8ca61ad148f], GMP version 6.2.1, MPFR version 4.1.0, MPC version 1.2.1, isl version isl-0.24-GMP GGC heuristics: --param ggc-min-expand=3D100 --param ggc-min-heapsize=3D131= 072 ignoring nonexistent directory "/usr/local/include/x86_64-linux-gnu" ignoring nonexistent directory "/usr/lib/gcc/x86_64-linux-gnu/12/include-fi= xed" ignoring nonexistent directory "/usr/lib/gcc/x86_64-linux-gnu/12/../../../../x86_64-linux-gnu/include" #include "..." search starts here: #include <...> search starts here: /usr/lib/gcc/x86_64-linux-gnu/12/include /usr/local/include /usr/include/x86_64-linux-gnu /usr/include End of search list. GNU C17 (Ubuntu 12-20220319-1ubuntu1) version 12.0.1 20220319 (experimental) [master r12-7719-g8ca61ad148f] (x86_64-linux-gnu) compiled by GNU C version 12.0.1 20220319 (experimental) [master r12-7719-g8ca61ad148f], GMP version 6.2.1, MPFR version 4.1.0, MPC version 1.2.1, isl version isl-0.24-GMP GGC heuristics: --param ggc-min-expand=3D100 --param ggc-min-heapsize=3D131= 072 Compiler executable checksum: 200a3dd46f0674d1a8fcf2b133bc6014 COMPILER_PATH=3D/usr/lib/gcc/x86_64-linux-gnu/12/:/usr/lib/gcc/x86_64-linux= -gnu/12/:/usr/lib/gcc/x86_64-linux-gnu/:/usr/lib/gcc/x86_64-linux-gnu/12/:/= usr/lib/gcc/x86_64-linux-gnu/ LIBRARY_PATH=3D/usr/lib/gcc/x86_64-linux-gnu/12/:/usr/lib/gcc/x86_64-linux-= gnu/12/../../../x86_64-linux-gnu/:/usr/lib/gcc/x86_64-linux-gnu/12/../../..= /../lib/:/lib/x86_64-linux-gnu/:/lib/../lib/:/usr/lib/x86_64-linux-gnu/:/us= r/lib/../lib/:/usr/lib/gcc/x86_64-linux-gnu/12/../../../:/lib/:/usr/lib/ COLLECT_GCC_OPTIONS=3D'-fno-stack-protector' '-fcf-protection=3Dnone' '-fno-asynchronous-unwind-tables' '-mgeneral-regs-only' '-O3' '-S' '-v' '-mtune=3Dgeneric' '-march=3Dx86-64' ```=