public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/105346] [11/12 Regression] -Wno-free-nonheap-object false positive (on Bison-generated grammar code)
Date: Wed, 27 Apr 2022 10:17:38 +0000	[thread overview]
Message-ID: <bug-105346-4-UXolL1Nan6@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105346-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105346

--- Comment #17 from Richard Biener <rguenth at gcc dot gnu.org> ---
A possible fix would be to not run the late checks when not optimizing - in
fact
the IL for the late and early pass are the same at -O0 so the reason for
postponing them isn't there.  The only difference is inlining of always-inline
functions where one could argue we should do most -O0 diagnostics at that
state anyway.

Like with the following.  Alternatively at -O0 the very first pass instance
could do all checking but within a similar construct as the immediately
preceeding early -Wuninitialized.

diff --git a/gcc/passes.def b/gcc/passes.def
index 375d3d62d51..0442b85ee1b 100644
--- a/gcc/passes.def
+++ b/gcc/passes.def
@@ -402,6 +402,7 @@ along with GCC; see the file COPYING3.  If not see
          number of false positives from it.  */
       NEXT_PASS (pass_split_crit_edges);
       NEXT_PASS (pass_late_warn_uninitialized);
+      NEXT_PASS (pass_warn_access, /*early=*/false);
       /* uncprop replaces constants by SSA names.  This makes analysis harder
         and thus it should be run last.  */
       NEXT_PASS (pass_uncprop);
@@ -428,7 +429,6 @@ along with GCC; see the file COPYING3.  If not see
   NEXT_PASS (pass_gimple_isel);
   NEXT_PASS (pass_harden_conditional_branches);
   NEXT_PASS (pass_harden_compares);
-  NEXT_PASS (pass_warn_access, /*early=*/false);
   NEXT_PASS (pass_cleanup_cfg_post_optimizing);
   NEXT_PASS (pass_warn_function_noreturn);

  parent reply	other threads:[~2022-04-27 10:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-22 12:12 [Bug c/105346] New: " tim.vanholder at anubex dot com
2022-04-22 12:21 ` [Bug c/105346] " rguenth at gcc dot gnu.org
2022-04-26  8:10 ` tim.vanholder at anubex dot com
2022-04-26  9:20 ` tim.vanholder at anubex dot com
2022-04-26  9:21 ` [Bug c++/105346] " tim.vanholder at anubex dot com
2022-04-26  9:40 ` rguenth at gcc dot gnu.org
2022-04-26  9:52 ` [Bug middle-end/105346] " rguenth at gcc dot gnu.org
2022-04-26  9:53 ` [Bug middle-end/105346] [11/12 Regression] " rguenth at gcc dot gnu.org
2022-04-26  9:56 ` jakub at gcc dot gnu.org
2022-04-26 10:09 ` rguenther at suse dot de
2022-04-26 10:12 ` jakub at gcc dot gnu.org
2022-04-26 13:53 ` amacleod at redhat dot com
2022-04-26 14:12 ` aldyh at gcc dot gnu.org
2022-04-27  7:15 ` rguenth at gcc dot gnu.org
2022-04-27  9:06 ` aldyh at gcc dot gnu.org
2022-04-27  9:16 ` rguenth at gcc dot gnu.org
2022-04-27  9:23 ` aldyh at gcc dot gnu.org
2022-04-27 10:17 ` rguenth at gcc dot gnu.org [this message]
2023-05-29 10:06 ` [Bug middle-end/105346] [11/12/13/14 " jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-105346-4-UXolL1Nan6@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).