public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug lto/105399] [12 Regression] -O2/-Ofast -flto ICEs as internal compiler error: verify_cgraph_node failed
Date: Thu, 28 Apr 2022 13:46:15 +0000	[thread overview]
Message-ID: <bug-105399-4-QxVdwkqtoX@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105399-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105399

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:b85e79dce149df68b92ef63ca2a40ff1dfa61396

commit r12-8312-gb85e79dce149df68b92ef63ca2a40ff1dfa61396
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Apr 28 15:45:33 2022 +0200

    cgraph: Don't verify semantic_interposition flag for aliases [PR105399]

    The following testcase ICEs, because the ctors during cc1plus all have
    !opt_for_fn (decl, flag_semantic_interposition) - they have NULL
    DECL_FUNCTION_SPECIFIC_OPTIMIZATION (decl) and optimization_default_node
    is for -Ofast and so has flag_semantic_interposition cleared.
    During free lang data, we set DECL_FUNCTION_SPECIFIC_OPTIMIZATION (decl)
    for the ctor which has body (or for thunks), but don't touch it for
    aliases.
    During lto1 optimization_default_node reflects the lto1 flags which
    are -O2 rather than -Ofast and so has flag_semantic_interposition
    set, for the ctor which has body that makes no difference, but as the
    alias doesn't still have DECL_FUNCTION_SPECIFIC_OPTIMIZATION (decl) set,
    we now trigger this verification check.

    The following patch just doesn't verify it for aliases during lto1.
    Another possibility would be to set DECL_FUNCTION_SPECIFIC_OPTIMIZATION
(decl)
    during free lang data even for aliases.

    2022-04-28  Jakub Jelinek  <jakub@redhat.com>

            PR lto/105399
            * cgraph.cc (cgraph_node::verify_node): Don't verify
            semantic_interposition flag against
            opt_for_fn (decl, flag_semantic_interposition) for aliases in lto1.

            * g++.dg/lto/pr105399_0.C: New test.

  parent reply	other threads:[~2022-04-28 13:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-26 22:27 [Bug lto/105399] New: " slyfox at gcc dot gnu.org
2022-04-27  6:10 ` [Bug lto/105399] " rguenth at gcc dot gnu.org
2022-04-27  8:49 ` marxin at gcc dot gnu.org
2022-04-27  9:03 ` jakub at gcc dot gnu.org
2022-04-27  9:08 ` jakub at gcc dot gnu.org
2022-04-27  9:57 ` jakub at gcc dot gnu.org
2022-04-28 13:46 ` cvs-commit at gcc dot gnu.org [this message]
2022-04-28 13:49 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-105399-4-QxVdwkqtoX@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).