[Bug c/105404] New: new version of zlib

[Bug c/105404] New: new version of zlib

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105404

            Bug ID: 105404
           Summary: new version of zlib
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com
  Target Milestone: ---

I just noticed that the gcc trunk version of zlib is 1.2.11
and version 1.2.12 was released March 27, 2022.

Might be worth an update.

[Bug c/105404] new version of zlib

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105404

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
See the thread starting at
https://gcc.gnu.org/pipermail/gcc/2022-April/238497.html

[Bug other/105404] new version of zlib

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105404

--- Comment #2 from David Binderman <dcb314 at hotmail dot com> ---
(In reply to Jonathan Wakely from comment #1)
> See the thread starting at
> https://gcc.gnu.org/pipermail/gcc/2022-April/238497.html

Thanks for that. Nick Clifton seems to think a simple rebase should be enough.

Given that there is a CVE against version of zlib < 1.2.12, this update 
looks a bit urgent.  On the other hand, gcc trunk is getting ready
for release. 

Advice sought on timing of this upgrade.

[Bug other/105404] new version of zlib

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105404

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
No, because we don't use the buggy Z_FIXED feature.

[Bug other/105404] new version of zlib

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105404

David Binderman <dcb314 at hotmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mliska at suse dot cz

--- Comment #4 from David Binderman <dcb314 at hotmail dot com> ---
(In reply to Jonathan Wakely from comment #3)
> No, because we don't use the buggy Z_FIXED feature.

Righto. Presumably the upgrade can be postponed until after the current
version of gcc trunk is released.

I note with interest that there is a lot of old K'n'R style code in the zlib
library 
which clang warns won't compile with c2x.

It might be worth adding an extra filter to file 
contrib/filter-clang-warnings.py to remove such warnings.

Pattern /zlib/.*-Wdeprecated-non-prototype would probably work.

[Bug other/105404] new version of zlib

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105404

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org

--- Comment #5 from Martin Liška <marxin at gcc dot gnu.org> ---
> 
> Pattern /zlib/.*-Wdeprecated-non-prototype would probably work.

Sure, I can add that. I haven't seen the warning as I'm using system zlib
library.

[Bug other/105404] new version of zlib

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105404

--- Comment #6 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to David Binderman from comment #4)
> (In reply to Jonathan Wakely from comment #3)
> > No, because we don't use the buggy Z_FIXED feature.
> 
> Righto. Presumably the upgrade can be postponed until after the current
> version of gcc trunk is released.
> 
> I note with interest that there is a lot of old K'n'R style code in the zlib
> library 
> which clang warns won't compile with c2x.
> 
> It might be worth adding an extra filter to file 
> contrib/filter-clang-warnings.py to remove such warnings.
> 
> Pattern /zlib/.*-Wdeprecated-non-prototype would probably work.

Can't see the warning when I build the current zlib library with clang.
Can you please paste a build log?

[Bug other/105404] new version of zlib

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105404

--- Comment #7 from David Binderman <dcb314 at hotmail dot com> ---
(In reply to Martin Liška from comment #6)
> Can't see the warning when I build the current zlib library with clang.

You might need to switch on -Wall or (more likely) -Wextra.

> Can you please paste a build log?

Not easily. Here is one example warning, amongst many:

../../trunk.git/zlib/uncompr.c:86:13: warning: a function declaration without a
prototype is deprecated in all versions of C and is not supported in C2x
[-Wdeprecated-non-prototype]

As I say, pattern /zlib/.*-Wdeprecated-non-prototype would probably work.

[Bug other/105404] new version of zlib

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105404

--- Comment #8 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to David Binderman from comment #7)
> (In reply to Martin Liška from comment #6)
> > Can't see the warning when I build the current zlib library with clang.
> 
> You might need to switch on -Wall or (more likely) -Wextra.

Well, I use default options for that.

> 
> > Can you please paste a build log?
> 
> Not easily. Here is one example warning, amongst many:
> 
> ../../trunk.git/zlib/uncompr.c:86:13: warning: a function declaration
> without a prototype is deprecated in all versions of C and is not supported
> in C2x [-Wdeprecated-non-prototype]
> 
> As I say, pattern /zlib/.*-Wdeprecated-non-prototype would probably work.

Sure, please send a patch for it.

[Bug other/105404] new version of zlib

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105404

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chluo at cse dot cuhk.edu.hk

--- Comment #9 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 109428 has been marked as a duplicate of this bug. ***

[Bug other/105404] new version of zlib

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105404

--- Comment #10 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Note GCC does not call inflateGetHeader so it is not affected by
CVE-2022-37434.

[Bug other/105404] new version of zlib

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105404

--- Comment #11 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 109428 has been marked as a duplicate of this bug. ***