public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/105420] Bogus -Warray-bounds with non-compile time-constant variable
Date: Fri, 29 Apr 2022 06:26:16 +0000 [thread overview]
Message-ID: <bug-105420-4-bSccF8jmvS@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105420-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105420
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Keywords| |diagnostic
Blocks| |56456
Last reconfirmed| |2022-04-29
Status|UNCONFIRMED |NEW
--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC threads the Initialize_type check and effectively sees
if (Initialize_type)
{
if (virt_core >= 0)
return;
int phys_core = VirtualToPhysicalCoreMap[virt_core]; // virt_core is
negative
if (phys_core)
external();
}
else
{
int phys_core = VirtualToPhysicalCoreMap[virt_core];
if (phys_core && Initialize_type == Kernel)
external();
}
it should probably warn that virt_core is negative, not that it is literally -1
here.
I agree the diagnostic can be improved, but telling the user the execution
path considered is probably difficult (at best we might somehow be able to
emit a maybe warning).
Still there's an obvious defect in your program that's worth fixing, possibly
by refactoring of this code.
Referenced Bugs:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56456
[Bug 56456] [meta-bug] bogus/missing -Warray-bounds
next prev parent reply other threads:[~2022-04-29 6:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 13:21 [Bug tree-optimization/105420] New: " byteslice at airmail dot cc
2022-04-29 6:26 ` rguenth at gcc dot gnu.org [this message]
2022-04-29 11:42 ` [Bug tree-optimization/105420] " byteslice at airmail dot cc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-105420-4-bSccF8jmvS@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).