public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/105426] [wrong-code][regression][coroutines] range-for temporaries are not persisted in coroutines
Date: Fri, 29 Apr 2022 06:36:55 +0000	[thread overview]
Message-ID: <bug-105426-4-sgVdH9NtA0@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105426-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105426

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Iain D Sandoe <iains@gcc.gnu.org>:

https://gcc.gnu.org/g:3d8d093e820b10a4b4b2af8949a368377c0888cb

commit r13-28-g3d8d093e820b10a4b4b2af8949a368377c0888cb
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Thu Apr 28 20:06:29 2022 +0100

    c++, coroutines: Partial reversion of r12-8308-g15a176a833f23e [PR105426].

    The changes to fix PR 105287 included a tightening of the constraints on
which
    variables are promoted to frame copies.  This has exposed that we are
failing
    to name some variables that should be promoted.

    We avoid the use of DECL_UID to build anonymous symbols since that might
not
    be stable for -fcompare-debug.

    The long-term fix is to address the cases where the naming has been missed,
    but for the short-term (and for the GCC-12 branch) backing out the
additional
    constraint is proposed.

    Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>

            PR c++/105426

    gcc/cp/ChangeLog:

            * coroutines.cc (register_local_var_uses): Allow promotion of
unnamed
            temporaries to coroutine frame copies.

  parent reply	other threads:[~2022-04-29  6:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-28 15:56 [Bug c++/105426] New: " avi at scylladb dot com
2022-04-28 15:56 ` [Bug c++/105426] " avi at scylladb dot com
2022-04-28 18:55 ` iains at gcc dot gnu.org
2022-04-29  6:36 ` rguenth at gcc dot gnu.org
2022-04-29  6:36 ` cvs-commit at gcc dot gnu.org [this message]
2022-04-29  6:37 ` [Bug c++/105426] [12/13 Regression] " rguenth at gcc dot gnu.org
2022-04-29  6:40 ` iains at gcc dot gnu.org
2022-04-29  8:29 ` cvs-commit at gcc dot gnu.org
2022-04-29  8:30 ` iains at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-105426-4-sgVdH9NtA0@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).