public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/105436] [13 Regression] parse error with >= operator expression in template argument list in C++14 mode since r13-40
Date: Wed, 04 May 2022 16:02:00 +0000	[thread overview]
Message-ID: <bug-105436-4-NOIlggs71G@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105436-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105436

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Marek Polacek <mpolacek@gcc.gnu.org>:

https://gcc.gnu.org/g:79a1a01cbd0e4a491d7078783131e3f88ca7158d

commit r13-115-g79a1a01cbd0e4a491d7078783131e3f88ca7158d
Author: Marek Polacek <polacek@redhat.com>
Date:   Fri Apr 29 17:03:41 2022 -0400

    c++: parse error with >= in template argument list [PR105436]

    This patch fixes an oversight whereby we treated >= as the end of
    a template argument.  This causes problems in C++14, because in
    cp_parser_template_argument we go different ways for C++14 and C++17:

      /* It must be a non-type argument.  In C++17 any constant-expression is
         allowed.  */
      if (cxx_dialect > cxx14)
        goto general_expr;

    so in this testcase in C++14 we get "N" as the template argument but in
    C++17 it is the whole "N >= 5" expression.  So in C++14 the remaining
    ">= 5" triggered the newly-added diagnostic.

            PR c++/105436

    gcc/cp/ChangeLog:

            * parser.cc (cp_parser_next_token_ends_template_argument_p): Don't
            return true for CPP_GREATER_EQ.

    gcc/testsuite/ChangeLog:

            * g++.dg/parse/template31.C: New test.

  parent reply	other threads:[~2022-05-04 16:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-29 19:31 [Bug c++/105436] New: " ppalka at gcc dot gnu.org
2022-04-29 19:36 ` [Bug c++/105436] [13 Regression] " mpolacek at gcc dot gnu.org
2022-04-29 19:57 ` mpolacek at gcc dot gnu.org
2022-04-29 20:20 ` mpolacek at gcc dot gnu.org
2022-04-29 20:41 ` pinskia at gcc dot gnu.org
2022-04-30  7:11 ` jakub at gcc dot gnu.org
2022-04-30 14:38 ` mpolacek at gcc dot gnu.org
2022-05-02  6:45 ` rguenth at gcc dot gnu.org
2022-05-02 11:28 ` slyfox at gcc dot gnu.org
2022-05-04 15:13 ` mpolacek at gcc dot gnu.org
2022-05-04 16:02 ` cvs-commit at gcc dot gnu.org [this message]
2022-05-04 16:03 ` mpolacek at gcc dot gnu.org
2022-05-04 16:32 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-105436-4-NOIlggs71G@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).