public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/105497] -Wswitch ignores [[maybe_unused]] for an enumerator Date: Wed, 18 May 2022 14:34:54 +0000 [thread overview] Message-ID: <bug-105497-4-7EULuPBIC4@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-105497-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105497 --- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The trunk branch has been updated by Marek Polacek <mpolacek@gcc.gnu.org>: https://gcc.gnu.org/g:60fdce11dc9e5ddf671b07a3fc6ed70476860b22 commit r13-622-g60fdce11dc9e5ddf671b07a3fc6ed70476860b22 Author: Marek Polacek <polacek@redhat.com> Date: Sat May 7 16:15:49 2022 -0400 c, c++: -Wswitch warning on [[maybe_unused]] enumerator [PR105497] This PR complains that we emit the "enumeration value not handled in switch" warning even though the enumerator was marked with the [[maybe_unused]] attribute. I couldn't just check TREE_USED, because the enumerator could have been used earlier in the function, which doesn't play well with the c_do_switch_warnings warning. Instead, I had to check the attributes on the CONST_DECL. This is easy since the TYPE_VALUES of an enum type are now consistent between C and C++, both of which store the CONST_DECL in its TREE_VALUE. PR c++/105497 gcc/c-family/ChangeLog: * c-warn.cc (c_do_switch_warnings): Don't warn about unhandled enumerator when it was marked with attribute unused. gcc/testsuite/ChangeLog: * c-c++-common/Wswitch-1.c: New test. * g++.dg/warn/Wswitch-4.C: New test.
next prev parent reply other threads:[~2022-05-18 14:34 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-05 15:37 [Bug c++/105497] New: " olafurw at gmail dot com 2022-05-05 15:40 ` [Bug c++/105497] " mpolacek at gcc dot gnu.org 2022-05-05 15:43 ` mpolacek at gcc dot gnu.org 2022-05-18 14:34 ` cvs-commit at gcc dot gnu.org [this message] 2022-05-18 14:36 ` mpolacek at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-105497-4-7EULuPBIC4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).