From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 1F0AB3856DFA; Fri,  6 May 2022 08:28:02 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1F0AB3856DFA
From: "frank.marschner at cognitec dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/105502] New: std::normal_distribution deserialization
 issue
Date: Fri, 06 May 2022 08:28:01 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 9.4.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: frank.marschner at cognitec dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-105502-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 06 May 2022 08:28:02 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D105502

            Bug ID: 105502
           Summary: std::normal_distribution deserialization issue
           Product: gcc
           Version: 9.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: frank.marschner at cognitec dot com
  Target Milestone: ---

Found an issue deserializing an serialized instance of
std::normal_distribution.
Depending on the amount of random numbers generated deserialization
works or not.

The issue was introduced with commit
160e95dc3d73329d2367fb405ef9f0e12bd2cc7b on file bits/random.tcc from Jan 9,
2020.

The issue is in the implementation of

template< class CharT, class Traits >
friend std::basic_istream<CharT,Traits>&
    operator>>( std::basic_istream<CharT,Traits>& ist,
                normal_distribution& d );

The commit introduces wrong initialization of members param (mean and
stddev) and also _M_saved_available depending on __saved_avail.


The following example demonstrates the issue
---8<----------------------------------------------------------------
#include <iostream>
#include <sstream>
#include <random>

void test_serialization( const std::normal_distribution<>& nd)=20
{
   std::stringstream sss;
   sss << nd;

   std::normal_distribution<> newND;
   sss >> newND;

   if( nd =3D=3D newND) {
       std::cout << "Serialization successful." << std::endl;
   } else {
       std::cout << "Serialization not successful." << std::endl;
   }
}

int main( int argc, char** argv)=20
{
   std::mt19937 gen{ 42};

   std::normal_distribution<> d{ 4, 2};

   test_serialization( d);
   const auto result0 =3D d(gen);
   test_serialization( d);
   const auto result1 =3D d(gen);
   test_serialization( d);
   const auto result2 =3D d(gen);
   test_serialization( d);
}
---8<----------------------------------------------------------------

The output running the code shows

Serialization not successful.
Serialization successful.
Serialization not successful.
Serialization successful.

The issues covers gcc versions since 8.4 up to recent.=