public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/105512] compilation with -fmodules-ts and std=c++20 leads to segfault
Date: Thu, 07 Mar 2024 21:24:06 +0000	[thread overview]
Message-ID: <bug-105512-4-J0FuRnW1O2@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105512-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105512

--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:0552560f6d2eaa1ae6df5c80660b489de1d5c772

commit r14-9372-g0552560f6d2eaa1ae6df5c80660b489de1d5c772
Author: Patrick Palka <ppalka@redhat.com>
Date:   Thu Mar 7 16:23:22 2024 -0500

    c++/modules: inline namespace abi_tag streaming [PR110730]

    The unreduced testcase from PR110730 crashes at runtime ultimately
    because we don't stream the abi_tag attribute on inline namespaces and
    so the filesystem::current_path() call resolves to the non-C++11 ABI
    version even though the C++11 ABI is active, leading to a crash when
    destroying the path temporary (which contains an std::string member).
    Similar story for the PR105512 testcase.

    While we do stream the DECL_ATTRIBUTES of all decls that go through
    the generic tree streaming routines, it seems namespaces are streamed
    separately from other decls and we don't use the generic routines for
    them.  So this patch makes us stream the abi_tag manually for (inline)
    namespaces.

            PR c++/110730
            PR c++/105512

    gcc/cp/ChangeLog:

            * module.cc (module_state::write_namespaces): Stream the
            abi_tag attribute of an inline namespace.
            (module_state::read_namespaces): Likewise.

    gcc/testsuite/ChangeLog:

            * g++.dg/modules/hello-2_a.C: New test.
            * g++.dg/modules/hello-2_b.C: New test.
            * g++.dg/modules/namespace-6_a.H: New test.
            * g++.dg/modules/namespace-6_b.C: New test.

    Reviewed-by: Jason Merrill <jason@redhat.com>

  parent reply	other threads:[~2024-03-07 21:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-07  7:19 [Bug c++/105512] New: " deco33000 at yandex dot com
2023-06-18 18:02 ` [Bug c++/105512] " gnu.w2nnu at simplelogin dot com
2023-09-08 20:12 ` mail@gerrit-albrecht.de
2024-03-06 21:26 ` ppalka at gcc dot gnu.org
2024-03-07 21:24 ` cvs-commit at gcc dot gnu.org [this message]
2024-03-07 21:25 ` ppalka at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-105512-4-J0FuRnW1O2@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).