public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/105533] UBSAN: gcc/expmed.cc:3272:26: runtime error: signed integer overflow: -9223372036854775808 - 1 cannot be represented in type 'long int'
Date: Wed, 06 Mar 2024 13:56:04 +0000	[thread overview]
Message-ID: <bug-105533-4-vlmkfWGzud@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105533-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105533

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
The same function already does
offset += pop->off * BITS_PER_UNIT;
a few lines earlier, so I think doing it here is fine as well.
Or yet another option is to cast pop->off or op->off to offset_int first and do
the
left shift in offset_int type where it is well defined.
2024-03-06  Jakub Jelinek  <jakub@redhat.com>

        PR middle-end/105533
        * tree-ssa-sccvn.cc (ao_ref_init_from_vn_reference) <case ARRAY_REF>:
        Multiple op->off by BITS_PER_UNIT instead of shifting it left by
        LOG2_BITS_PER_UNIT.

--- gcc/tree-ssa-sccvn.cc.jj    2024-02-28 22:57:18.318658827 +0100
+++ gcc/tree-ssa-sccvn.cc       2024-03-06 14:52:16.819229719 +0100
@@ -1221,7 +1221,7 @@ ao_ref_init_from_vn_reference (ao_ref *r
          if (maybe_eq (op->off, -1))
            max_size = -1;
          else
-           offset += op->off << LOG2_BITS_PER_UNIT;
+           offset += op->off * BITS_PER_UNIT;
          break;

        case REALPART_EXPR:

  parent reply	other threads:[~2024-03-06 13:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09 11:27 [Bug tree-optimization/105533] New: " zsojka at seznam dot cz
2022-10-31  3:32 ` [Bug middle-end/105533] " pinskia at gcc dot gnu.org
2024-03-05 19:20 ` dcb314 at hotmail dot com
2024-03-06  9:30 ` dcb314 at hotmail dot com
2024-03-06 10:33 ` jakub at gcc dot gnu.org
2024-03-06 11:39 ` dcb314 at hotmail dot com
2024-03-06 13:37 ` jakub at gcc dot gnu.org
2024-03-06 13:45 ` jakub at gcc dot gnu.org
2024-03-06 13:56 ` jakub at gcc dot gnu.org [this message]
2024-03-06 15:16 ` jakub at gcc dot gnu.org
2024-03-07  7:32 ` rguenther at suse dot de
2024-03-07  9:08 ` cvs-commit at gcc dot gnu.org
2024-03-07  9:08 ` cvs-commit at gcc dot gnu.org
2024-03-08  8:28 ` dcb314 at hotmail dot com
2024-03-08  8:29 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-105533-4-vlmkfWGzud@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).