public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/105554] [10/11/12/13 Regression] ICE: in emit_block_move_hints, at expr.cc:1829 since r9-5509-g5928bc2ec06dd4e7
Date: Wed, 11 Jan 2023 13:03:16 +0000	[thread overview]
Message-ID: <bug-105554-4-BwCIvVhY1x@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105554-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105554

--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #7)
> (In reply to Martin Liška from comment #6)
> > We fail in the param assignment:
> > 
> > (gdb) pp x
> > (reg:V4DI 82)
> > (gdb) pp y
> > (mem/c:BLK (reg/f:DI 76 virtual-incoming-args) [1 x+0 S32 A256])
> > 
> > So we will likely need something similar to what we have in tree-inline.cc:
> > 
> >   5928    /* For vector typed decls make sure to update DECL_MODE according
> >   5929       to the new function context.  */
> >   5930    if (VECTOR_TYPE_P (TREE_TYPE (copy)))
> >   5931      SET_DECL_MODE (copy, TYPE_MODE (TREE_TYPE (copy)));
> > 
> > @Richi: Do you have a clue where to adjust it?
> 
> I think it goes wrong in use_register_for_decl (called from
> assign_parm_setup_block).
> 
> diff --git a/gcc/function.cc b/gcc/function.cc
> index d975b001ec9..b54f9b33c6a 100644
> --- a/gcc/function.cc
> +++ b/gcc/function.cc
> @@ -2229,7 +2229,9 @@ use_register_for_decl (const_tree decl)
>      }
>  
>    /* Only register-like things go in registers.  */
> -  if (DECL_MODE (decl) == BLKmode)
> +  if (DECL_MODE (decl) == BLKmode
> +      || (VECTOR_TYPE_P (TREE_TYPE (decl))
> +         && TYPE_MODE (TREE_TYPE (decl)) == BLKmode))
>      return false;
>  
>    /* If -ffloat-store specified, don't put explicit float variables
> 
> fixes the ICE, not sure if we should adjust the PARM_DECLs mode somewhere
> in target cloning instead though?

Like in copy_arguments_nochange?

  parent reply	other threads:[~2023-01-11 13:03 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-10 20:03 [Bug c/105554] New: ICE: in emit_block_move_hints, at expr.cc:1829 zhenyang.xu at uwaterloo dot ca
2022-05-11  7:33 ` [Bug target/105554] " marxin at gcc dot gnu.org
2022-05-11  7:42 ` rguenth at gcc dot gnu.org
2022-05-11  7:47 ` [Bug target/105554] [9/10/11/12/13 Regression] ICE: in emit_block_move_hints, at expr.cc:1829 since r9-5509-g5928bc2ec06dd4e7 marxin at gcc dot gnu.org
2022-05-11  7:49 ` jakub at gcc dot gnu.org
2022-05-27  9:48 ` [Bug target/105554] [10/11/12/13 " rguenth at gcc dot gnu.org
2022-06-28 10:49 ` jakub at gcc dot gnu.org
2022-07-26 11:28 ` rguenth at gcc dot gnu.org
2023-01-11 12:27 ` marxin at gcc dot gnu.org
2023-01-11 13:01 ` rguenth at gcc dot gnu.org
2023-01-11 13:03 ` rguenth at gcc dot gnu.org [this message]
2023-01-16 12:53 ` marxin at gcc dot gnu.org
2023-01-16 13:01 ` rguenther at suse dot de
2023-02-09 11:51 ` marxin at gcc dot gnu.org
2023-02-09 12:52 ` rguenth at gcc dot gnu.org
2023-03-16 14:04 ` marxin at gcc dot gnu.org
2023-03-16 18:07 ` jakub at gcc dot gnu.org
2023-03-16 18:47 ` jakub at gcc dot gnu.org
2023-03-16 18:55 ` jakub at gcc dot gnu.org
2023-03-17  8:59 ` rguenth at gcc dot gnu.org
2023-03-17  9:24 ` jakub at gcc dot gnu.org
2023-03-17  9:28 ` jakub at gcc dot gnu.org
2023-03-17  9:31 ` rguenth at gcc dot gnu.org
2023-03-17 10:02 ` jakub at gcc dot gnu.org
2023-03-17 18:00 ` cvs-commit at gcc dot gnu.org
2023-03-17 18:06 ` [Bug target/105554] [10/11/12 " jakub at gcc dot gnu.org
2023-03-19  5:31 ` cvs-commit at gcc dot gnu.org
2023-03-20 10:29 ` [Bug target/105554] [10/11 " jakub at gcc dot gnu.org
2023-05-02 20:16 ` cvs-commit at gcc dot gnu.org
2023-05-03  9:25 ` [Bug target/105554] [10 " jakub at gcc dot gnu.org
2023-05-03 15:22 ` cvs-commit at gcc dot gnu.org
2023-05-04  7:16 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-105554-4-BwCIvVhY1x@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).