From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id C7DB23858439; Thu, 16 Mar 2023 18:07:15 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C7DB23858439
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1678990035;
	bh=RvQAK9+N1NOWS4gSuIqpx9ChVghyTHiMEM0ViCR1lnA=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=I0mL27O8mqbW9Mv7uFMLfD++sD8lBzCqKsOOd//OrW2n08hJym7hX5tv+Zx/2FJu/
	 QLKDmwZxl6x0qfkghSRWDg2lYRosiXVsDZ2qnT939FARKbpL7f7ZJljnA7imDJot/T
	 IcOEmVB7D6JqlM5qbKkKOvIuB0FuE0eil//g51IE=
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/105554] [10/11/12/13 Regression] ICE: in
 emit_block_move_hints, at expr.cc:1829 since r9-5509-g5928bc2ec06dd4e7
Date: Thu, 16 Mar 2023 18:07:14 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jakub at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 10.5
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-105554-4-yPHBOKUUPL@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-105554-4@http.gcc.gnu.org/bugzilla/>
References: <bug-105554-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D105554

--- Comment #13 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
A lot of ipa passes use push_cfun:
grep push_cfun ipa*.cc
ipa-fnsummary.cc:       push_cfun (DECL_STRUCT_FUNCTION (node->decl));
ipa-fnsummary.cc:  push_cfun (DECL_STRUCT_FUNCTION (node->decl));
ipa-modref.cc:      push_cfun (f);
ipa-modref.cc:  push_cfun (DECL_STRUCT_FUNCTION (node->decl));
ipa-modref.cc:  push_cfun (DECL_STRUCT_FUNCTION (node->decl));
ipa-prop.cc:  push_cfun (func);
ipa-pure-const.cc:  push_cfun (DECL_STRUCT_FUNCTION (decl));
ipa-sra.cc:      push_cfun (DECL_STRUCT_FUNCTION (node->decl));
ipa-sra.cc:       push_cfun (fun);
ipa-utils.cc:      push_cfun (dstcfun);
ipa-visibility.cc:            push_cfun (DECL_STRUCT_FUNCTION
(e->caller->decl));
ipa-visibility.cc:                    push_cfun (DECL_STRUCT_FUNCTION
(e->caller->decl));
After all, even create_target_clone -> create_version_clone_with_body ->
tree_function_versioning already called and and then pop_cfun () again.
multiple-target.cc is something so seldom used that another push_cfun/pop_c=
fun
around the newly proposed loop wouldn't be that bad.=