public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/105556] RA assigns an MMA vector input operand to vs0-vs31 causing an MMA accumulator to be spilled
Date: Wed, 18 May 2022 02:33:59 +0000	[thread overview]
Message-ID: <bug-105556-4-hXeNP7OSzM@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105556-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105556

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Peter Bergner <bergner@gcc.gnu.org>:

https://gcc.gnu.org/g:c6e36f05fbb081abb068958d8900ad34b303a70b

commit r13-579-gc6e36f05fbb081abb068958d8900ad34b303a70b
Author: Peter Bergner <bergner@linux.ibm.com>
Date:   Tue May 17 21:09:29 2022 -0500

    rs6000: Prefer assigning the MMA vector operands to altivec registers
[PR105556]

    When optimizing the DGEMM kernel in OpenBLAS to use MMA, the MMA code
    uses all 8 accumulators, which overlap all vs0-vs31 vector registers.
    Current trunk assigns one of the normal vector inputs to one of the MMA
    instructions, which forces us to spill one of the accumulators to memory,
    leading to poor performance.  The solution here is to replace the "wa"
    constraints for the vector input operands in the MMA instruction patterns
    with "v,?wa" so that we prefer using the altivec registers vs32-vs63
    over the vs0-vs31 registers.

    2022-05-17  Peter Bergner  <bergner@linux.ibm.com>
                Segher Boessenkool  <segher@kernel.crashing.org>

    gcc/
            PR target/105556
            * config/rs6000/mma.md (mma_<vv>, mma_<avv>, mma_<pv>, mma_<apv>,
            mma_<vvi4i4i8>, mma_<avvi4i4i8>, mma_<vvi4i4i2>, mma_<avvi4i4i2>,
            mma_<vvi4i4>, mma_<avvi4i4>, mma_<pvi4i2>, mma_<apvi4i2>,
            mma_<vvi4i4i4>, mma_<avvi4i4i4>): Replace "wa" constraints with
"v,?wa".
            Update other operands accordingly.

  parent reply	other threads:[~2022-05-18  2:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-10 20:37 [Bug target/105556] New: " bergner at gcc dot gnu.org
2022-05-10 20:39 ` [Bug target/105556] " bergner at gcc dot gnu.org
2022-05-10 20:48 ` bergner at gcc dot gnu.org
2022-05-18  2:33 ` cvs-commit at gcc dot gnu.org [this message]
2022-05-18 14:49 ` bergner at gcc dot gnu.org
2022-05-20 23:00 ` cvs-commit at gcc dot gnu.org
2022-05-20 23:01 ` bergner at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-105556-4-hXeNP7OSzM@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).