public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug driver/105568] New: Superfluous --jobserver-auth= check taints further diagnostics @ 2022-05-11 13:56 pexu@gcc-bugzilla.mail.kapsi.fi 2022-10-27 4:52 ` [Bug driver/105568] [13 Regression] " pinskia at gcc dot gnu.org ` (3 more replies) 0 siblings, 4 replies; 5+ messages in thread From: pexu@gcc-bugzilla.mail.kapsi.fi @ 2022-05-11 13:56 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105568 Bug ID: 105568 Summary: Superfluous --jobserver-auth= check taints further diagnostics Product: gcc Version: 13.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: driver Assignee: unassigned at gcc dot gnu.org Reporter: pexu@gcc-bugzilla.mail.kapsi.fi Target Milestone: --- Hi. When linking with -flto=jobserver both gcc/gcc.cc and gcc/lto-wrapper.cc check if MAKEFLAGS contains "--jobserver-auth=" and if so attempt to further scrutinize its contents. Unfortunately, detect_jobserver() (at gcc/gcc.cc), which is executed always when linking, silently removes the entire "--jobserver-auth=" (up until next space) shall this scrutinization attempt fail. This makes jobserver_active_p() (at gcc/lto-wrapper.cc) always complain about a missing "--jobserver-auth=". Indeed, this might be now technically true, but it is very confusing and misleading if this was done because detect_jobserver() was not satisfied with the given "--jobserver-auth=". There a many reasons why the given "--jobserver-auth=" might be treated as non-functioning. Either GNU make is using an another jobserver type (named semaphore), the given file descriptors are inaccessible because GNU make and GCC are using different emulation layers (e.g. Mingw and Cygwin) or those simply are indeed not inherited, i.e. user forgot to add `+' to invoking GNU rule. Therefore it might be still necessary to remove the "--jobserver-auth=" but I presume this should done after jobserver_active_p(). Actually, this is already being done, as the entire MAKEFLAGS is emptied unless jobserver logic is enabled. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug driver/105568] [13 Regression] Superfluous --jobserver-auth= check taints further diagnostics 2022-05-11 13:56 [Bug driver/105568] New: Superfluous --jobserver-auth= check taints further diagnostics pexu@gcc-bugzilla.mail.kapsi.fi @ 2022-10-27 4:52 ` pinskia at gcc dot gnu.org 2023-04-26 6:56 ` [Bug driver/105568] [13/14 " rguenth at gcc dot gnu.org ` (2 subsequent siblings) 3 siblings, 0 replies; 5+ messages in thread From: pinskia at gcc dot gnu.org @ 2022-10-27 4:52 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105568 Andrew Pinski <pinskia at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |13.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug driver/105568] [13/14 Regression] Superfluous --jobserver-auth= check taints further diagnostics 2022-05-11 13:56 [Bug driver/105568] New: Superfluous --jobserver-auth= check taints further diagnostics pexu@gcc-bugzilla.mail.kapsi.fi 2022-10-27 4:52 ` [Bug driver/105568] [13 Regression] " pinskia at gcc dot gnu.org @ 2023-04-26 6:56 ` rguenth at gcc dot gnu.org 2023-07-27 9:23 ` rguenth at gcc dot gnu.org 2024-05-21 9:11 ` [Bug driver/105568] [13/14/15 " jakub at gcc dot gnu.org 3 siblings, 0 replies; 5+ messages in thread From: rguenth at gcc dot gnu.org @ 2023-04-26 6:56 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105568 Richard Biener <rguenth at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|13.0 |13.2 --- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> --- GCC 13.1 is being released, retargeting bugs to GCC 13.2. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug driver/105568] [13/14 Regression] Superfluous --jobserver-auth= check taints further diagnostics 2022-05-11 13:56 [Bug driver/105568] New: Superfluous --jobserver-auth= check taints further diagnostics pexu@gcc-bugzilla.mail.kapsi.fi 2022-10-27 4:52 ` [Bug driver/105568] [13 Regression] " pinskia at gcc dot gnu.org 2023-04-26 6:56 ` [Bug driver/105568] [13/14 " rguenth at gcc dot gnu.org @ 2023-07-27 9:23 ` rguenth at gcc dot gnu.org 2024-05-21 9:11 ` [Bug driver/105568] [13/14/15 " jakub at gcc dot gnu.org 3 siblings, 0 replies; 5+ messages in thread From: rguenth at gcc dot gnu.org @ 2023-07-27 9:23 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105568 Richard Biener <rguenth at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|13.2 |13.3 --- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> --- GCC 13.2 is being released, retargeting bugs to GCC 13.3. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug driver/105568] [13/14/15 Regression] Superfluous --jobserver-auth= check taints further diagnostics 2022-05-11 13:56 [Bug driver/105568] New: Superfluous --jobserver-auth= check taints further diagnostics pexu@gcc-bugzilla.mail.kapsi.fi ` (2 preceding siblings ...) 2023-07-27 9:23 ` rguenth at gcc dot gnu.org @ 2024-05-21 9:11 ` jakub at gcc dot gnu.org 3 siblings, 0 replies; 5+ messages in thread From: jakub at gcc dot gnu.org @ 2024-05-21 9:11 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105568 Jakub Jelinek <jakub at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|13.3 |13.4 --- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> --- GCC 13.3 is being released, retargeting bugs to GCC 13.4. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-05-21 9:11 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-05-11 13:56 [Bug driver/105568] New: Superfluous --jobserver-auth= check taints further diagnostics pexu@gcc-bugzilla.mail.kapsi.fi 2022-10-27 4:52 ` [Bug driver/105568] [13 Regression] " pinskia at gcc dot gnu.org 2023-04-26 6:56 ` [Bug driver/105568] [13/14 " rguenth at gcc dot gnu.org 2023-07-27 9:23 ` rguenth at gcc dot gnu.org 2024-05-21 9:11 ` [Bug driver/105568] [13/14/15 " jakub at gcc dot gnu.org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).